You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@kafka.apache.org by ijuma <gi...@git.apache.org> on 2017/10/28 09:05:57 UTC

[GitHub] kafka pull request #4152: MINOR: Eliminate unnecessary Topic(And)Partition a...

GitHub user ijuma opened a pull request:

    https://github.com/apache/kafka/pull/4152

    MINOR: Eliminate unnecessary Topic(And)Partition allocations in Controller

    - Eliminated all the unnecessary allocations of `TopicPartition` and
    `TopicAndPartition` in the Controller. We now use the former
    in the Controller (bringing it inline with the rest of the non legacy
    code).
    - Fixed missed `Listener` -> `Handler` renames for companion
    objects.
    - More String.format -> String interpolation conversions (the former
    is roughly 5 times more expensive).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ijuma/kafka controller-topic-partition-and-other-clean-ups

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/4152.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4152
    
----
commit 109dc13dbbf2ef3ae8c1d4857cc30c059295b4b8
Author: Ismael Juma <is...@juma.me.uk>
Date:   2017-10-27T10:25:34Z

    Use TopicPartition in Controller and avoid allocations

commit 4d04e0c69c17d3c9dd16e901d54e158c76962087
Author: Ismael Juma <is...@juma.me.uk>
Date:   2017-10-28T08:04:23Z

    Missed `Listener` -> `Handler` renames in companion objects

commit a259462c921454a129471a019700f44f16c33ab1
Author: Ismael Juma <is...@juma.me.uk>
Date:   2017-10-28T08:33:43Z

    Various log clean-ups

----


---

[GitHub] kafka pull request #4152: MINOR: Eliminate unnecessary Topic(And)Partition a...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/kafka/pull/4152


---