[GitHub] [incubator-hudi] leesf commented on a change in pull request #945: [HUDI-296] Explore use of spotless to auto fix formatting errors

[GitBox <gi...@apache.org>]

leesf commented on a change in pull request #945: [HUDI-296] Explore use of spotless to auto fix formatting errors
URL: https://github.com/apache/incubator-hudi/pull/945#discussion_r333317204
 
 

 ##########
 File path: hudi-cli/src/main/java/org/apache/hudi/cli/HoodiePrintHelper.java
 ##########
 @@ -52,19 +52,16 @@ public static String print(String[] header, String[][] rows) {
    * @param rows List of rows
    * @return Serialized form for printing
    */
-  public static String print(TableHeader rowHeader,
-      Map<String, Function<Object, String>> fieldNameToConverterMap,
-      String sortByField, boolean isDescending, Integer limit, boolean headerOnly,
-      List<Comparable[]> rows) {
+  public static String print(TableHeader rowHeader, Map<String, Function<Object, String>> fieldNameToConverterMap,
+      String sortByField, boolean isDescending, Integer limit, boolean headerOnly, List<Comparable[]> rows) {
 
     if (headerOnly) {
       return HoodiePrintHelper.print(rowHeader);
     }
 
-    Table table = new Table(rowHeader, fieldNameToConverterMap,
-        Option.ofNullable(sortByField.isEmpty() ? null : sortByField),
-        Option.ofNullable(isDescending),
-        Option.ofNullable(limit <= 0 ? null : limit)).addAllRows(rows).flip();
+    Table table =
 
 Review comment:
   This is split by spotless plugin, and the line length is defined to 120(org.eclipse.jdt.core.formatter.lineSplit) in eclipse-java-google-format.xml, we need to make org.eclipse.jdt.core.formatter.lineSplit a little larger than 120(such as 200?) to use the above line 62. But IMHO, 120 is a proper length and just let spotless plugin formats the code style, WDYT?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services