[GitHub] [superset] rusackas commented on pull request #18246: fix(listview): add nowrap to view mode container

[GitBox <gi...@apache.org>]

rusackas commented on pull request #18246:
URL: https://github.com/apache/superset/pull/18246#issuecomment-1027423912


   @villebro / @kasiazjc I'm OK with it... I can't say it's love though. I appreciate the saved real estate, but it doesn't seem like the biggest real estate hog in its vicinity. As far as the interaction itself, If the menu/dropdown opens on _hover_, it's not so bad. But otherwise, we're asking for two clicks for a toggle, which seems cumbersome. 
   
   We could make the toggler smaller, and even use some AntD components, similar to [this](https://codepen.io/rusackas/pen/OJONzmq)
   
   I think this PR solves the acute issue, so I'm approving... we can certainly continue to optimize if we feel like it, in this PR or another.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org