You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Darrel Schneider <ds...@pivotal.io> on 2016/03/14 23:45:44 UTC
Review Request 44812: removed old logging code from offheap
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44812/
-----------------------------------------------------------
Review request for geode, Kirk Lund and Sai Boorlagadda.
Repository: geode
Description
-------
Logger is now used instead of LogWriter
Diffs
-----
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/InternalDistributedSystem.java 92cb9f8f361c3e0d473f38fd225b494aa05b43b5
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/control/OffHeapMemoryMonitor.java 3ab39ea821743f5c5c7f60bd2962c5292200af6e
geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/FreeListManager.java ed7035a1923880ac078ac9e504142a5a6a040f80
geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/OffHeapStorage.java 3156067462171c63da238956aa12b0c5d414588b
geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/OffHeapStoredObjectAddressStack.java bde30e21ff59cc97aaecfbae0351535e470a3db3
geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/SimpleMemoryAllocatorImpl.java 209a4a435e6b4180237963d2763e64365dd80dba
geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/FreeListManagerTest.java 37871292986ad21d4fedb770e672982bf4afd505
geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapHelperJUnitTest.java 989abfc5f4a9949e8e7142c1b117389ff66c536a
geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapRegionEntryHelperJUnitTest.java 540bba59511c515a92a8c814a5cc1907b85302c6
geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapStorageJUnitTest.java d5db4e4cb86912a89bca07642e5cc6ca94e9fb6f
geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapStoredObjectAddressStackJUnitTest.java 8040bf7eaa1ac03b1df27ebf9c28e42d49691175
geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapStoredObjectJUnitTest.java 2f6b32c72917174390ddccdd4e44e37e4f9e2ff3
geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/SimpleMemoryAllocatorJUnitTest.java cc791fcc8f1311d62b135b82005cd36ae5e54afa
Diff: https://reviews.apache.org/r/44812/diff/
Testing
-------
precheckin
Thanks,
Darrel Schneider
Re: Review Request 44812: removed old logging code from offheap
Posted by Darrel Schneider <ds...@pivotal.io>.
> On March 14, 2016, 4:15 p.m., Kirk Lund wrote:
> >
I kept this Logger parameter since unit tests already exist that verify the mocked Logger is used as expected.
- Darrel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44812/#review123530
-----------------------------------------------------------
On March 14, 2016, 3:45 p.m., Darrel Schneider wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44812/
> -----------------------------------------------------------
>
> (Updated March 14, 2016, 3:45 p.m.)
>
>
> Review request for geode, Kirk Lund and Sai Boorlagadda.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Logger is now used instead of LogWriter
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/InternalDistributedSystem.java 92cb9f8f361c3e0d473f38fd225b494aa05b43b5
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/control/OffHeapMemoryMonitor.java 3ab39ea821743f5c5c7f60bd2962c5292200af6e
> geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/FreeListManager.java ed7035a1923880ac078ac9e504142a5a6a040f80
> geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/OffHeapStorage.java 3156067462171c63da238956aa12b0c5d414588b
> geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/OffHeapStoredObjectAddressStack.java bde30e21ff59cc97aaecfbae0351535e470a3db3
> geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/SimpleMemoryAllocatorImpl.java 209a4a435e6b4180237963d2763e64365dd80dba
> geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/FreeListManagerTest.java 37871292986ad21d4fedb770e672982bf4afd505
> geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapHelperJUnitTest.java 989abfc5f4a9949e8e7142c1b117389ff66c536a
> geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapRegionEntryHelperJUnitTest.java 540bba59511c515a92a8c814a5cc1907b85302c6
> geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapStorageJUnitTest.java d5db4e4cb86912a89bca07642e5cc6ca94e9fb6f
> geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapStoredObjectAddressStackJUnitTest.java 8040bf7eaa1ac03b1df27ebf9c28e42d49691175
> geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapStoredObjectJUnitTest.java 2f6b32c72917174390ddccdd4e44e37e4f9e2ff3
> geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/SimpleMemoryAllocatorJUnitTest.java cc791fcc8f1311d62b135b82005cd36ae5e54afa
>
> Diff: https://reviews.apache.org/r/44812/diff/
>
>
> Testing
> -------
>
> precheckin
>
>
> Thanks,
>
> Darrel Schneider
>
>
Re: Review Request 44812: removed old logging code from offheap
Posted by Kirk Lund <ki...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44812/#review123530
-----------------------------------------------------------
geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/FreeListManager.java (line 241)
<https://reviews.apache.org/r/44812/#comment185774>
I'd recommend deleting the lw parameter and just reference the static logger directly. Repeat for each of the following methods.
geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/OffHeapStoredObjectAddressStack.java (line 80)
<https://reviews.apache.org/r/44812/#comment185775>
I would go ahead and have this class define a private static Logger of its own rather than passing one in.
geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/FreeListManagerTest.java (line 738)
<https://reviews.apache.org/r/44812/#comment185776>
If you remove all of the Logger parameters and just have a private static Logger in each class then you can delete this.
geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapStoredObjectAddressStackJUnitTest.java (line 91)
<https://reviews.apache.org/r/44812/#comment185777>
Same as previous comment.
- Kirk Lund
On March 14, 2016, 10:45 p.m., Darrel Schneider wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44812/
> -----------------------------------------------------------
>
> (Updated March 14, 2016, 10:45 p.m.)
>
>
> Review request for geode, Kirk Lund and Sai Boorlagadda.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Logger is now used instead of LogWriter
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/InternalDistributedSystem.java 92cb9f8f361c3e0d473f38fd225b494aa05b43b5
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/control/OffHeapMemoryMonitor.java 3ab39ea821743f5c5c7f60bd2962c5292200af6e
> geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/FreeListManager.java ed7035a1923880ac078ac9e504142a5a6a040f80
> geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/OffHeapStorage.java 3156067462171c63da238956aa12b0c5d414588b
> geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/OffHeapStoredObjectAddressStack.java bde30e21ff59cc97aaecfbae0351535e470a3db3
> geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/SimpleMemoryAllocatorImpl.java 209a4a435e6b4180237963d2763e64365dd80dba
> geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/FreeListManagerTest.java 37871292986ad21d4fedb770e672982bf4afd505
> geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapHelperJUnitTest.java 989abfc5f4a9949e8e7142c1b117389ff66c536a
> geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapRegionEntryHelperJUnitTest.java 540bba59511c515a92a8c814a5cc1907b85302c6
> geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapStorageJUnitTest.java d5db4e4cb86912a89bca07642e5cc6ca94e9fb6f
> geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapStoredObjectAddressStackJUnitTest.java 8040bf7eaa1ac03b1df27ebf9c28e42d49691175
> geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapStoredObjectJUnitTest.java 2f6b32c72917174390ddccdd4e44e37e4f9e2ff3
> geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/SimpleMemoryAllocatorJUnitTest.java cc791fcc8f1311d62b135b82005cd36ae5e54afa
>
> Diff: https://reviews.apache.org/r/44812/diff/
>
>
> Testing
> -------
>
> precheckin
>
>
> Thanks,
>
> Darrel Schneider
>
>