[GitHub] [incubator-superset] etr2460 edited a comment on pull request #10061: fix: caching on viz with relative time ranges and time compare

[GitBox <gi...@apache.org>]

etr2460 edited a comment on pull request #10061:
URL: https://github.com/apache/incubator-superset/pull/10061#issuecomment-644562966


   @villebro i think we need to keep `inner_from_dttm` and `inner_to_dttm` around, as shortly after setting them, we mutate the original `from_dttm` and `to_dttm` attributes on the query object.
   https://github.com/apache/incubator-superset/blob/280ade826c038d7e1172e3291e9dc14ebbce0dc2/superset/viz.py#L1259-L1260
   
   I assume there's some reason why we need to keep the original params around, and that's why they're referenced throughout the models


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org