[GitHub] [guacamole-server] Saiyeux commented on a diff in pull request #402: GUACAMOLE-1586: Wrapped lines now clipped into 1.

[GitBox <gi...@apache.org>]

Saiyeux commented on code in PR #402:
URL: https://github.com/apache/guacamole-server/pull/402#discussion_r1029941197


##########
src/terminal/select.c:
##########
@@ -360,16 +360,19 @@ void guac_terminal_select_end(guac_terminal* terminal) {
     else {
 
         /* Store first row */
-        guac_terminal_clipboard_append_row(terminal, start_row, start_col, -1);
+        guac_terminal_buffer_row* buffer_row = guac_terminal_buffer_get_row(terminal->buffer, start_row, 0);
+        guac_terminal_clipboard_append_row(terminal, start_row, start_col, buffer_row->length - 2);

Review Comment:
   My purpose it to omit the line break when an extra long line of text is separated because of insufficient length of the terminal simulator. I managed to use buffer_row->length - 1 with server version 1.3.0, but have to cut down another character with 1.4.0. Currently, the horizontal index of bound is length - 2, I'll figure it out with annotations in next commit. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org