[GitHub] [hbase] sunhelly commented on pull request #4732: HBASE-27333 The condition for using the local hostname is the opposite

[GitBox <gi...@apache.org>]

sunhelly commented on PR #4732:
URL: https://github.com/apache/hbase/pull/4732#issuecomment-1235307296

   Thank, @Apache9 . The problem here is that the condition for whether using the servername seen from master or seen from local regionserver when they are different is opposite. It' a problem since branch-1. After line #1347 in HRegionServer, the servername of the regionserver is set to the name seen from master. But if when `StringUtils.isBlank(useThisHostnameInstead) && !hostnameFromMasterPOV.equals(rpcServices.getSocketAddress().getHostName()`, it means the regionserver should abort(by throwing exception here) and not using the name seen from master. 
   
   In short, when the hostname seen from local regionserver and master is different, the current behavior from the code should either restart the regionserver or use the local configed hostname, never the hostname seen from master. Correct me if I missed something. Thanks. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org