(maka) branch main updated: fix(desktop): preserve side chat composer elevation (#3263)

[as...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

Astro-Han pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/maka.git


The following commit(s) were added to refs/heads/main by this push:
     new f8be426ba fix(desktop): preserve side chat composer elevation (#3263)
f8be426ba is described below

commit f8be426ba81bc2f62e9cf0e08bac85f576cc9261
Author: yum <ya...@chihum.dev>
AuthorDate: Thu Aug 20 09:10:54 2026 +0800

    fix(desktop): preserve side chat composer elevation (#3263)
    
    The right-side Side Chat composer clipped the elevation painted by Astryx's
    inner ChatComposer body, leaving the white composer visually unbounded against
    the white workbar surface.
    
    This change removes the side-only wrapper clipping and redundant wrapper radius
    while preserving the compact Side Chat radius token. It also adds an Electron
    E2E assertion for the overflow contract that keeps the inner elevation visible.
    
    Generated-by: Codex
---
 apps/desktop/e2e/session-workbar.spec.ts              | 2 ++
 apps/desktop/src/renderer/styles/quote-side-panel.css | 5 ++---
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/apps/desktop/e2e/session-workbar.spec.ts b/apps/desktop/e2e/session-workbar.spec.ts
index 6287ba925..974f0377d 100644
--- a/apps/desktop/e2e/session-workbar.spec.ts
+++ b/apps/desktop/e2e/session-workbar.spec.ts
@@ -68,6 +68,8 @@ test('narrow right workbar keeps launcher shortcuts and side-chat send button in
   await setRightWorkbarWidth(page, 320);
 
   const composerCard = companion.locator('.maka-composer-astryx');
+  // Keep ChatComposer's inner elevation visible.
+  await expect(composerCard).toHaveCSS('overflow', 'visible');
   // Match the long model-label pressure from the reported side-chat screenshot
   // without coupling the fixture's globally useful default model to this test.
   await companion.locator('.maka-composer-model-chip-text').evaluate((element) => {
diff --git a/apps/desktop/src/renderer/styles/quote-side-panel.css b/apps/desktop/src/renderer/styles/quote-side-panel.css
index d184ab3ed..e79dcc2be 100644
--- a/apps/desktop/src/renderer/styles/quote-side-panel.css
+++ b/apps/desktop/src/renderer/styles/quote-side-panel.css
@@ -83,9 +83,8 @@
   .maka-composer-astryx {
   --_chat-composer-radius: var(--radius-surface);
 
-  overflow: hidden;
-  border-radius: var(--radius-surface);
-  /* Leave elevation to ChatComposer; product shadow overrode hover/focus lift. */
+  /* Let ChatComposer paint its own radius and elevation. Clipping this wrapper
+     hides the body's hover/focus shadow against the white side panel. */
 }
 
 .maka-session-workbar-panel[data-placement="right"]


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org