You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@beehive.apache.org by "Carlin Rogers (JIRA)" <de...@beehive.apache.org> on 2006/01/08 18:36:21 UTC

[jira] Created: (BEEHIVE-1035) Should fix possible NPE in PageFlowUtils.getModulePathForRelativeURI()

Should fix possible NPE in PageFlowUtils.getModulePathForRelativeURI()
----------------------------------------------------------------------

         Key: BEEHIVE-1035
         URL: http://issues.apache.org/jira/browse/BEEHIVE-1035
     Project: Beehive
        Type: Bug
  Components: NetUI  
    Versions: 1.1    
    Reporter: Carlin Rogers
 Assigned to: Carlin Rogers 
    Priority: Trivial
     Fix For: 1.1


PageFlowUtils.getModulePathForRelativeURI() will throw an NPE if the uri argument is null.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[jira] Assigned: (BEEHIVE-1035) Should fix possible NPE in PageFlowUtils.getModulePathForRelativeURI()

Posted by "Julie Zhuo (JIRA)" <de...@beehive.apache.org>.
     [ http://issues.apache.org/jira/browse/BEEHIVE-1035?page=all ]

Julie Zhuo reassigned BEEHIVE-1035:
-----------------------------------

    Assign To: Carlin Rogers  (was: Krista Baker)

Carlin, I have checked the PageFlowUtils BVT test. It looks fine to me. Just wondering whether you want to comment on Rich's comment after your check in. I see it returns null when the argument is null. Let me know your thoughts on this and please assign it back to me for closure. Thanks.

Julie

> Should fix possible NPE in PageFlowUtils.getModulePathForRelativeURI()
> ----------------------------------------------------------------------
>
>          Key: BEEHIVE-1035
>          URL: http://issues.apache.org/jira/browse/BEEHIVE-1035
>      Project: Beehive
>         Type: Bug
>   Components: NetUI
>     Versions: 1.0.1
>     Reporter: Carlin Rogers
>     Assignee: Carlin Rogers
>     Priority: Trivial
>      Fix For: 1.0.1

>
> PageFlowUtils.getModulePathForRelativeURI() will throw an NPE if the uri argument is null.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[jira] Commented: (BEEHIVE-1035) Should fix possible NPE in PageFlowUtils.getModulePathForRelativeURI()

Posted by "Rich Feit (JIRA)" <de...@beehive.apache.org>.
    [ http://issues.apache.org/jira/browse/BEEHIVE-1035?page=comments#action_12362177 ] 

Rich Feit commented on BEEHIVE-1035:
------------------------------------

Just saw this checkin -- sorry I didn't comment sooner.  Do you think it would be OK to assert that the argument isn't null?  Not a big deal at all -- just wondering.

> Should fix possible NPE in PageFlowUtils.getModulePathForRelativeURI()
> ----------------------------------------------------------------------
>
>          Key: BEEHIVE-1035
>          URL: http://issues.apache.org/jira/browse/BEEHIVE-1035
>      Project: Beehive
>         Type: Bug
>   Components: NetUI
>     Versions: 1.1
>     Reporter: Carlin Rogers
>     Assignee: Krista Baker
>     Priority: Trivial
>      Fix For: 1.1

>
> PageFlowUtils.getModulePathForRelativeURI() will throw an NPE if the uri argument is null.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[jira] Closed: (BEEHIVE-1035) Should fix possible NPE in PageFlowUtils.getModulePathForRelativeURI()

Posted by "Julie Zhuo (JIRA)" <de...@beehive.apache.org>.
     [ http://issues.apache.org/jira/browse/BEEHIVE-1035?page=all ]
     
Julie Zhuo closed BEEHIVE-1035:
-------------------------------


Thanks Carlin for your comments. It seems to me sufficient enough for now, so I am closing it here.

> Should fix possible NPE in PageFlowUtils.getModulePathForRelativeURI()
> ----------------------------------------------------------------------
>
>          Key: BEEHIVE-1035
>          URL: http://issues.apache.org/jira/browse/BEEHIVE-1035
>      Project: Beehive
>         Type: Bug
>   Components: NetUI
>     Versions: 1.0.1
>     Reporter: Carlin Rogers
>     Assignee: Julie Zhuo
>     Priority: Trivial
>      Fix For: 1.0.1

>
> PageFlowUtils.getModulePathForRelativeURI() will throw an NPE if the uri argument is null.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[jira] Updated: (BEEHIVE-1035) Should fix possible NPE in PageFlowUtils.getModulePathForRelativeURI()

Posted by "Carlin Rogers (JIRA)" <de...@beehive.apache.org>.
     [ http://issues.apache.org/jira/browse/BEEHIVE-1035?page=all ]

Carlin Rogers updated BEEHIVE-1035:
-----------------------------------

    Assign To: Julie Zhuo  (was: Carlin Rogers)

Julie, Rich, sorry I didn't comment earlier. This was actually driven by Krista and a scenario/test she had contacted me about. The assert could go along with or replace the change I made but I think she felt that in the runtime environment, without asserts turned on, it was best not to have any NPE. I know this method and the other  PageFlowUtils methods that call this one should not be calling this with  null uri and an assert should suffice. If anyone feels strongly I can change it later. For now I'll go with the original request.

> Should fix possible NPE in PageFlowUtils.getModulePathForRelativeURI()
> ----------------------------------------------------------------------
>
>          Key: BEEHIVE-1035
>          URL: http://issues.apache.org/jira/browse/BEEHIVE-1035
>      Project: Beehive
>         Type: Bug
>   Components: NetUI
>     Versions: 1.0.1
>     Reporter: Carlin Rogers
>     Assignee: Julie Zhuo
>     Priority: Trivial
>      Fix For: 1.0.1

>
> PageFlowUtils.getModulePathForRelativeURI() will throw an NPE if the uri argument is null.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[jira] Resolved: (BEEHIVE-1035) Should fix possible NPE in PageFlowUtils.getModulePathForRelativeURI()

Posted by "Carlin Rogers (JIRA)" <de...@beehive.apache.org>.
     [ http://issues.apache.org/jira/browse/BEEHIVE-1035?page=all ]
     
Carlin Rogers resolved BEEHIVE-1035:
------------------------------------

    Resolution: Fixed
     Assign To: Krista Baker  (was: Carlin Rogers)

This is fixed with revision 367062. The revision also includes an update to the PageFlowUtils test case to cover this condition.

> Should fix possible NPE in PageFlowUtils.getModulePathForRelativeURI()
> ----------------------------------------------------------------------
>
>          Key: BEEHIVE-1035
>          URL: http://issues.apache.org/jira/browse/BEEHIVE-1035
>      Project: Beehive
>         Type: Bug
>   Components: NetUI
>     Versions: 1.1
>     Reporter: Carlin Rogers
>     Assignee: Krista Baker
>     Priority: Trivial
>      Fix For: 1.1

>
> PageFlowUtils.getModulePathForRelativeURI() will throw an NPE if the uri argument is null.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira