You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/08/11 04:21:21 UTC

[GitHub] [druid] FrankChen021 edited a comment on pull request #11456: Overlord limit for returned tasks by count

FrankChen021 edited a comment on pull request #11456:
URL: https://github.com/apache/druid/pull/11456#issuecomment-896488808


   @egor-ryashin Thanks for opening this PR. If I understand correctly, this PR tries to addresses  #11042, #11140 and #11567.
   
   There was a discussion about this problem, and I left [some comments](https://lists.apache.org/thread.html/rc659b7c681499911fb6eff46b9edb5a3d983c11d0c253909afc905b1%40%3Cdev.druid.apache.org%3E) on the dev mailing thread.
   
   One problem is that LIMIT/OFFSET is not used by the WebUI to limit the task count returned by the server. But the core problem I think is that the overlord retrieves all task records from the metadata storage to the SQL layer, the performance bottleneck might be here. So I guess limiting the task count might be less help as we expect.
   
   But if want to limit the count at the SQL layer to make a try, I think it's better to do it at the WebUI side by using LIMIT/OFFSET clause instead of introducing a new configuration at the server side.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org