[GitHub] [camel-k] squakez commented on a diff in pull request #3901: fix(#3896): Fix dependency inspector supporting property placeholders

[GitBox <gi...@apache.org>]

squakez commented on code in PR #3901:
URL: https://github.com/apache/camel-k/pull/3901#discussion_r1048406955


##########
pkg/util/source/inspector.go:
##########
@@ -336,6 +336,11 @@ func (i *baseInspector) discoverKamelets(meta *Metadata) {
 }
 
 func (i *baseInspector) addDependencies(uri string, meta *Metadata, consumer bool) error {
+	if !strings.Contains(uri, ":") {

Review Comment:
   Not sure if this statement is okey to be here. I mean, in theory we may expect an uri with the form `mycomponent`, without the scheme. I wonder if it makes sense: 1) to check for the specific use case (`{{}}`) directly in the `DecodeComponent()` func, 2) if it makes sense to have the check in the callers of `addDependencies()` func.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org