You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "slfan1989 (via GitHub)" <gi...@apache.org> on 2023/03/20 04:43:08 UTC
[GitHub] [hudi] slfan1989 opened a new pull request, #8237: HUDI-5958. Improve ResolvedSchema Instead of TableSchema.
slfan1989 opened a new pull request, #8237:
URL: https://github.com/apache/hudi/pull/8237
### Change Logs
JIRA:HUDI-5958. Improve ResolvedSchema Instead of TableSchema.
When reading the code, I found that there is a case of using TableSchema in the flink-example project, TableSchema has been Deprecated, We can use resolvedSchema instead.
### Impact
none.
### Risk level (write none, low medium or high below)
none.
### Documentation Update
none.
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8237: [HUDI-5958] Improve ResolvedSchema Instead of TableSchema.
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8237:
URL: https://github.com/apache/hudi/pull/8237#issuecomment-1478345411
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aeb7a0a30302f0a0bbea71c0260d62631bbda49f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15799",
"triggerID" : "aeb7a0a30302f0a0bbea71c0260d62631bbda49f",
"triggerType" : "PUSH"
}, {
"hash" : "d3ce6b5a9b0633f286acc9cdc4718eaac88c129f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15832",
"triggerID" : "d3ce6b5a9b0633f286acc9cdc4718eaac88c129f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d3ce6b5a9b0633f286acc9cdc4718eaac88c129f Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15832)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8237: [HUDI-5958] Improve ResolvedSchema Instead of TableSchema.
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8237:
URL: https://github.com/apache/hudi/pull/8237#issuecomment-1475620457
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aeb7a0a30302f0a0bbea71c0260d62631bbda49f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "aeb7a0a30302f0a0bbea71c0260d62631bbda49f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* aeb7a0a30302f0a0bbea71c0260d62631bbda49f UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8237: [HUDI-5958] Improve ResolvedSchema Instead of TableSchema.
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8237:
URL: https://github.com/apache/hudi/pull/8237#issuecomment-1478976159
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aeb7a0a30302f0a0bbea71c0260d62631bbda49f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15799",
"triggerID" : "aeb7a0a30302f0a0bbea71c0260d62631bbda49f",
"triggerType" : "PUSH"
}, {
"hash" : "d3ce6b5a9b0633f286acc9cdc4718eaac88c129f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15832",
"triggerID" : "d3ce6b5a9b0633f286acc9cdc4718eaac88c129f",
"triggerType" : "PUSH"
}, {
"hash" : "1bb5abf6097e97ad548257e9a918a7cf86009243",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1bb5abf6097e97ad548257e9a918a7cf86009243",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d3ce6b5a9b0633f286acc9cdc4718eaac88c129f Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15832)
* 1bb5abf6097e97ad548257e9a918a7cf86009243 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] slfan1989 commented on pull request #8237: [HUDI-5958] Improve ResolvedSchema Instead of TableSchema.
Posted by "slfan1989 (via GitHub)" <gi...@apache.org>.
slfan1989 commented on PR #8237:
URL: https://github.com/apache/hudi/pull/8237#issuecomment-1479349949
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8237: [HUDI-5958] Improve ResolvedSchema Instead of TableSchema.
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8237:
URL: https://github.com/apache/hudi/pull/8237#issuecomment-1479932230
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aeb7a0a30302f0a0bbea71c0260d62631bbda49f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15799",
"triggerID" : "aeb7a0a30302f0a0bbea71c0260d62631bbda49f",
"triggerType" : "PUSH"
}, {
"hash" : "d3ce6b5a9b0633f286acc9cdc4718eaac88c129f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15832",
"triggerID" : "d3ce6b5a9b0633f286acc9cdc4718eaac88c129f",
"triggerType" : "PUSH"
}, {
"hash" : "1bb5abf6097e97ad548257e9a918a7cf86009243",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15843",
"triggerID" : "1bb5abf6097e97ad548257e9a918a7cf86009243",
"triggerType" : "PUSH"
}, {
"hash" : "1bb5abf6097e97ad548257e9a918a7cf86009243",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15852",
"triggerID" : "1479349949",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 1bb5abf6097e97ad548257e9a918a7cf86009243 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15843) Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15852)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8237: [HUDI-5958] Improve ResolvedSchema Instead of TableSchema.
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8237:
URL: https://github.com/apache/hudi/pull/8237#issuecomment-1477912164
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aeb7a0a30302f0a0bbea71c0260d62631bbda49f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15799",
"triggerID" : "aeb7a0a30302f0a0bbea71c0260d62631bbda49f",
"triggerType" : "PUSH"
}, {
"hash" : "d3ce6b5a9b0633f286acc9cdc4718eaac88c129f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15832",
"triggerID" : "d3ce6b5a9b0633f286acc9cdc4718eaac88c129f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* aeb7a0a30302f0a0bbea71c0260d62631bbda49f Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15799)
* d3ce6b5a9b0633f286acc9cdc4718eaac88c129f Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15832)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8237: [HUDI-5958] Improve ResolvedSchema Instead of TableSchema.
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8237:
URL: https://github.com/apache/hudi/pull/8237#issuecomment-1479148575
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aeb7a0a30302f0a0bbea71c0260d62631bbda49f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15799",
"triggerID" : "aeb7a0a30302f0a0bbea71c0260d62631bbda49f",
"triggerType" : "PUSH"
}, {
"hash" : "d3ce6b5a9b0633f286acc9cdc4718eaac88c129f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15832",
"triggerID" : "d3ce6b5a9b0633f286acc9cdc4718eaac88c129f",
"triggerType" : "PUSH"
}, {
"hash" : "1bb5abf6097e97ad548257e9a918a7cf86009243",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15843",
"triggerID" : "1bb5abf6097e97ad548257e9a918a7cf86009243",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1bb5abf6097e97ad548257e9a918a7cf86009243 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15843)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8237: [HUDI-5958] Improve ResolvedSchema Instead of TableSchema.
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8237:
URL: https://github.com/apache/hudi/pull/8237#issuecomment-1479358972
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aeb7a0a30302f0a0bbea71c0260d62631bbda49f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15799",
"triggerID" : "aeb7a0a30302f0a0bbea71c0260d62631bbda49f",
"triggerType" : "PUSH"
}, {
"hash" : "d3ce6b5a9b0633f286acc9cdc4718eaac88c129f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15832",
"triggerID" : "d3ce6b5a9b0633f286acc9cdc4718eaac88c129f",
"triggerType" : "PUSH"
}, {
"hash" : "1bb5abf6097e97ad548257e9a918a7cf86009243",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15843",
"triggerID" : "1bb5abf6097e97ad548257e9a918a7cf86009243",
"triggerType" : "PUSH"
}, {
"hash" : "1bb5abf6097e97ad548257e9a918a7cf86009243",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15852",
"triggerID" : "1479349949",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 1bb5abf6097e97ad548257e9a918a7cf86009243 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15843) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15852)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8237: [HUDI-5958] Improve ResolvedSchema Instead of TableSchema.
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8237:
URL: https://github.com/apache/hudi/pull/8237#issuecomment-1479010965
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aeb7a0a30302f0a0bbea71c0260d62631bbda49f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15799",
"triggerID" : "aeb7a0a30302f0a0bbea71c0260d62631bbda49f",
"triggerType" : "PUSH"
}, {
"hash" : "d3ce6b5a9b0633f286acc9cdc4718eaac88c129f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15832",
"triggerID" : "d3ce6b5a9b0633f286acc9cdc4718eaac88c129f",
"triggerType" : "PUSH"
}, {
"hash" : "1bb5abf6097e97ad548257e9a918a7cf86009243",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15843",
"triggerID" : "1bb5abf6097e97ad548257e9a918a7cf86009243",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d3ce6b5a9b0633f286acc9cdc4718eaac88c129f Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15832)
* 1bb5abf6097e97ad548257e9a918a7cf86009243 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15843)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 merged pull request #8237: [HUDI-5958] Replace deprecated TableSchema with ResolvedSchema
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 merged PR #8237:
URL: https://github.com/apache/hudi/pull/8237
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] slfan1989 commented on a diff in pull request #8237: [HUDI-5958] Improve ResolvedSchema Instead of TableSchema.
Posted by "slfan1989 (via GitHub)" <gi...@apache.org>.
slfan1989 commented on code in PR #8237:
URL: https://github.com/apache/hudi/pull/8237#discussion_r1145598646
##########
hudi-examples/hudi-examples-flink/src/main/java/org/apache/hudi/examples/quickstart/factory/CollectSinkTableFactory.java:
##########
@@ -91,11 +91,11 @@ public Set<ConfigOption<?>> optionalOptions() {
*/
private static class CollectTableSink implements DynamicTableSink {
- private final TableSchema schema;
+ private final ResolvedSchema schema;
private final String tableName;
private CollectTableSink(
- TableSchema schema,
+ ResolvedSchema schema,
String tableName) {
Review Comment:
Thanks for your suggestion, I will modify the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] slfan1989 commented on pull request #8237: [HUDI-5958] Replace deprecated TableSchema with ResolvedSchema
Posted by "slfan1989 (via GitHub)" <gi...@apache.org>.
slfan1989 commented on PR #8237:
URL: https://github.com/apache/hudi/pull/8237#issuecomment-1480719486
@danny0405 Thank you very much for your help in reviewing the code!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] slfan1989 commented on pull request #8237: [HUDI-5958] Improve ResolvedSchema Instead of TableSchema.
Posted by "slfan1989 (via GitHub)" <gi...@apache.org>.
slfan1989 commented on PR #8237:
URL: https://github.com/apache/hudi/pull/8237#issuecomment-1476040017
@danny0405 Can you help review this pr? Thank you very much!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8237: [HUDI-5958] Improve ResolvedSchema Instead of TableSchema.
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8237:
URL: https://github.com/apache/hudi/pull/8237#issuecomment-1477896321
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aeb7a0a30302f0a0bbea71c0260d62631bbda49f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15799",
"triggerID" : "aeb7a0a30302f0a0bbea71c0260d62631bbda49f",
"triggerType" : "PUSH"
}, {
"hash" : "d3ce6b5a9b0633f286acc9cdc4718eaac88c129f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d3ce6b5a9b0633f286acc9cdc4718eaac88c129f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* aeb7a0a30302f0a0bbea71c0260d62631bbda49f Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15799)
* d3ce6b5a9b0633f286acc9cdc4718eaac88c129f UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8237: [HUDI-5958] Improve ResolvedSchema Instead of TableSchema.
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8237:
URL: https://github.com/apache/hudi/pull/8237#issuecomment-1475627791
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aeb7a0a30302f0a0bbea71c0260d62631bbda49f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15799",
"triggerID" : "aeb7a0a30302f0a0bbea71c0260d62631bbda49f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* aeb7a0a30302f0a0bbea71c0260d62631bbda49f Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15799)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8237: [HUDI-5958] Improve ResolvedSchema Instead of TableSchema.
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8237:
URL: https://github.com/apache/hudi/pull/8237#issuecomment-1475917008
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aeb7a0a30302f0a0bbea71c0260d62631bbda49f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15799",
"triggerID" : "aeb7a0a30302f0a0bbea71c0260d62631bbda49f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* aeb7a0a30302f0a0bbea71c0260d62631bbda49f Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15799)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #8237: [HUDI-5958] Improve ResolvedSchema Instead of TableSchema.
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #8237:
URL: https://github.com/apache/hudi/pull/8237#discussion_r1142960326
##########
hudi-examples/hudi-examples-flink/src/main/java/org/apache/hudi/examples/quickstart/factory/CollectSinkTableFactory.java:
##########
@@ -91,11 +91,11 @@ public Set<ConfigOption<?>> optionalOptions() {
*/
private static class CollectTableSink implements DynamicTableSink {
- private final TableSchema schema;
+ private final ResolvedSchema schema;
private final String tableName;
private CollectTableSink(
- TableSchema schema,
+ ResolvedSchema schema,
String tableName) {
Review Comment:
Can we fix all the indentations?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org