You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by gczsjdy <gi...@git.apache.org> on 2017/12/04 08:27:08 UTC

[GitHub] spark pull request #19862: [WIP][SPARK-22671][SQL] Make SortMergeJoin shuffl...

Github user gczsjdy commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19862#discussion_r154581844
  
    --- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/execution/UnsafeExternalRowSorter.java ---
    @@ -159,6 +154,12 @@ public boolean hasNext() {
             @Override
             public UnsafeRow next() {
               try {
    +            if (!alreadyCalculated) {
    --- End diff --
    
    Yes. There are mistakes here, I will change.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org