You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@servicecomb.apache.org by GitBox <gi...@apache.org> on 2018/01/09 03:37:58 UTC

[GitHub] wujimin commented on a change in pull request #460: [SCB-171] report type/version when register to SC

wujimin commented on a change in pull request #460: [SCB-171] report type/version when register to SC
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/460#discussion_r160313078
 
 

 ##########
 File path: foundations/foundation-common/src/main/java/io/servicecomb/foundation/common/base/ServiceCombConstants.java
 ##########
 @@ -50,4 +50,11 @@
   String CONFIG_CSE_PREFIX = "cse.";
 
   String CONFIG_KEY_SPLITER = "_";
+
+  String CONFIG_FRAMEWORK_DEFAULT_NAME = "servicecomb-java-chassis";
+
+  String CONFIG_FRAMEWORK_DEFAULT_VERSION = "1.0";
 
 Review comment:
   fake "1.0" is not good

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services