You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "martinzink (via GitHub)" <gi...@apache.org> on 2024/10/25 08:36:03 UTC
[PR] MINIFICPP-2477 Valgrind CI [nifi-minifi-cpp]
martinzink opened a new pull request, #1886:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1886
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically main)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINIFICPP-2477 Valgrind CI [nifi-minifi-cpp]
Posted by "martinzink (via GitHub)" <gi...@apache.org>.
martinzink commented on code in PR #1886:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1886#discussion_r1820320213
##########
CMakeLists.txt:
##########
@@ -670,6 +670,10 @@ include(CPack)
### include modules
if (NOT SKIP_TESTS)
+ enable_testing()
+ set(BUILD_TESTING ON)
+ set(CTEST_NEW_FORMAT true)
Review Comment:
it affects the name of the ctest configuraiton file it will be `CTestConfiguration.ini` instead of `DartConfiguration.tcl` (lagacy name that isnt clear about what it is for)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINIFICPP-2477 Valgrind CI [nifi-minifi-cpp]
Posted by "martinzink (via GitHub)" <gi...@apache.org>.
martinzink commented on code in PR #1886:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1886#discussion_r1820321028
##########
extensions/aws/tests/CMakeLists.txt:
##########
@@ -35,5 +35,6 @@ FOREACH(testfile ${AWS_INTEGRATION_TESTS})
target_link_libraries(${testfilename} minifi-expression-language-extensions)
MATH(EXPR AWS_TEST_COUNT "${AWS_TEST_COUNT}+1")
add_test(NAME "${testfilename}" COMMAND "${testfilename}" WORKING_DIRECTORY ${TEST_DIR})
+ set_tests_properties("${testfilename}" PROPERTIES LABELS "aws")
Review Comment:
Same here, there was a strange (one-time and small) leak directly from aws sdk, we should investigate further later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINIFICPP-2477 Valgrind CI [nifi-minifi-cpp]
Posted by "szaszm (via GitHub)" <gi...@apache.org>.
szaszm commented on code in PR #1886:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1886#discussion_r1819016181
##########
CMakeLists.txt:
##########
@@ -670,6 +670,10 @@ include(CPack)
### include modules
if (NOT SKIP_TESTS)
+ enable_testing()
+ set(BUILD_TESTING ON)
+ set(CTEST_NEW_FORMAT true)
Review Comment:
what is CTEST_NEW_FORMAT?
##########
extensions/civetweb/tests/CMakeLists.txt:
##########
@@ -40,5 +40,6 @@ FOREACH(testfile ${CIVETWEB_INTEGRATION_TESTS})
"${CMAKE_SOURCE_DIR}/extensions/civetweb/tests/resources"
"$<TARGET_FILE_DIR:${testfilename}>/resources"
)
+ set_tests_properties("${testfilename}" PROPERTIES LABELS "civetweb")
Review Comment:
why no memchecked here?
##########
extensions/aws/tests/CMakeLists.txt:
##########
@@ -35,5 +35,6 @@ FOREACH(testfile ${AWS_INTEGRATION_TESTS})
target_link_libraries(${testfilename} minifi-expression-language-extensions)
MATH(EXPR AWS_TEST_COUNT "${AWS_TEST_COUNT}+1")
add_test(NAME "${testfilename}" COMMAND "${testfilename}" WORKING_DIRECTORY ${TEST_DIR})
+ set_tests_properties("${testfilename}" PROPERTIES LABELS "aws")
Review Comment:
and here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINIFICPP-2477 Valgrind CI [nifi-minifi-cpp]
Posted by "martinzink (via GitHub)" <gi...@apache.org>.
martinzink commented on code in PR #1886:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1886#discussion_r1820318116
##########
extensions/civetweb/tests/CMakeLists.txt:
##########
@@ -40,5 +40,6 @@ FOREACH(testfile ${CIVETWEB_INTEGRATION_TESTS})
"${CMAKE_SOURCE_DIR}/extensions/civetweb/tests/resources"
"$<TARGET_FILE_DIR:${testfilename}>/resources"
)
+ set_tests_properties("${testfilename}" PROPERTIES LABELS "civetweb")
Review Comment:
I should have clarified I didnt fix every leak so I've only added the memcheck for those unit tests that are leak free, any new code should be leak free and I'll create a Jira to address these tests in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINIFICPP-2477 Valgrind CI [nifi-minifi-cpp]
Posted by "martinzink (via GitHub)" <gi...@apache.org>.
martinzink commented on code in PR #1886:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1886#discussion_r1820321028
##########
extensions/aws/tests/CMakeLists.txt:
##########
@@ -35,5 +35,6 @@ FOREACH(testfile ${AWS_INTEGRATION_TESTS})
target_link_libraries(${testfilename} minifi-expression-language-extensions)
MATH(EXPR AWS_TEST_COUNT "${AWS_TEST_COUNT}+1")
add_test(NAME "${testfilename}" COMMAND "${testfilename}" WORKING_DIRECTORY ${TEST_DIR})
+ set_tests_properties("${testfilename}" PROPERTIES LABELS "aws")
Review Comment:
Same here, there was a strange leak directly from aws sdk, we should investigate further later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINIFICPP-2477 Valgrind CI [nifi-minifi-cpp]
Posted by "fgerlits (via GitHub)" <gi...@apache.org>.
fgerlits closed pull request #1886: MINIFICPP-2477 Valgrind CI
URL: https://github.com/apache/nifi-minifi-cpp/pull/1886
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org