You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@beehive.apache.org by "Carlin Rogers (JIRA)" <de...@beehive.apache.org> on 2005/09/16 23:10:54 UTC
[jira] Created: (BEEHIVE-937) Add validation to the beehive-url-template-config.xml file processing
Add validation to the beehive-url-template-config.xml file processing
---------------------------------------------------------------------
Key: BEEHIVE-937
URL: http://issues.apache.org/jira/browse/BEEHIVE-937
Project: Beehive
Type: Bug
Components: NetUI
Versions: V1
Reporter: Carlin Rogers
Assigned to: Carlin Rogers
Fix For: V1
The DefaultURLTemplatesFactory class that parses the beehive-url-template-config.xml file should probably also validate the XML file against the schema, url-template-config.xsd. If we do decide to include this change, it should go in for V1, otherwise there's a compat issue where we might break apps if we turn it on later.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (BEEHIVE-937) Add validation to the beehive-url-template-config.xml file processing
Posted by "Carlin Rogers (JIRA)" <de...@beehive.apache.org>.
[ http://issues.apache.org/jira/browse/BEEHIVE-937?page=all ]
Carlin Rogers reassigned BEEHIVE-937:
-------------------------------------
Assign To: Eddie O'Neil (was: Carlin Rogers)
Assigning to Eddie for review. Eddie, you can pass this to Rich if you'd prefer but thought you were most familiar with the use of the SchemaValidator. Also, the patch contains a small tweak to NetUIConfigParser to close a stream that looked like was left open. It gets closed after the validation but not after the separate parsing pass. Thanks.
> Add validation to the beehive-url-template-config.xml file processing
> ---------------------------------------------------------------------
>
> Key: BEEHIVE-937
> URL: http://issues.apache.org/jira/browse/BEEHIVE-937
> Project: Beehive
> Type: Bug
> Components: NetUI
> Versions: V1
> Reporter: Carlin Rogers
> Assignee: Eddie O'Neil
> Fix For: V1
> Attachments: j937-patch.txt
>
> The DefaultURLTemplatesFactory class that parses the beehive-url-template-config.xml file should probably also validate the XML file against the schema, url-template-config.xsd. If we do decide to include this change, it should go in for V1, otherwise there's a compat issue where we might break apps if we turn it on later.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Resolved: (BEEHIVE-937) Add validation to the beehive-url-template-config.xml file processing
Posted by "Eddie O'Neil (JIRA)" <de...@beehive.apache.org>.
[ http://issues.apache.org/jira/browse/BEEHIVE-937?page=all ]
Eddie O'Neil resolved BEEHIVE-937:
----------------------------------
Resolution: Fixed
Nice, Carlin. I went ahead and applied this patch -- we can always provide a flag to disable validation if there's enough outcry for it, but I tend to like having validation on from the beginning since you can never enable it by default after that. :)
Patch applied in SVN 290172.
> Add validation to the beehive-url-template-config.xml file processing
> ---------------------------------------------------------------------
>
> Key: BEEHIVE-937
> URL: http://issues.apache.org/jira/browse/BEEHIVE-937
> Project: Beehive
> Type: Bug
> Components: NetUI
> Versions: V1
> Reporter: Carlin Rogers
> Assignee: Eddie O'Neil
> Fix For: V1
> Attachments: j937-patch.txt
>
> The DefaultURLTemplatesFactory class that parses the beehive-url-template-config.xml file should probably also validate the XML file against the schema, url-template-config.xsd. If we do decide to include this change, it should go in for V1, otherwise there's a compat issue where we might break apps if we turn it on later.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (BEEHIVE-937) Add validation to the beehive-url-template-config.xml file processing
Posted by "Eddie O'Neil (JIRA)" <de...@beehive.apache.org>.
[ http://issues.apache.org/jira/browse/BEEHIVE-937?page=all ]
Eddie O'Neil closed BEEHIVE-937:
--------------------------------
Patch has been committed. Closing.
> Add validation to the beehive-url-template-config.xml file processing
> ---------------------------------------------------------------------
>
> Key: BEEHIVE-937
> URL: http://issues.apache.org/jira/browse/BEEHIVE-937
> Project: Beehive
> Type: Bug
> Components: NetUI
> Versions: V1
> Reporter: Carlin Rogers
> Assignee: Eddie O'Neil
> Fix For: V1
> Attachments: j937-patch.txt
>
> The DefaultURLTemplatesFactory class that parses the beehive-url-template-config.xml file should probably also validate the XML file against the schema, url-template-config.xsd. If we do decide to include this change, it should go in for V1, otherwise there's a compat issue where we might break apps if we turn it on later.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (BEEHIVE-937) Add validation to the beehive-url-template-config.xml file processing
Posted by "Carlin Rogers (JIRA)" <de...@beehive.apache.org>.
[ http://issues.apache.org/jira/browse/BEEHIVE-937?page=all ]
Carlin Rogers updated BEEHIVE-937:
----------------------------------
Attachment: j937-patch.txt
Here's a patch that adds beehive-url-template-config.xml file validation to the DefaultURLTemplatesFactory class. The update uses the new SchemaValidator class.
> Add validation to the beehive-url-template-config.xml file processing
> ---------------------------------------------------------------------
>
> Key: BEEHIVE-937
> URL: http://issues.apache.org/jira/browse/BEEHIVE-937
> Project: Beehive
> Type: Bug
> Components: NetUI
> Versions: V1
> Reporter: Carlin Rogers
> Assignee: Carlin Rogers
> Fix For: V1
> Attachments: j937-patch.txt
>
> The DefaultURLTemplatesFactory class that parses the beehive-url-template-config.xml file should probably also validate the XML file against the schema, url-template-config.xsd. If we do decide to include this change, it should go in for V1, otherwise there's a compat issue where we might break apps if we turn it on later.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira