You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/03/04 20:21:13 UTC

[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #3476: NO-JIRA: GHA workflow improvements

clebertsuconic commented on a change in pull request #3476:
URL: https://github.com/apache/activemq-artemis/pull/3476#discussion_r587798568



##########
File path: .github/workflows/build.yml
##########
@@ -32,8 +32,15 @@ jobs:
       - name: Build Main
         run: |
           mvn -Dorg.apache.activemq.artemis.core.io.aio.AIOSequentialFileFactory.DISABLED=AnythingNotNull -Djdk8-errorprone -Pfast-tests -Pextra-tests -Ptests-CI -Pjmh install
-      - name: Build Examples
+
+      - name: Build Examples (JDK8 / -Prelease)
+        if: matrix.java == '8'

Review comment:
       @gemmellr before last release, I had to fix javadoc, however currently javadoc only builds on JDK 1.8
   
   I tried to do an if jdk=8 at the time but I did not know how to do it?
   
   Since you figured it out now, can we add after this line?
   
   ```mvn -Prelease javadoc:javadoc```
   
   
   WDYT?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org