You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@metron.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/01/24 17:33:00 UTC
[jira] [Commented] (METRON-1428) Travis build failing from
metron-config
[ https://issues.apache.org/jira/browse/METRON-1428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16337938#comment-16337938 ]
ASF GitHub Bot commented on METRON-1428:
----------------------------------------
GitHub user mmiklavc opened a pull request:
https://github.com/apache/metron/pull/908
1428: Travis build failing from metron-config
## Contributor Comments
https://issues.apache.org/jira/browse/METRON-1428
Travis is failing because of npm downstream package problems. The chain of dependencies went like this: karma-remap-istanbul ^0.2.1 -> remap-istanbul some version or another -> source-map ver 7.0.0. The problem came with an api change of sorts to source-map. remap-istanbul has made a patch version in 0.9.6 to fix the dependency, and in order to get the proper remap-istanbul version that limits the pool of source-map versions, I had to upgrade karma-remap-istanbul to 0.6.0. This fixed the chain of dependencies without seemingly breaking anything else along the way, thankfully.
I have to look at what we do with the UI libraries for licensing reporting, as I currently have no idea yet what that looks like, so I'll update that shortly. For now, I wanted to see if this gets the build working, at the very least.
## Pull Request Checklist
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
```
mvn -q clean integration-test install && build_utils/verify_licenses.sh
```
- [x] Have you written or updated unit tests and or integration tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mmiklavc/metron metron-config-lib-conflict
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/908.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #908
----
commit bc8dcc4eb5e1b5863c165be295647b2bcbbbd852
Author: Michael Miklavcic <mi...@...>
Date: 2018-01-24T17:17:30Z
Update karma-remap-istanbul to fix source-map downstream dependency problem
----
> Travis build failing from metron-config
> ---------------------------------------
>
> Key: METRON-1428
> URL: https://issues.apache.org/jira/browse/METRON-1428
> Project: Metron
> Issue Type: Bug
> Reporter: Michael Miklavcic
> Assignee: Michael Miklavcic
> Priority: Major
>
> The build is hiding logs in the metron-config failure and then hanging indefinitely. Running the build locally, ie
> {code:java}
> metron/metron-interface/metron-config$ mvn test{code}
> resulted in the following error:
> {code:java}
> [INFO] 24 01 2018 09:13:44.242:INFO [PhantomJS 2.1.1 (Mac OS X 0.0.0)]: Connected on socket /#2JMBj2Qu9STI0gMFAAAA with id 22733174
> PhantomJS 2.1.1 (Mac OS X 0.0.0): Executed 241 of 241 SUCCESS (1 min 38.478 secs / 1 min 37.477 secs)
> [INFO] Missing error handler on `socket`.
> [INFO] TypeError: sourceMap.originalPositionFor is not a function
> [INFO] at getMapping (/Users/mmiklavcic/devprojects/metron/metron-interface/metron-config/node_modules/remap-istanbul/lib/remap.js:76:25)
> [INFO] at /Users/mmiklavcic/devprojects/metron/metron-interface/metron-config/node_modules/remap-istanbul/lib/remap.js:245:20
> [INFO] at Array.forEach (native)
> [INFO] at /Users/mmiklavcic/devprojects/metron/metron-interface/metron-config/node_modules/remap-istanbul/lib/remap.js:243:37
> [INFO] at Array.forEach (native)
> [INFO] at /Users/mmiklavcic/devprojects/metron/metron-interface/metron-config/node_modules/remap-istanbul/lib/remap.js:192:22
> [INFO] at Array.forEach (native)
> [INFO] at remap (/Users/mmiklavcic/devprojects/metron/metron-interface/metron-config/node_modules/remap-istanbul/lib/remap.js:191:12)
> [INFO] at onRunComplete (/Users/mmiklavcic/devprojects/metron/metron-interface/metron-config/node_modules/karma-remap-istanbul/index.js:55:21)
> [INFO] at .<anonymous> (/Users/mmiklavcic/devprojects/metron/metron-interface/metron-config/node_modules/karma/lib/events.js:13:22)
> [INFO] at emitTwo (events.js:111:20)
> [INFO] at emit (events.js:191:7)
> [INFO] at emitRunCompleteIfAllBrowsersDone (/Users/mmiklavcic/devprojects/metron/metron-interface/metron-config/node_modules/karma/lib/server.js:294:12)
> [INFO] at .<anonymous> (/Users/mmiklavcic/devprojects/metron/metron-interface/metron-config/node_modules/karma/lib/server.js:325:7)
> [INFO] at emitOne (events.js:96:13)
> [INFO] at emit (events.js:188:7)
> [INFO] at .<anonymous> (/Users/mmiklavcic/devprojects/metron/metron-interface/metron-config/node_modules/karma/lib/server.js:308:12)
> [INFO] at emitTwo (events.js:111:20)
> [INFO] at emit (events.js:191:7)
> [INFO] at onComplete (/Users/mmiklavcic/devprojects/metron/metron-interface/metron-config/node_modules/karma/lib/browser.js:143:13)
> [INFO] at Socket.<anonymous> (/Users/mmiklavcic/devprojects/metron/metron-interface/metron-config/node_modules/karma/lib/events.js:13:22)
> [INFO] at emitTwo (events.js:111:20)
> [INFO] at Socket.emit (events.js:191:7)
> [INFO] at Socket.onevent (/Users/mmiklavcic/devprojects/metron/metron-interface/metron-config/node_modules/karma/node_modules/socket.io/lib/socket.js:335:8)
> [INFO] at Socket.onpacket (/Users/mmiklavcic/devprojects/metron/metron-interface/metron-config/node_modules/karma/node_modules/socket.io/lib/socket.js:295:12)
> [INFO] at Client.ondecoded (/Users/mmiklavcic/devprojects/metron/metron-interface/metron-config/node_modules/karma/node_modules/socket.io/lib/client.js:193:14)
> [INFO] at Decoder.Emitter.emit (/Users/mmiklavcic/devprojects/metron/metron-interface/metron-config/node_modules/component-emitter/index.js:134:20)
> [INFO] at Decoder.add (/Users/mmiklavcic/devprojects/metron/metron-interface/metron-config/node_modules/karma/node_modules/socket.io-parser/index.js:247:12)
> [INFO] at Client.ondata (/Users/mmiklavcic/devprojects/metron/metron-interface/metron-config/node_modules/karma/node_modules/socket.io/lib/client.js:175:18)
> [INFO] at emitOne (events.js:96:13)
> [INFO] at Socket.emit (events.js:188:7)
> [INFO] at Socket.onPacket (/Users/mmiklavcic/devprojects/metron/metron-interface/metron-config/node_modules/karma/node_modules/engine.io/lib/socket.js:101:14)
> [INFO] at emitOne (events.js:96:13)
> [INFO] at WebSocket.emit (events.js:188:7)
> [INFO] at WebSocket.Transport.onPacket (/Users/mmiklavcic/devprojects/metron/metron-interface/metron-config/node_modules/karma/node_modules/engine.io/lib/transport.js:104:8)
> [INFO] at WebSocket.Transport.onData (/Users/mmiklavcic/devprojects/metron/metron-interface/metron-config/node_modules/karma/node_modules/engine.io/lib/transport.js:115:8)
> [INFO] at WebSocket.onData (/Users/mmiklavcic/devprojects/metron/metron-interface/metron-config/node_modules/karma/node_modules/engine.io/lib/transports/websocket.js:76:30)
> [INFO] at emitTwo (events.js:106:13)
> [INFO] at WebSocket.emit (events.js:191:7)
> [INFO] at Receiver.ontext (/Users/mmiklavcic/devprojects/metron/metron-interface/metron-config/node_modules/karma/node_modules/ws/lib/WebSocket.js:816:10)
> [INFO] at /Users/mmiklavcic/devprojects/metron/metron-interface/metron-config/node_modules/karma/node_modules/ws/lib/Receiver.js:477:18
> [INFO] at Receiver.applyExtensions (/Users/mmiklavcic/devprojects/metron/metron-interface/metron-config/node_modules/karma/node_modules/ws/lib/Receiver.js:364:5)
> [INFO] at /Users/mmiklavcic/devprojects/metron/metron-interface/metron-config/node_modules/karma/node_modules/ws/lib/Receiver.js:466:14
> [INFO] at Receiver.flush (/Users/mmiklavcic/devprojects/metron/metron-interface/metron-config/node_modules/karma/node_modules/ws/lib/Receiver.js:340:3)
> [INFO] at Receiver.opcodes.1.finish (/Users/mmiklavcic/devprojects/metron/metron-interface/metron-config/node_modules/karma/node_modules/ws/lib/Receiver.js:482:12)
> [INFO] at Receiver.expectHandler (/Users/mmiklavcic/devprojects/metron/metron-interface/metron-config/node_modules/karma/node_modules/ws/lib/Receiver.js:451:33)
> [INFO] at Receiver.add (/Users/mmiklavcic/devprojects/metron/metron-interface/metron-config/node_modules/karma/node_modules/ws/lib/Receiver.js:95:24)
> [INFO] at Socket.realHandler (/Users/mmiklavcic/devprojects/metron/metron-interface/metron-config/node_modules/karma/node_modules/ws/lib/WebSocket.js:800:20)
> [INFO] at emitOne (events.js:96:13)
> [INFO] at Socket.emit (events.js:188:7)
> [INFO] at readableAddChunk (_stream_readable.js:172:18)
> [INFO] at Socket.Readable.push (_stream_readable.js:130:10)
> [INFO] at TCP.onread (net.js:542:20)
> PhantomJS 2.1.1 (Mac OS X 0.0.0) ERROR
> [INFO] Disconnected, because no message in 10000 ms.
> [INFO] PhantomJS 2.1.1 (Mac OS X 0.0.0): Executed 241 of 241 DISCONNECTED (1 min 47.531 secs / 1 min 37.477 secs)
> [INFO] PhantomJS 2.1.1 (Mac OS X 0.0.0) ERROR
> PhantomJS 2.1.1 (Mac OS X 0.0.0): Executed 241 of 241 DISCONNECTED (1 min 47.531 secs / 1 min 37.477 secs)
> [INFO] 24 01 2018 09:15:35.327:ERROR [karma]: TypeError: sourceMap.originalPositionFor is not a function
> [INFO] at getMapping (/Users/mmiklavcic/devprojects/metron/metron-interface/metron-config/node_modules/remap-istanbul/lib/remap.js:76:25)
> [INFO] at /Users/mmiklavcic/devprojects/metron/metron-interface/metron-config/node_modules/remap-istanbul/lib/remap.js:245:20
> [INFO] at Array.forEach (native)
> [INFO] at /Users/mmiklavcic/devprojects/metron/metron-interface/metron-config/node_modules/remap-istanbul/lib/remap.js:243:37
> [INFO] at Array.forEach (native)
> [INFO] at /Users/mmiklavcic/devprojects/metron/metron-interface/metron-config/node_modules/remap-istanbul/lib/remap.js:192:22
> [INFO] at Array.forEach (native)
> [INFO] at remap (/Users/mmiklavcic/devprojects/metron/metron-interface/metron-config/node_modules/remap-istanbul/lib/remap.js:191:12)
> [INFO] at onRunComplete (/Users/mmiklavcic/devprojects/metron/metron-interface/metron-config/node_modules/karma-remap-istanbul/index.js:55:21)
> [INFO] at .<anonymous> (/Users/mmiklavcic/devprojects/metron/metron-interface/metron-config/node_modules/karma/lib/events.js:13:22)
> [INFO] at emitTwo (events.js:111:20)
> [INFO] at emit (events.js:191:7)
> [INFO] at emitRunCompleteIfAllBrowsersDone (/Users/mmiklavcic/devprojects/metron/metron-interface/metron-config/node_modules/karma/lib/server.js:294:12)
> [INFO] at .<anonymous> (/Users/mmiklavcic/devprojects/metron/metron-interface/metron-config/node_modules/karma/lib/server.js:325:7)
> [INFO] at emitOne (events.js:96:13)
> [INFO] at emit (events.js:188:7)
> [INFO] at .<anonymous> (/Users/mmiklavcic/devprojects/metron/metron-interface/metron-config/node_modules/karma/lib/server.js:308:12)
> [INFO] at emitOne (events.js:101:20)
> [INFO] at emit (events.js:188:7)
> [INFO] at Timeout._onTimeout (/Users/mmiklavcic/devprojects/metron/metron-interface/metron-config/node_modules/karma/lib/browser.js:51:15)
> [INFO] at tryOnTimeout (timers.js:224:11)
> [INFO] at Timer.listOnTimeout (timers.js:198:5)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)