You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "mihailoale-db (via GitHub)" <gi...@apache.org> on 2026/09/23 12:52:11 UTC
[PR] [SPARK-59746][SQL][TESTS] Improve golden file testing for hints [spark]
mihailoale-db opened a new pull request, #58995:
URL: https://github.com/apache/spark/pull/58995
### What changes were proposed in this pull request?
In this PR I propose to improve golden files testing for hints.
### Why are the changes needed?
They don't exist at the moment and I propose to `introduce sql/core/src/test/resources/sql-tests/inputs/hints.sql`
### Does this PR introduce _any_ user-facing change?
No (testing only change)
### How was this patch tested?
Testing only change.
### Was this patch authored or co-authored using generative AI tooling?
Yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59746][SQL][TESTS] Improve golden file testing for hints [spark]
Posted by "mihailoale-db (via GitHub)" <gi...@apache.org>.
mihailoale-db commented on PR #58995:
URL: https://github.com/apache/spark/pull/58995#issuecomment-5810172771
@uros-b Done. PTAL when you find time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59746][SQL][TESTS] Improve golden file testing for hints [spark]
Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b closed pull request #58995: [SPARK-59746][SQL][TESTS] Improve golden file testing for hints
URL: https://github.com/apache/spark/pull/58995
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59746][SQL][TESTS] Improve golden file testing for hints [spark]
Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b commented on PR #58995:
URL: https://github.com/apache/spark/pull/58995#issuecomment-5829572175
**Merge Summary:**
- merged into master https://github.com/apache/spark/commit/600b8b0eb73770a9d00cec12d630709735793df8
- merged into branch-4.x https://github.com/apache/spark/commit/a0526fcc30af1cc77f07417560df0a383487ab3e
*Posted by `merge_spark_pr.py`*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59746][SQL][TESTS] Improve golden file testing for hints [spark]
Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b commented on PR #58995:
URL: https://github.com/apache/spark/pull/58995#issuecomment-5809061842
Thank you @mihailoale-db, please also make sure to update the PR description per the comments above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org