You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Lang Yang (JIRA)" <ji...@apache.org> on 2010/04/27 09:51:32 UTC

[jira] Created: (HARMONY-6507) [classlib][imageio] Implementation for ordering feature of ServiceRegistry

[classlib][imageio] Implementation for ordering feature of ServiceRegistry
--------------------------------------------------------------------------

                 Key: HARMONY-6507
                 URL: https://issues.apache.org/jira/browse/HARMONY-6507
             Project: Harmony
          Issue Type: Sub-task
          Components: Classlib
            Reporter: Lang Yang
         Attachments: HARMONY-6507-lang.txt

Implementation of ordering feature for ImageIO.spi.ServiceRegistry class as discussed with Alexei Fedotov on the dev mailing list.  Test case is also provided.

TODO: If the graph of pairwise orderings contains cycles, any providers that belong to a cycle will not be returned. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Re: [jira] Commented: (HARMONY-6507) [classlib][imageio] Implementation for ordering feature of ServiceRegistry

Posted by Alexei Fedotov <al...@gmail.com>.
Lang,
Please note my question and useful RI test run hint in JIRA.

--
With best regards / с наилучшими пожеланиями,
Alexei Fedotov / Алексей Федотов,
http://www.telecom-express.ru/
http://harmony.apache.org/
http://dataved.ru/ http://klsh.ru/




On Thu, May 6, 2010 at 7:05 PM, Alexei Fedotov (JIRA) <ji...@apache.org> wrote:
>
>    [ https://issues.apache.org/jira/browse/HARMONY-6507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12864787#action_12864787 ]
>
> Alexei Fedotov commented on HARMONY-6507:
> -----------------------------------------
>
> Lang, I'm trying to understand the testGetServiceProviders  testcase. Why do you add jpegWriter to CATEGORIES[1] category? How does RI run this test if you set test.jre.home to RI directory?
>
> $ ant -Dbuild.module=imageio -Dtest.jre.home=<path to RI> test
>
>
>> [classlib][imageio] Implementation for ordering feature of ServiceRegistry
>> --------------------------------------------------------------------------
>>
>>                 Key: HARMONY-6507
>>                 URL: https://issues.apache.org/jira/browse/HARMONY-6507
>>             Project: Harmony
>>          Issue Type: Sub-task
>>          Components: Classlib
>>            Reporter: Lang Yang
>>            Assignee: Alexei Fedotov
>>         Attachments: HARMONY-6507-lang-2.txt
>>
>>
>> Implementation of ordering feature for ImageIO.spi.ServiceRegistry class as discussed with Alexei Fedotov on the dev mailing list.  Test case is also provided.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>

[jira] Updated: (HARMONY-6507) [classlib][imageio] Implementation for ordering feature of ServiceRegistry

Posted by "Lang Yang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-6507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lang Yang updated HARMONY-6507:
-------------------------------

    Attachment:     (was: imageio_build.diff)

> [classlib][imageio] Implementation for ordering feature of ServiceRegistry
> --------------------------------------------------------------------------
>
>                 Key: HARMONY-6507
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6507
>             Project: Harmony
>          Issue Type: Sub-task
>          Components: Classlib
>            Reporter: Lang Yang
>            Assignee: Alexei Fedotov
>         Attachments: HARMONY-6507-lang-3.txt
>
>
> Implementation of ordering feature for ImageIO.spi.ServiceRegistry class as discussed with Alexei Fedotov on the dev mailing list.  Test case is also provided.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-6507) [classlib][imageio] Implementation for ordering feature of ServiceRegistry

Posted by "Lang Yang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-6507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lang Yang updated HARMONY-6507:
-------------------------------

    Attachment:     (was: HARMONY-6507-lang-2.txt)

> [classlib][imageio] Implementation for ordering feature of ServiceRegistry
> --------------------------------------------------------------------------
>
>                 Key: HARMONY-6507
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6507
>             Project: Harmony
>          Issue Type: Sub-task
>          Components: Classlib
>            Reporter: Lang Yang
>            Assignee: Alexei Fedotov
>         Attachments: HARMONY-6507-lang-3.txt
>
>
> Implementation of ordering feature for ImageIO.spi.ServiceRegistry class as discussed with Alexei Fedotov on the dev mailing list.  Test case is also provided.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-6507) [classlib][imageio] Implementation for ordering feature of ServiceRegistry

Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-6507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12875058#action_12875058 ] 

Mark Hindess commented on HARMONY-6507:
---------------------------------------

At first glance the build.xml patch doesn't look quite right.  If you have a compile with an include then I'd expect the other compile to exclude the same set of files to avoid compiling them twice?


> [classlib][imageio] Implementation for ordering feature of ServiceRegistry
> --------------------------------------------------------------------------
>
>                 Key: HARMONY-6507
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6507
>             Project: Harmony
>          Issue Type: Sub-task
>          Components: Classlib
>            Reporter: Lang Yang
>            Assignee: Alexei Fedotov
>         Attachments: HARMONY-6507-lang-3.txt, imageio_build.diff
>
>
> Implementation of ordering feature for ImageIO.spi.ServiceRegistry class as discussed with Alexei Fedotov on the dev mailing list.  Test case is also provided.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-6507) [classlib][imageio] Implementation for ordering feature of ServiceRegistry

Posted by "Lang Yang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-6507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lang Yang updated HARMONY-6507:
-------------------------------

    Attachment: HARMONY-6507-lang-3.txt

Hello Alexei,

Cause we only have 3 reader spis, so I wanted to add jpegWriter to CATEGORIES[1] to get one more element to be sorted. I had read Harmony's code, and found that the current implementation allows a different type of spis to a certain category. Therefore, I did so. 

After I have tested on RI, I found out that RI doesn't allow this operation. So, I have fixed this issue. Some other bugs have also been fixed accordingly.

Please test the new patch and let me know if there any problems.

Thank you,

Lang

> [classlib][imageio] Implementation for ordering feature of ServiceRegistry
> --------------------------------------------------------------------------
>
>                 Key: HARMONY-6507
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6507
>             Project: Harmony
>          Issue Type: Sub-task
>          Components: Classlib
>            Reporter: Lang Yang
>            Assignee: Alexei Fedotov
>         Attachments: HARMONY-6507-lang-3.txt
>
>
> Implementation of ordering feature for ImageIO.spi.ServiceRegistry class as discussed with Alexei Fedotov on the dev mailing list.  Test case is also provided.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-6507) [classlib][imageio] Implementation for ordering feature of ServiceRegistry

Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-6507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12862773#action_12862773 ] 

Alexei Fedotov commented on HARMONY-6507:
-----------------------------------------

Hello Lang,

I'm trying to apply your patch and run tests. I got the following problem:

testGetServiceProviders	Failure	expected:<or...@29e872c8> but was:<or...@29e87260>

Somthing is broken, I cannot commit that. Could you please fix it?

> [classlib][imageio] Implementation for ordering feature of ServiceRegistry
> --------------------------------------------------------------------------
>
>                 Key: HARMONY-6507
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6507
>             Project: Harmony
>          Issue Type: Sub-task
>          Components: Classlib
>            Reporter: Lang Yang
>            Assignee: Alexei Fedotov
>         Attachments: HARMONY-6507-lang.txt
>
>
> Implementation of ordering feature for ImageIO.spi.ServiceRegistry class as discussed with Alexei Fedotov on the dev mailing list.  Test case is also provided.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-6507) [classlib][imageio] Implementation for ordering feature of ServiceRegistry

Posted by "Lang Yang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-6507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lang Yang updated HARMONY-6507:
-------------------------------

    Patch Info: [Patch Available]

> [classlib][imageio] Implementation for ordering feature of ServiceRegistry
> --------------------------------------------------------------------------
>
>                 Key: HARMONY-6507
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6507
>             Project: Harmony
>          Issue Type: Sub-task
>          Components: Classlib
>            Reporter: Lang Yang
>         Attachments: HARMONY-6507-lang.txt
>
>
> Implementation of ordering feature for ImageIO.spi.ServiceRegistry class as discussed with Alexei Fedotov on the dev mailing list.  Test case is also provided.
> TODO: If the graph of pairwise orderings contains cycles, any providers that belong to a cycle will not be returned. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-6507) [classlib][imageio] Implementation for ordering feature of ServiceRegistry

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-6507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12877526#action_12877526 ] 

Hudson commented on HARMONY-6507:
---------------------------------

Integrated in Harmony-1.5-head-linux-x86_64 #842 (See [http://hudson.zones.apache.org/hudson/job/Harmony-1.5-head-linux-x86_64/842/])
    Committed Lang's patch for HARMONY-6507: implemented service registry ordering.


> [classlib][imageio] Implementation for ordering feature of ServiceRegistry
> --------------------------------------------------------------------------
>
>                 Key: HARMONY-6507
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6507
>             Project: Harmony
>          Issue Type: Sub-task
>          Components: Classlib
>            Reporter: Lang Yang
>            Assignee: Alexei Fedotov
>             Fix For: 5.0M15
>
>         Attachments: HARMONY-6507-lang-3.txt, imageio_build.diff, imageio_build_v2.diff
>
>
> Implementation of ordering feature for ImageIO.spi.ServiceRegistry class as discussed with Alexei Fedotov on the dev mailing list.  Test case is also provided.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HARMONY-6507) [classlib][imageio] Implementation for ordering feature of ServiceRegistry

Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-6507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexei Fedotov resolved HARMONY-6507.
-------------------------------------

    Fix Version/s: 5.0M15
       Resolution: Fixed

... and yes, I have fixed a small conflict with Tim's commit of HARMONY-6518.

> [classlib][imageio] Implementation for ordering feature of ServiceRegistry
> --------------------------------------------------------------------------
>
>                 Key: HARMONY-6507
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6507
>             Project: Harmony
>          Issue Type: Sub-task
>          Components: Classlib
>            Reporter: Lang Yang
>            Assignee: Alexei Fedotov
>             Fix For: 5.0M15
>
>         Attachments: HARMONY-6507-lang-3.txt, imageio_build.diff, imageio_build_v2.diff
>
>
> Implementation of ordering feature for ImageIO.spi.ServiceRegistry class as discussed with Alexei Fedotov on the dev mailing list.  Test case is also provided.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-6507) [classlib][imageio] Implementation for ordering feature of ServiceRegistry

Posted by "Lang Yang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-6507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lang Yang updated HARMONY-6507:
-------------------------------

    Attachment: imageio_build.diff

> [classlib][imageio] Implementation for ordering feature of ServiceRegistry
> --------------------------------------------------------------------------
>
>                 Key: HARMONY-6507
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6507
>             Project: Harmony
>          Issue Type: Sub-task
>          Components: Classlib
>            Reporter: Lang Yang
>            Assignee: Alexei Fedotov
>         Attachments: HARMONY-6507-lang-3.txt, imageio_build.diff
>
>
> Implementation of ordering feature for ImageIO.spi.ServiceRegistry class as discussed with Alexei Fedotov on the dev mailing list.  Test case is also provided.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-6507) [classlib][imageio] Implementation for ordering feature of ServiceRegistry

Posted by "Lang Yang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-6507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lang Yang updated HARMONY-6507:
-------------------------------

    Attachment: HARMONY-6507-lang-2.txt

Hello Alexei,

I have made some changes against the testGetServiceProviders method in the new patach. The ServiceRegistry ordering is a little bit hard to test. There could be serveral correct return results. 

I had passed all the test cases before I submitted the previouse patch. Don't know why it didn't work on your computer. Could you please re-test using the new patch and let me know the result?

Thank you,

Lang

> [classlib][imageio] Implementation for ordering feature of ServiceRegistry
> --------------------------------------------------------------------------
>
>                 Key: HARMONY-6507
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6507
>             Project: Harmony
>          Issue Type: Sub-task
>          Components: Classlib
>            Reporter: Lang Yang
>            Assignee: Alexei Fedotov
>         Attachments: HARMONY-6507-lang-2.txt
>
>
> Implementation of ordering feature for ImageIO.spi.ServiceRegistry class as discussed with Alexei Fedotov on the dev mailing list.  Test case is also provided.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-6507) [classlib][imageio] Implementation for ordering feature of ServiceRegistry

Posted by "Lang Yang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-6507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lang Yang updated HARMONY-6507:
-------------------------------

    Attachment:     (was: HARMONY-6507-lang.txt)

> [classlib][imageio] Implementation for ordering feature of ServiceRegistry
> --------------------------------------------------------------------------
>
>                 Key: HARMONY-6507
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6507
>             Project: Harmony
>          Issue Type: Sub-task
>          Components: Classlib
>            Reporter: Lang Yang
>            Assignee: Alexei Fedotov
>
> Implementation of ordering feature for ImageIO.spi.ServiceRegistry class as discussed with Alexei Fedotov on the dev mailing list.  Test case is also provided.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (HARMONY-6507) [classlib][imageio] Implementation for ordering feature of ServiceRegistry

Posted by "Lang Yang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-6507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lang Yang closed HARMONY-6507.
------------------------------


> [classlib][imageio] Implementation for ordering feature of ServiceRegistry
> --------------------------------------------------------------------------
>
>                 Key: HARMONY-6507
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6507
>             Project: Harmony
>          Issue Type: Sub-task
>          Components: Classlib
>            Reporter: Lang Yang
>            Assignee: Alexei Fedotov
>             Fix For: 5.0M15
>
>         Attachments: HARMONY-6507-lang-3.txt, imageio_build.diff, imageio_build_v2.diff
>
>
> Implementation of ordering feature for ImageIO.spi.ServiceRegistry class as discussed with Alexei Fedotov on the dev mailing list.  Test case is also provided.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-6507) [classlib][imageio] Implementation for ordering feature of ServiceRegistry

Posted by "Lang Yang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-6507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lang Yang updated HARMONY-6507:
-------------------------------

    Attachment: HARMONY-6507-lang.txt

> [classlib][imageio] Implementation for ordering feature of ServiceRegistry
> --------------------------------------------------------------------------
>
>                 Key: HARMONY-6507
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6507
>             Project: Harmony
>          Issue Type: Sub-task
>          Components: Classlib
>            Reporter: Lang Yang
>         Attachments: HARMONY-6507-lang.txt
>
>
> Implementation of ordering feature for ImageIO.spi.ServiceRegistry class as discussed with Alexei Fedotov on the dev mailing list.  Test case is also provided.
> TODO: If the graph of pairwise orderings contains cycles, any providers that belong to a cycle will not be returned. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HARMONY-6507) [classlib][imageio] Implementation for ordering feature of ServiceRegistry

Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-6507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexei Fedotov reassigned HARMONY-6507:
---------------------------------------

    Assignee: Alexei Fedotov

> [classlib][imageio] Implementation for ordering feature of ServiceRegistry
> --------------------------------------------------------------------------
>
>                 Key: HARMONY-6507
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6507
>             Project: Harmony
>          Issue Type: Sub-task
>          Components: Classlib
>            Reporter: Lang Yang
>            Assignee: Alexei Fedotov
>         Attachments: HARMONY-6507-lang.txt
>
>
> Implementation of ordering feature for ImageIO.spi.ServiceRegistry class as discussed with Alexei Fedotov on the dev mailing list.  Test case is also provided.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-6507) [classlib][imageio] Implementation for ordering feature of ServiceRegistry

Posted by "Lang Yang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-6507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lang Yang updated HARMONY-6507:
-------------------------------

    Description: 
Implementation of ordering feature for ImageIO.spi.ServiceRegistry class as discussed with Alexei Fedotov on the dev mailing list.  Test case is also provided.


  was:
Implementation of ordering feature for ImageIO.spi.ServiceRegistry class as discussed with Alexei Fedotov on the dev mailing list.  Test case is also provided.

TODO: If the graph of pairwise orderings contains cycles, any providers that belong to a cycle will not be returned. 


> [classlib][imageio] Implementation for ordering feature of ServiceRegistry
> --------------------------------------------------------------------------
>
>                 Key: HARMONY-6507
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6507
>             Project: Harmony
>          Issue Type: Sub-task
>          Components: Classlib
>            Reporter: Lang Yang
>         Attachments: HARMONY-6507-lang.txt
>
>
> Implementation of ordering feature for ImageIO.spi.ServiceRegistry class as discussed with Alexei Fedotov on the dev mailing list.  Test case is also provided.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-6507) [classlib][imageio] Implementation for ordering feature of ServiceRegistry

Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-6507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12877515#action_12877515 ] 

Alexei Fedotov commented on HARMONY-6507:
-----------------------------------------

Lang, thank you for the patch. Please, check if the patch is applied correctly at r953413.

I adjusted the test for RI, renamed "emptyList" to "firstNodes", added few comments and Wikipedia reference about the algorithm, moved localization strings into message.properties. I also removed @SuppressWarnings("unchecked") since I didn't see any warnings. My environment doesn't show warnings, but maybe yours one does.

> [classlib][imageio] Implementation for ordering feature of ServiceRegistry
> --------------------------------------------------------------------------
>
>                 Key: HARMONY-6507
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6507
>             Project: Harmony
>          Issue Type: Sub-task
>          Components: Classlib
>            Reporter: Lang Yang
>            Assignee: Alexei Fedotov
>         Attachments: HARMONY-6507-lang-3.txt, imageio_build.diff, imageio_build_v2.diff
>
>
> Implementation of ordering feature for ImageIO.spi.ServiceRegistry class as discussed with Alexei Fedotov on the dev mailing list.  Test case is also provided.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-6507) [classlib][imageio] Implementation for ordering feature of ServiceRegistry

Posted by "Lang Yang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-6507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lang Yang updated HARMONY-6507:
-------------------------------

    Attachment: imageio_build_v2.diff

Thanks Mark, you are right. 

I uploaded a new version of build.xml patch. In this patch, I want to keep support files in "src/test/support" folder, api specific tests in "src/test/api/java" folder and impl specific tests in "src/test/impl/java" folder. In run-test.xml, I have created two new targets: "-test-module" is for api specific tests and "-test-module-impl" is for impl specific tests.

For some reason, the patch doesn't includes the folders I have created. If you think the patch looks ok, could you please create these folders:
src/test/api/
src/test/impl/java
src/test/support/common/java

and move the "src/test/java" folder under "src/test/api" (as they are all api specific tests)

Thank you very much, let me know if there any thing wrong.

Lang

> [classlib][imageio] Implementation for ordering feature of ServiceRegistry
> --------------------------------------------------------------------------
>
>                 Key: HARMONY-6507
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6507
>             Project: Harmony
>          Issue Type: Sub-task
>          Components: Classlib
>            Reporter: Lang Yang
>            Assignee: Alexei Fedotov
>         Attachments: HARMONY-6507-lang-3.txt, imageio_build.diff, imageio_build_v2.diff
>
>
> Implementation of ordering feature for ImageIO.spi.ServiceRegistry class as discussed with Alexei Fedotov on the dev mailing list.  Test case is also provided.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-6507) [classlib][imageio] Implementation for ordering feature of ServiceRegistry

Posted by "Lang Yang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-6507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lang Yang updated HARMONY-6507:
-------------------------------

    Attachment: imageio_build.diff

Hi, I have made some changes against build.xml and make/run-test.xml file (see imageio_build.diff) in order to put supporting classes to classpath when running test cases.

> [classlib][imageio] Implementation for ordering feature of ServiceRegistry
> --------------------------------------------------------------------------
>
>                 Key: HARMONY-6507
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6507
>             Project: Harmony
>          Issue Type: Sub-task
>          Components: Classlib
>            Reporter: Lang Yang
>            Assignee: Alexei Fedotov
>         Attachments: HARMONY-6507-lang-3.txt, imageio_build.diff
>
>
> Implementation of ordering feature for ImageIO.spi.ServiceRegistry class as discussed with Alexei Fedotov on the dev mailing list.  Test case is also provided.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-6507) [classlib][imageio] Implementation for ordering feature of ServiceRegistry

Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-6507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12864787#action_12864787 ] 

Alexei Fedotov commented on HARMONY-6507:
-----------------------------------------

Lang, I'm trying to understand the testGetServiceProviders  testcase. Why do you add jpegWriter to CATEGORIES[1] category? How does RI run this test if you set test.jre.home to RI directory?

$ ant -Dbuild.module=imageio -Dtest.jre.home=<path to RI> test


> [classlib][imageio] Implementation for ordering feature of ServiceRegistry
> --------------------------------------------------------------------------
>
>                 Key: HARMONY-6507
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6507
>             Project: Harmony
>          Issue Type: Sub-task
>          Components: Classlib
>            Reporter: Lang Yang
>            Assignee: Alexei Fedotov
>         Attachments: HARMONY-6507-lang-2.txt
>
>
> Implementation of ordering feature for ImageIO.spi.ServiceRegistry class as discussed with Alexei Fedotov on the dev mailing list.  Test case is also provided.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-6507) [classlib][imageio] Implementation for ordering feature of ServiceRegistry

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-6507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12877563#action_12877563 ] 

Hudson commented on HARMONY-6507:
---------------------------------

Integrated in Harmony-select-1.5-head-linux-x86_64 #29 (See [http://hudson.zones.apache.org/hudson/job/Harmony-select-1.5-head-linux-x86_64/29/])
    Committed Lang's patch for HARMONY-6507: implemented service registry ordering.


> [classlib][imageio] Implementation for ordering feature of ServiceRegistry
> --------------------------------------------------------------------------
>
>                 Key: HARMONY-6507
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6507
>             Project: Harmony
>          Issue Type: Sub-task
>          Components: Classlib
>            Reporter: Lang Yang
>            Assignee: Alexei Fedotov
>             Fix For: 5.0M15
>
>         Attachments: HARMONY-6507-lang-3.txt, imageio_build.diff, imageio_build_v2.diff
>
>
> Implementation of ordering feature for ImageIO.spi.ServiceRegistry class as discussed with Alexei Fedotov on the dev mailing list.  Test case is also provided.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.