You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by GitBox <gi...@apache.org> on 2021/01/14 20:23:44 UTC
[GitHub] [lucene-solr-operator] anshumg opened a new pull request #176: Standardize headers to be ASL2.0, move copyright to NOTICE
anshumg opened a new pull request #176:
URL: https://github.com/apache/lucene-solr-operator/pull/176
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] [lucene-solr-operator] klaporte commented on pull request #176: Standardize headers to be ASL2.0, move copyright to NOTICE
Posted by GitBox <gi...@apache.org>.
klaporte commented on pull request #176:
URL: https://github.com/apache/lucene-solr-operator/pull/176#issuecomment-760495787
Looks good to me. Thanks @anshumg & @HoustonPutman
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] [lucene-solr-operator] anshumg commented on pull request #176: Standardize headers to be ASL2.0, move copyright to NOTICE
Posted by GitBox <gi...@apache.org>.
anshumg commented on pull request #176:
URL: https://github.com/apache/lucene-solr-operator/pull/176#issuecomment-760490146
FYI, still waiting for Infra to remove the required checks before I can squash and merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] [lucene-solr-operator] anshumg merged pull request #176: Standardize headers to be ASL2.0, move copyright to NOTICE
Posted by GitBox <gi...@apache.org>.
anshumg merged pull request #176:
URL: https://github.com/apache/lucene-solr-operator/pull/176
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: [GitHub] [lucene-solr-operator] anshumg commented on pull request
#176: Standardize headers to be ASL2.0, move copyright to NOTICE
Posted by joyce chan <jo...@gmail.com>.
dev-unsubscribe@lucene.apache.org
On Thu, Jan 14, 2021 at 4:10 PM GitBox <gi...@apache.org> wrote:
>
> anshumg commented on pull request #176:
> URL:
> https://github.com/apache/lucene-solr-operator/pull/176#issuecomment-760474459
>
>
> @HoustonPutman - reading more about the license and the requirements
> around that. We might be able to remove that too. I'll do that as another
> PR if needed once I have clarity.
>
> The only thing missing here is the fix in `check-license.sh`
>
>
> ----------------------------------------------------------------
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on to GitHub and use the
> URL above to go to the specific comment.
>
> For queries about this service, please contact Infrastructure at:
> users@infra.apache.org
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
>
--
Joyce Chan
joyce.sz.chan@Gmail.com
[GitHub] [lucene-solr-operator] anshumg commented on pull request #176: Standardize headers to be ASL2.0, move copyright to NOTICE
Posted by GitBox <gi...@apache.org>.
anshumg commented on pull request #176:
URL: https://github.com/apache/lucene-solr-operator/pull/176#issuecomment-760474459
@HoustonPutman - reading more about the license and the requirements around that. We might be able to remove that too. I'll do that as another PR if needed once I have clarity.
The only thing missing here is the fix in `check-license.sh`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] [lucene-solr-operator] anshumg commented on pull request #176: Standardize headers to be ASL2.0, move copyright to NOTICE
Posted by GitBox <gi...@apache.org>.
anshumg commented on pull request #176:
URL: https://github.com/apache/lucene-solr-operator/pull/176#issuecomment-760545292
Thanks for taking a look @klaporte :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] [lucene-solr-operator] anshumg commented on a change in pull request #176: Standardize headers to be ASL2.0, move copyright to NOTICE
Posted by GitBox <gi...@apache.org>.
anshumg commented on a change in pull request #176:
URL: https://github.com/apache/lucene-solr-operator/pull/176#discussion_r557694683
##########
File path: NOTICE.txt
##########
@@ -0,0 +1,30 @@
+==============================================================
+ Apache Solr
+ Copyright 2006-2021 The Apache Software Foundation
+==============================================================
+
+This product includes software developed at
+The Apache Software Foundation (http://www.apache.org/).
+
+Includes software from other Apache Software Foundation projects,
+including, but not limited to:
+ - Apache Lucene Java
Review comment:
Yes, but we might not have to add Solr as it's the same project. I think the Lucene bit that exists in 'Solr' is just cruft from 10 years ago :) It'll be required again in the future, but for the operator, we shouldn't need Lucene in this list.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] [lucene-solr-operator] HoustonPutman commented on a change in pull request #176: Standardize headers to be ASL2.0, move copyright to NOTICE
Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on a change in pull request #176:
URL: https://github.com/apache/lucene-solr-operator/pull/176#discussion_r557689208
##########
File path: NOTICE.txt
##########
@@ -0,0 +1,30 @@
+==============================================================
+ Apache Solr
+ Copyright 2006-2021 The Apache Software Foundation
+==============================================================
+
+This product includes software developed at
+The Apache Software Foundation (http://www.apache.org/).
+
+Includes software from other Apache Software Foundation projects,
+including, but not limited to:
+ - Apache Lucene Java
Review comment:
I imagine we are going to have to fill this out with the go dependencies we use?
##########
File path: NOTICE.txt
##########
@@ -0,0 +1,30 @@
+==============================================================
+ Apache Solr
Review comment:
Should this be Apache Solr Operator?
##########
File path: NOTICE.txt
##########
@@ -0,0 +1,30 @@
+==============================================================
+ Apache Solr
+ Copyright 2006-2021 The Apache Software Foundation
+==============================================================
+
+This product includes software developed at
+The Apache Software Foundation (http://www.apache.org/).
+
+Includes software from other Apache Software Foundation projects,
+including, but not limited to:
+ - Apache Lucene Java
Review comment:
So this project doesn't actually contain software from Apache Lucene, right? We use the APIs, but not the libraries.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org