You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gaston Kleiman <ga...@mesosphere.io> on 2018/02/12 23:41:07 UTC
Review Request 65616: Removed outdated executor-wide launched flag
from the default executor.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65616/
-----------------------------------------------------------
Review request for mesos, Anand Mazumdar, Greg Mann, Qian Zhang, and Vinod Kone.
Repository: mesos
Description
-------
Removed outdated executor-wide launched flag from the default executor.
Diffs
-----
src/launcher/default_executor.cpp 4a619859095cc2d30f4806813f64a2e48c83b3ea
Diff: https://reviews.apache.org/r/65616/diff/1/
Testing
-------
`make check` on GNU/Linux
Thanks,
Gaston Kleiman
Re: Review Request 65616: Removed outdated executor-wide launched
flag from the default executor.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65616/#review197508
-----------------------------------------------------------
Ship it!
Ship It!
- Qian Zhang
On Feb. 13, 2018, 7:41 a.m., Gaston Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65616/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2018, 7:41 a.m.)
>
>
> Review request for mesos, Anand Mazumdar, Greg Mann, Qian Zhang, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed outdated executor-wide launched flag from the default executor.
>
>
> Diffs
> -----
>
> src/launcher/default_executor.cpp 4a619859095cc2d30f4806813f64a2e48c83b3ea
>
>
> Diff: https://reviews.apache.org/r/65616/diff/2/
>
>
> Testing
> -------
>
> `make check` on GNU/Linux
>
>
> Thanks,
>
> Gaston Kleiman
>
>
Re: Review Request 65616: Removed outdated executor-wide launched
flag from the default executor.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65616/#review197377
-----------------------------------------------------------
Patch looks great!
Reviews applied: [65548, 65549, 65550, 65551, 65552, 65556, 65616]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 12, 2018, 11:41 p.m., Gaston Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65616/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2018, 11:41 p.m.)
>
>
> Review request for mesos, Anand Mazumdar, Greg Mann, Qian Zhang, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed outdated executor-wide launched flag from the default executor.
>
>
> Diffs
> -----
>
> src/launcher/default_executor.cpp 4a619859095cc2d30f4806813f64a2e48c83b3ea
>
>
> Diff: https://reviews.apache.org/r/65616/diff/2/
>
>
> Testing
> -------
>
> `make check` on GNU/Linux
>
>
> Thanks,
>
> Gaston Kleiman
>
>
Re: Review Request 65616: Removed outdated executor-wide launched
flag from the default executor.
Posted by Gaston Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65616/
-----------------------------------------------------------
(Updated Feb. 14, 2018, 8:48 p.m.)
Review request for mesos, Anand Mazumdar, Greg Mann, Qian Zhang, and Vinod Kone.
Bugs: MESOS-8468
https://issues.apache.org/jira/browse/MESOS-8468
Repository: mesos
Description
-------
Removed outdated executor-wide launched flag from the default executor.
Diffs
-----
src/launcher/default_executor.cpp 4a619859095cc2d30f4806813f64a2e48c83b3ea
Diff: https://reviews.apache.org/r/65616/diff/2/
Testing
-------
`make check` on GNU/Linux
Thanks,
Gaston Kleiman
Re: Review Request 65616: Removed outdated executor-wide launched
flag from the default executor.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65616/#review197330
-----------------------------------------------------------
FAIL: Failed to apply the current review.
Failed command: `python.exe .\support\apply-reviews.py -n -r 65616`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65616
Relevant logs:
- [apply-review-65616-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65616/logs/apply-review-65616-stdout.log):
```
error: patch failed: src/launcher/default_executor.cpp:540
error: src/launcher/default_executor.cpp: patch does not apply
```
- Mesos Reviewbot Windows
On Feb. 12, 2018, 11:41 p.m., Gaston Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65616/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2018, 11:41 p.m.)
>
>
> Review request for mesos, Anand Mazumdar, Greg Mann, Qian Zhang, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed outdated executor-wide launched flag from the default executor.
>
>
> Diffs
> -----
>
> src/launcher/default_executor.cpp 4a619859095cc2d30f4806813f64a2e48c83b3ea
>
>
> Diff: https://reviews.apache.org/r/65616/diff/1/
>
>
> Testing
> -------
>
> `make check` on GNU/Linux
>
>
> Thanks,
>
> Gaston Kleiman
>
>
Re: Review Request 65616: Removed outdated executor-wide launched
flag from the default executor.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65616/#review197362
-----------------------------------------------------------
PASS: Mesos patch 65616 was successfully built and tested.
Reviews applied: `['65548', '65549', '65550', '65551', '65552', '65556', '65616']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65616
- Mesos Reviewbot Windows
On Feb. 12, 2018, 3:41 p.m., Gaston Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65616/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2018, 3:41 p.m.)
>
>
> Review request for mesos, Anand Mazumdar, Greg Mann, Qian Zhang, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed outdated executor-wide launched flag from the default executor.
>
>
> Diffs
> -----
>
> src/launcher/default_executor.cpp 4a619859095cc2d30f4806813f64a2e48c83b3ea
>
>
> Diff: https://reviews.apache.org/r/65616/diff/2/
>
>
> Testing
> -------
>
> `make check` on GNU/Linux
>
>
> Thanks,
>
> Gaston Kleiman
>
>