You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2017/12/07 23:59:28 UTC

[kudu-CR] java: re-revisit maven shade configuration 

Hello Jean-Daniel Cryans, Grant Henke,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/8792

to review the following change.


Change subject: java: re-revisit maven shade configuration
......................................................................

java: re-revisit maven shade configuration

I introduced a bug in the previous iteration of this patch[1].
kudu-spark-tools uber-jar should include the kudu-client-tools classes,
since the Spark ITBLL job relies on the BigLinkedListCommon class.

[1]: 68fa8010dddad81dd702c6f05fda7d561d9beef9

Change-Id: Ia091aa2167178fe0b553086db3e08769028670ce
---
M java/kudu-spark-tools/pom.xml
1 file changed, 1 insertion(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/92/8792/1
-- 
To view, visit http://gerrit.cloudera.org:8080/8792
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia091aa2167178fe0b553086db3e08769028670ce
Gerrit-Change-Number: 8792
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>

[kudu-CR] java: re-revisit maven shade configuration

Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change. ( http://gerrit.cloudera.org:8080/8792 )

Change subject: java: re-revisit maven shade configuration
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/8792
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia091aa2167178fe0b553086db3e08769028670ce
Gerrit-Change-Number: 8792
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 08 Dec 2017 00:00:58 +0000
Gerrit-HasComments: No

[kudu-CR] java: re-revisit maven shade configuration

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8792 )

Change subject: java: re-revisit maven shade configuration
......................................................................

java: re-revisit maven shade configuration

I introduced a bug in the previous iteration of this patch[1].
kudu-spark-tools uber-jar should include the kudu-client-tools classes,
since the Spark ITBLL job relies on the BigLinkedListCommon class.

[1]: 68fa8010dddad81dd702c6f05fda7d561d9beef9

Change-Id: Ia091aa2167178fe0b553086db3e08769028670ce
Reviewed-on: http://gerrit.cloudera.org:8080/8792
Reviewed-by: Jean-Daniel Cryans <jd...@apache.org>
Tested-by: Kudu Jenkins
---
M java/kudu-spark-tools/pom.xml
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Jean-Daniel Cryans: Looks good to me, approved
  Kudu Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/8792
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia091aa2167178fe0b553086db3e08769028670ce
Gerrit-Change-Number: 8792
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins