You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/12/08 00:09:14 UTC
Review Request 64431: Updated Windows documentation.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64431/
-----------------------------------------------------------
Review request for mesos, Akash Gupta, Greg Mann, and Joseph Wu.
Repository: mesos
Description
-------
Removed outdated notes about administrative priveleges being necessary
due to symlinks, which was resovled in MESOS-7370. Added note about
minimum supported Windows versions, including caveat that it will likely
increase.
Moved the Java and OpenSSL build examples from `cmake-examples.md` to
`windows.md`, with additional note that the Java build is only for unit
tests (to clarify that the `master` is not yet supported on Windows).
Updated latest tested version of OpenSSL, and added note about dynamic
linking and lack of bundled certificates.
Diffs
-----
docs/cmake-examples.md e3149bfd4b197059ee56bbb9e5c9926494c22572
docs/windows.md 6b6a74233ce047f4efa37e2f6415d089668ace0d
Diff: https://reviews.apache.org/r/64431/diff/1/
Testing
-------
Thanks,
Andrew Schwartzmeyer
Re: Review Request 64431: Updated Windows documentation.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
> On Dec. 11, 2017, 2:13 p.m., Greg Mann wrote:
> > docs/cmake-examples.md
> > Line 356 (original), 356 (patched)
> > <https://reviews.apache.org/r/64431/diff/2/?file=1912611#file1912611line356>
> >
> > Make sure you fix the spelling of "resolved" in the commit message :)
Ah damn it I missed this. Too late now.
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64431/#review193458
-----------------------------------------------------------
On Dec. 11, 2017, 10:31 a.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64431/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2017, 10:31 a.m.)
>
>
> Review request for mesos, Akash Gupta, Greg Mann, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed outdated notes about administrative privileges being necessary
> due to symlinks, which was resovled in MESOS-7370. Added note about
> minimum supported Windows versions, including caveat that it will likely
> increase.
>
> Moved the Java and OpenSSL build examples from `cmake-examples.md` to
> `windows.md`, with additional note that the Java build is only for unit
> tests (to clarify that the `master` is not yet supported on Windows).
>
> Updated latest tested version of OpenSSL, and added note about dynamic
> linking and lack of bundled certificates.
>
>
> Diffs
> -----
>
> docs/cmake-examples.md e3149bfd4b197059ee56bbb9e5c9926494c22572
> docs/windows.md 6b6a74233ce047f4efa37e2f6415d089668ace0d
>
>
> Diff: https://reviews.apache.org/r/64431/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 64431: Updated Windows documentation.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64431/#review193458
-----------------------------------------------------------
docs/cmake-examples.md
Line 356 (original), 356 (patched)
<https://reviews.apache.org/r/64431/#comment272007>
Make sure you fix the spelling of "resolved" in the commit message :)
- Greg Mann
On Dec. 11, 2017, 6:31 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64431/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2017, 6:31 p.m.)
>
>
> Review request for mesos, Akash Gupta, Greg Mann, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed outdated notes about administrative privileges being necessary
> due to symlinks, which was resovled in MESOS-7370. Added note about
> minimum supported Windows versions, including caveat that it will likely
> increase.
>
> Moved the Java and OpenSSL build examples from `cmake-examples.md` to
> `windows.md`, with additional note that the Java build is only for unit
> tests (to clarify that the `master` is not yet supported on Windows).
>
> Updated latest tested version of OpenSSL, and added note about dynamic
> linking and lack of bundled certificates.
>
>
> Diffs
> -----
>
> docs/cmake-examples.md e3149bfd4b197059ee56bbb9e5c9926494c22572
> docs/windows.md 6b6a74233ce047f4efa37e2f6415d089668ace0d
>
>
> Diff: https://reviews.apache.org/r/64431/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 64431: Updated Windows documentation.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64431/#review193448
-----------------------------------------------------------
FAIL: Some Mesos tests failed.
Reviews applied: `['64431']`
Failed command: `D:\DCOS\mesos\src\mesos-tests.exe --verbose`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64431
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64431/logs/mesos-tests-stdout.log):
```
[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[ OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (2481 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (2505 ms total)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (2479 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (2507 ms total)
[----------] Global test environment tear-down
[==========] 825 tests from 84 test cases ran. (323124 ms total)
[ PASSED ] 815 tests.
[ FAILED ] 10 tests, listed below:
[ FAILED ] OfferOperationStatusUpdateManagerTest.UpdateAndAckNonTerminalUpdate
[ FAILED ] OfferOperationStatusUpdateManagerTest.RecoverCheckpointedStream
[ FAILED ] OfferOperationStatusUpdateManagerTest.RecoverEmptyFile
[ FAILED ] OfferOperationStatusUpdateManagerTest.RecoverTerminatedStream
[ FAILED ] OfferOperationStatusUpdateManagerTest.IgnoreDuplicateUpdate
[ FAILED ] OfferOperationStatusUpdateManagerTest.IgnoreDuplicateUpdateAfterRecover
[ FAILED ] OfferOperationStatusUpdateManagerTest.RejectDuplicateAck
[ FAILED ] OfferOperationStatusUpdateManagerTest.RejectDuplicateAckAfterRecover
[ FAILED ] OfferOperationStatusUpdateManagerTest.NonStrictRecoveryCorruptedFile
[ FAILED ] SlaveTest.ResourceProviderPublishAll
10 FAILED TESTS
YOU HAVE 201 DISABLED TESTS
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64431/logs/mesos-tests-stderr.log):
```
I1211 21:30:06.582073 7568 master.cpp:10103] Updating the state of task c42f79fe-4320-4805-9680-5daf92b47d98 of framework f6cd7687-8b8e-4988-83eb-d0497d62beb0-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I1211 21:30:06.582073 10220 slave.cpp:3400] Shutting down framework f6cd7687-8b8e-4988-83eb-d0497d62beb0-0000
I1211 21:30:06.582073 102I1211 21:30:05.893044 5440 exec.cpp:162] Version: 1.5.0
I1211 21:30:05.916045 2532 exec.cpp:237] Executor registered on agent f6cd7687-8b8e-4988-83eb-d0497d62beb0-S0
I1211 21:30:05.919045 9388 executor.cpp:171] Received SUBSCRIBED event
I1211 21:30:05.923046 9388 executor.cpp:175] Subscribed executor on build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I1211 21:30:05.923046 9388 executor.cpp:171] Received LAUNCH event
I1211 21:30:05.927047 9388 executor.cpp:637] Starting task c42f79fe-4320-4805-9680-5daf92b47d98
I1211 21:30:06.006049 9388 executor.cpp:477] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch <POSSIBLY-SENSITIVE-DATA>'
I1211 21:30:06.557071 9388 executor.cpp:650] Forked command at 1412
I1211 21:30:06.584074 9756 exec.cpp:435] Executor asked to shutdown
I1211 21:30:06.585224 9388 executor.cpp:171] Received SHUTDOWN event
I1211 21:30:06.585224 9388 executor.cpp:747] Shutting down
I1211 21:30:06.585224 9388 executor.cpp:854] Sending SIGTERM to process tree at pid 120 slave.cpp:6091] Shutting down executor 'c42f79fe-4320-4805-9680-5daf92b47d98' of framework f6cd7687-8b8e-4988-83eb-d0497d62beb0-0000 at executor(1)@10.3.1.11:59572
I1211 21:30:06.583075 10220 slave.cpp:909] Agent terminating
W1211 21:30:06.584074 10220 slave.cpp:3396] Ignoring shutdown framework f6cd7687-8b8e-4988-83eb-d0497d62beb0-0000 because it is terminating
I1211 21:30:06.584074 7568 master.cpp:10209] Removing task c42f79fe-4320-4805-9680-5daf92b47d98 with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework f6cd7687-8b8e-4988-83eb-d0497d62beb0-0000 on agent f6cd7687-8b8e-4988-83eb-d0497d62beb0-S0 at slave(326)@10.3.1.11:59551 (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1211 21:30:06.586071 7696 containerizer.cpp:2328] Destroying container 3621328b-57ba-43cb-805e-6566f7663ad9 in RUNNING state
I1211 21:30:06.586071 7696 containerizer.cpp:2930] Transitioning the state of container 3621328b-57ba-43cb-805e-6566f7663ad9 from RUNNING to DESTROYING
I1211 21:30:06.587072 7568 master.cpp:1310] Agent f6cd7687-8b8e-4988-83eb-d0497d62beb0-S0 at slave(326)@10.3.1.11:59551 (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I1211 21:30:06.587072 7568 master.cpp:3369] Disconnecting agent f6cd7687-8b8e-4988-83eb-d0497d62beb0-S0 at slave(326)@10.3.1.11:59551 (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1211 21:30:06.587072 9204 hierarchical.cpp:344] Removed framework f6cd7687-8b8e-4988-83eb-d0497d62beb0-0000
I1211 21:30:06.587072 7568 master.cpp:3388] Deactivating agent f6cd7687-8b8e-4988-83eb-d0497d62beb0-S0 at slave(326)@10.3.1.11:59551 (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1211 21:30:06.588074 8072 hierarchical.cpp:762] Agent f6cd7687-8b8e-4988-83eb-d0497d62beb0-S0 deactivated
I1211 21:30:06.588074 7696 launcher.cpp:156] Asked to destroy container 3621328b-57ba-43cb-805e-6566f7663ad9
I1211 21:30:06.675117 7568 containerizer.cpp:2779] Container 3621328b-57ba-43cb-805e-6566f7663ad9 has exited
I1211 21:30:06.703598 1856 master.cpp:1152] Master terminating
I1211 21:30:06.705597 7568 hierarchical.cpp:605] Removed agent f6cd7687-8b8e-4988-83eb-d0497d62beb0-S0
I1211 21:30:07.018635 4032 process.cpp:887] Failed to accept socket: future discarded
```
- Mesos Reviewbot Windows
On Dec. 11, 2017, 10:31 a.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64431/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2017, 10:31 a.m.)
>
>
> Review request for mesos, Akash Gupta, Greg Mann, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed outdated notes about administrative privileges being necessary
> due to symlinks, which was resovled in MESOS-7370. Added note about
> minimum supported Windows versions, including caveat that it will likely
> increase.
>
> Moved the Java and OpenSSL build examples from `cmake-examples.md` to
> `windows.md`, with additional note that the Java build is only for unit
> tests (to clarify that the `master` is not yet supported on Windows).
>
> Updated latest tested version of OpenSSL, and added note about dynamic
> linking and lack of bundled certificates.
>
>
> Diffs
> -----
>
> docs/cmake-examples.md e3149bfd4b197059ee56bbb9e5c9926494c22572
> docs/windows.md 6b6a74233ce047f4efa37e2f6415d089668ace0d
>
>
> Diff: https://reviews.apache.org/r/64431/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 64431: Updated Windows documentation.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64431/#review193457
-----------------------------------------------------------
Ship it!
Ship It!
- Greg Mann
On Dec. 11, 2017, 6:31 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64431/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2017, 6:31 p.m.)
>
>
> Review request for mesos, Akash Gupta, Greg Mann, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed outdated notes about administrative privileges being necessary
> due to symlinks, which was resovled in MESOS-7370. Added note about
> minimum supported Windows versions, including caveat that it will likely
> increase.
>
> Moved the Java and OpenSSL build examples from `cmake-examples.md` to
> `windows.md`, with additional note that the Java build is only for unit
> tests (to clarify that the `master` is not yet supported on Windows).
>
> Updated latest tested version of OpenSSL, and added note about dynamic
> linking and lack of bundled certificates.
>
>
> Diffs
> -----
>
> docs/cmake-examples.md e3149bfd4b197059ee56bbb9e5c9926494c22572
> docs/windows.md 6b6a74233ce047f4efa37e2f6415d089668ace0d
>
>
> Diff: https://reviews.apache.org/r/64431/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 64431: Updated Windows documentation.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64431/
-----------------------------------------------------------
(Updated Dec. 11, 2017, 10:31 a.m.)
Review request for mesos, Akash Gupta, Greg Mann, and Joseph Wu.
Changes
-------
Correct name of Windows Server, add link and version/build specifics.
Repository: mesos
Description
-------
Removed outdated notes about administrative privileges being necessary
due to symlinks, which was resovled in MESOS-7370. Added note about
minimum supported Windows versions, including caveat that it will likely
increase.
Moved the Java and OpenSSL build examples from `cmake-examples.md` to
`windows.md`, with additional note that the Java build is only for unit
tests (to clarify that the `master` is not yet supported on Windows).
Updated latest tested version of OpenSSL, and added note about dynamic
linking and lack of bundled certificates.
Diffs (updated)
-----
docs/cmake-examples.md e3149bfd4b197059ee56bbb9e5c9926494c22572
docs/windows.md 6b6a74233ce047f4efa37e2f6415d089668ace0d
Diff: https://reviews.apache.org/r/64431/diff/2/
Changes: https://reviews.apache.org/r/64431/diff/1-2/
Testing
-------
Thanks,
Andrew Schwartzmeyer
Re: Review Request 64431: Updated Windows documentation.
Posted by Akash Gupta <ak...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64431/#review193301
-----------------------------------------------------------
Fix it, then Ship it!
docs/windows.md
Lines 73 (patched)
<https://reviews.apache.org/r/64431/#comment271863>
Nit, but I think the actual name is Windows Server, Version 1709. I don't see the "2016" part here: https://docs.microsoft.com/en-us/windows-server/get-started/get-started-with-1709
- Akash Gupta
On Dec. 8, 2017, 12:09 a.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64431/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2017, 12:09 a.m.)
>
>
> Review request for mesos, Akash Gupta, Greg Mann, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed outdated notes about administrative privileges being necessary
> due to symlinks, which was resovled in MESOS-7370. Added note about
> minimum supported Windows versions, including caveat that it will likely
> increase.
>
> Moved the Java and OpenSSL build examples from `cmake-examples.md` to
> `windows.md`, with additional note that the Java build is only for unit
> tests (to clarify that the `master` is not yet supported on Windows).
>
> Updated latest tested version of OpenSSL, and added note about dynamic
> linking and lack of bundled certificates.
>
>
> Diffs
> -----
>
> docs/cmake-examples.md e3149bfd4b197059ee56bbb9e5c9926494c22572
> docs/windows.md 6b6a74233ce047f4efa37e2f6415d089668ace0d
>
>
> Diff: https://reviews.apache.org/r/64431/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>