You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/06/21 03:22:28 UTC
[GitHub] [dolphinscheduler] hstdream opened a new pull request, #10521: [Bug][docs] Complement add docs.
hstdream opened a new pull request, #10521:
URL: https://github.com/apache/dolphinscheduler/pull/10521
#10520
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] Tianqi-Dotes commented on a diff in pull request #10521: [Bug][docs] Complement add docs.
Posted by GitBox <gi...@apache.org>.
Tianqi-Dotes commented on code in PR #10521:
URL: https://github.com/apache/dolphinscheduler/pull/10521#discussion_r902719729
##########
docs/docs/en/guide/project/workflow-definition.md:
##########
@@ -79,9 +79,17 @@ The following are the operation functions of the workflow definition list:
Review Comment:
Hi, need to change the definition of 'Complement' at line 77 according to the CN version changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] Tianqi-Dotes commented on a diff in pull request #10521: [Bug][docs] Complement add docs.
Posted by GitBox <gi...@apache.org>.
Tianqi-Dotes commented on code in PR #10521:
URL: https://github.com/apache/dolphinscheduler/pull/10521#discussion_r903236027
##########
docs/docs/zh/guide/project/workflow-definition.md:
##########
@@ -75,14 +75,22 @@
* 收件人：选择通知策略||超时报警||发生容错时，会发送流程信息或告警邮件到收件人列表。
* 抄送人：选择通知策略||超时报警||发生容错时，会抄送流程信息或告警邮件到抄送人列表。
* 启动参数: 在启动新的流程实例时，设置或覆盖全局参数的值。
- * 补数：包括串行补数、并行补数 2 种模式。串行补数：指定时间范围内，从开始日期至结束日期依次执行补数，依次生成N条流程实例；并行补数：指定时间范围内，多天同时进行补数，同时生成 N 条流程实例。
+ * 补数：包括日期选择和手动输入 2 种方式，其中每种方式包括串行补数、并行补数 2 种模式。日期选择的方式，串行补数：指定时间范围内，从开始日期至结束日期依次执行补数，依次生成N条流程实例；并行补数：指定时间范围内，多天同时进行补数，同时生成 N 条流程实例。手动输入的方式，串行补数：手动输入以逗号分割日期格式为`yyyy-MM-dd HH:mm:ss`的日期，依次生成N条流程实例；并行补数：手动输入以逗号分割日期格式为`yyyy-MM-dd HH:mm:ss`的日期，多天同时进行补数，同时生成 N 条流程实例。
* 补数： 执行指定日期的工作流定义，可以选择补数时间范围（当定时配置未上线时默认会根据所选时间范围进行每天一次的补数，如果定时配置已上线则会根据所选的时间范围结合定时配置进行补数)，比如需要补 5 月 9 号到 5 月 10 号的数据，如下图所示：
- > 串行模式：补数从 5 月 9 号到 5 月 10 号依次执行，依次在流程实例页面生成十条流程实例；
+ > 串行模式：补数从 5 月 9 号到 5 月 10 号依次执行，依次在流程实例页面生成两条流程实例；
- > 并行模式：同时执行 5 月 9 号到 5 月 10 号的任务，同时在流程实例页面生成十条流程实例。
+ > 并行模式：同时执行 5 月 9 号到 5 月 10 号的任务，同时在流程实例页面生成两条流程实例。
+
+ * 补数： 执行手动输入日期的工作流定义，可以手动输入补数时间（不依赖定时配置)，比如需要补 5 月 9 号到 5 月 10 号的数据，如下图所示：
Review Comment:
* 补数： 通过手动输入补数时间（不依赖定时配置)完成工作流定义的补数。比如需要补 5 月 9 号到 5 月 10 号的数据，如下图所示：
##########
docs/docs/en/guide/project/workflow-definition.md:
##########
@@ -74,14 +74,22 @@ The following are the operation functions of the workflow definition list:
* Recipient: select notification policy||timeout alarm||when fault tolerance occurs, process result information or alarm email will be sent to the recipient list
* Cc: select notification policy||timeout alarm||when fault tolerance occurs, the process result information or warning email will be copied to the CC list
* Startup parameter: Set or overwrite global parameter values when starting a new process instance
- * Complement: two modes including serial complement and parallel complement. Serial complement: within the specified time range, the complements are executed from the start date to the end date and N process instances are generated in turn; parallel complement: within the specified time range, multiple days are complemented at the same time to generate N process instances.
+ * Complement: two modes including serial complement and parallel complement. Serial complement: within the specified time range, the complements are executed from the start date to the end date and N process instances are generated in turn; parallel complement: within the specified time range, multiple days are complemented at the same time to generate N process instances. Manual input, serial complement: manually enter the date in comma separated date format as `yyyy-MM-dd HH:mm:ss`, and generate n process instances in turn; Parallel Replenishment: manually enter a date in the comma separated date format of `yyyy-MM-dd HH:mm:ss`. Complement data simultaneously for multiple days and generate N process instances at the same time.
Review Comment:
* Complement: use date selection or manual input to make complement, and each of these methods contains serial complement and parallel complement. Serial complement defines, within the specified time range, executes the complements from the start date to the end date by sequential and N process instances are generated in sequence. Parallel complement defines executing the complement concurrently in the multiple days to generate N process instances within the specified time range. Manual date input defines: manually input the date following the date format `yyyy-MM-dd HH:mm:ss` and separate dates by a comma. Date selection defines: to select dates via UI.
##########
docs/docs/en/guide/project/workflow-definition.md:
##########
@@ -74,14 +74,22 @@ The following are the operation functions of the workflow definition list:
* Recipient: select notification policy||timeout alarm||when fault tolerance occurs, process result information or alarm email will be sent to the recipient list
* Cc: select notification policy||timeout alarm||when fault tolerance occurs, the process result information or warning email will be copied to the CC list
* Startup parameter: Set or overwrite global parameter values when starting a new process instance
- * Complement: two modes including serial complement and parallel complement. Serial complement: within the specified time range, the complements are executed from the start date to the end date and N process instances are generated in turn; parallel complement: within the specified time range, multiple days are complemented at the same time to generate N process instances.
+ * Complement: two modes including serial complement and parallel complement. Serial complement: within the specified time range, the complements are executed from the start date to the end date and N process instances are generated in turn; parallel complement: within the specified time range, multiple days are complemented at the same time to generate N process instances. Manual input, serial complement: manually enter the date in comma separated date format as `yyyy-MM-dd HH:mm:ss`, and generate n process instances in turn; Parallel Replenishment: manually enter a date in the comma separated date format of `yyyy-MM-dd HH:mm:ss`. Complement data simultaneously for multiple days and generate N process instances at the same time.
* You can select complement time range (When the scheduled configuration is not online, the daily complement will be performed by default according to the selected time range.If the timing configuration is online, it will be complemented according to the selected time range in combination with the timing configuration) when executing a timing workflow definition. For example, need to fill in the data from 1st May to 10th May, as shown in the figure below:
- > Serial mode: the complement execute sequentially from 9th May to 10th May, and the process instance page generates 10 process instances;
+ > Serial mode: the complement execute sequentially from 9th May to 10th May, and the process instance page generates 2 process instances;
- > Parallel mode: The tasks from 9th May to 10th May execute simultaneously, and the process instance page generates 10 process instances;
+ > Parallel mode: The tasks from 9th May to 10th May execute simultaneously, and the process instance page generates 2 process instances;
+
+ * You can manually enter the makeup time (independent of the timing configuration) execute the workflow definition of manually entering the date. For example, need to fill in the data from 1st May to 10th May, as shown in the figure below:
Review Comment:
* You can manually enter the complement dates (independent from the timing configuration) to execute the complement data to workflow definitions. The figure below is an example to make complement data from 1st May to 10th May:
##########
docs/docs/zh/guide/project/workflow-definition.md:
##########
@@ -75,14 +75,22 @@
* 收件人：选择通知策略||超时报警||发生容错时，会发送流程信息或告警邮件到收件人列表。
* 抄送人：选择通知策略||超时报警||发生容错时，会抄送流程信息或告警邮件到抄送人列表。
* 启动参数: 在启动新的流程实例时，设置或覆盖全局参数的值。
- * 补数：包括串行补数、并行补数 2 种模式。串行补数：指定时间范围内，从开始日期至结束日期依次执行补数，依次生成N条流程实例；并行补数：指定时间范围内，多天同时进行补数，同时生成 N 条流程实例。
+ * 补数：包括日期选择和手动输入 2 种方式，其中每种方式包括串行补数、并行补数 2 种模式。日期选择的方式，串行补数：指定时间范围内，从开始日期至结束日期依次执行补数，依次生成N条流程实例；并行补数：指定时间范围内，多天同时进行补数，同时生成 N 条流程实例。手动输入的方式，串行补数：手动输入以逗号分割日期格式为`yyyy-MM-dd HH:mm:ss`的日期，依次生成N条流程实例；并行补数：手动输入以逗号分割日期格式为`yyyy-MM-dd HH:mm:ss`的日期，多天同时进行补数，同时生成 N 条流程实例。
Review Comment:
* 补数：包括日期选择和手动输入 2 种方式，其中每种方式包括串行补数、并行补数 2 种模式。日期选择的方式，串行补数：指定时间范围内，从开始日期至结束日期依次执行补数，依次生成N条流程实例；并行补数：指定时间范围内，多天同时进行补数，同时生成 N 条流程实例。手动输入的方式，串行补数：手动输入以逗号分割日期格式为`yyyy-MM-dd HH:mm:ss`的日期，依次生成N条流程实例；并行补数：手动输入以逗号分割日期格式为`yyyy-MM-dd HH:mm:ss`的日期，多天同时进行补数，同时生成 N 条流程实例。
* 补数：包括串行补数、并行补数 2 种模式，日期可以通过选择或者手动进行输入。串行补数：指定时间范围内，从开始日期至结束日期依次执行补数，依次生成N条流程实例；并行补数：指定时间范围内，多天同时进行补数，同时生成 N 条流程实例。手动输入日期：手动输入以逗号分割日期格式为`yyyy-MM-dd HH:mm:ss`的日期。日期选择：通过前端选择日期。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] Tianqi-Dotes commented on a diff in pull request #10521: [Bug][docs] Complement add docs.
Posted by GitBox <gi...@apache.org>.
Tianqi-Dotes commented on code in PR #10521:
URL: https://github.com/apache/dolphinscheduler/pull/10521#discussion_r902771167
##########
docs/docs/en/guide/project/workflow-definition.md:
##########
@@ -74,14 +74,22 @@ The following are the operation functions of the workflow definition list:
* Recipient: select notification policy||timeout alarm||when fault tolerance occurs, process result information or alarm email will be sent to the recipient list
* Cc: select notification policy||timeout alarm||when fault tolerance occurs, the process result information or warning email will be copied to the CC list
* Startup parameter: Set or overwrite global parameter values when starting a new process instance
- * Complement: two modes including serial complement and parallel complement. Serial complement: within the specified time range, the complements are executed from the start date to the end date and N process instances are generated in turn; parallel complement: within the specified time range, multiple days are complemented at the same time to generate N process instances.
+ * Complement: two modes including serial complement and parallel complement. Serial complement: within the specified time range, the complements are executed from the start date to the end date and N process instances are generated in turn; parallel complement: within the specified time range, multiple days are complemented at the same time to generate N process instances.Manual input, serial complement: manually enter the date in comma separated date format as `yyyy-MM-dd HH:mm:ss`, and generate n process instances in turn; Parallel Replenishment: manually enter a date in the comma separated date format of `yyyy-MM-dd HH:mm:ss`. Replenishment is performed for multiple days and n process instances are generated at the same time.
Review Comment:
add blanket before 'Manual input,'
##########
docs/docs/en/guide/project/workflow-definition.md:
##########
@@ -74,14 +74,22 @@ The following are the operation functions of the workflow definition list:
* Recipient: select notification policy||timeout alarm||when fault tolerance occurs, process result information or alarm email will be sent to the recipient list
* Cc: select notification policy||timeout alarm||when fault tolerance occurs, the process result information or warning email will be copied to the CC list
* Startup parameter: Set or overwrite global parameter values when starting a new process instance
- * Complement: two modes including serial complement and parallel complement. Serial complement: within the specified time range, the complements are executed from the start date to the end date and N process instances are generated in turn; parallel complement: within the specified time range, multiple days are complemented at the same time to generate N process instances.
+ * Complement: two modes including serial complement and parallel complement. Serial complement: within the specified time range, the complements are executed from the start date to the end date and N process instances are generated in turn; parallel complement: within the specified time range, multiple days are complemented at the same time to generate N process instances.Manual input, serial complement: manually enter the date in comma separated date format as `yyyy-MM-dd HH:mm:ss`, and generate n process instances in turn; Parallel Replenishment: manually enter a date in the comma separated date format of `yyyy-MM-dd HH:mm:ss`. Replenishment is performed for multiple days and n process instances are generated at the same time.
Review Comment:
please use consist word 'complement' instead of 'Replenishment'
and avoid use passive pattern
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] hstdream commented on a diff in pull request #10521: [Bug][docs] Complement add docs.
Posted by GitBox <gi...@apache.org>.
hstdream commented on code in PR #10521:
URL: https://github.com/apache/dolphinscheduler/pull/10521#discussion_r903222660
##########
docs/docs/en/guide/project/workflow-definition.md:
##########
@@ -74,14 +74,22 @@ The following are the operation functions of the workflow definition list:
* Recipient: select notification policy||timeout alarm||when fault tolerance occurs, process result information or alarm email will be sent to the recipient list
* Cc: select notification policy||timeout alarm||when fault tolerance occurs, the process result information or warning email will be copied to the CC list
* Startup parameter: Set or overwrite global parameter values when starting a new process instance
- * Complement: two modes including serial complement and parallel complement. Serial complement: within the specified time range, the complements are executed from the start date to the end date and N process instances are generated in turn; parallel complement: within the specified time range, multiple days are complemented at the same time to generate N process instances.
+ * Complement: two modes including serial complement and parallel complement. Serial complement: within the specified time range, the complements are executed from the start date to the end date and N process instances are generated in turn; parallel complement: within the specified time range, multiple days are complemented at the same time to generate N process instances.Manual input, serial complement: manually enter the date in comma separated date format as `yyyy-MM-dd HH:mm:ss`, and generate n process instances in turn; Parallel Replenishment: manually enter a date in the comma separated date format of `yyyy-MM-dd HH:mm:ss`. Replenishment is performed for multiple days and n process instances are generated at the same time.
Review Comment:
ok,modified
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on pull request #10521: [Bug][docs] Complement add docs.
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on PR #10521:
URL: https://github.com/apache/dolphinscheduler/pull/10521#issuecomment-1163899971
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie merged pull request #10521: [Bug][docs] Complement add docs.
Posted by GitBox <gi...@apache.org>.
zhongjiajie merged PR #10521:
URL: https://github.com/apache/dolphinscheduler/pull/10521
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] Tianqi-Dotes commented on a diff in pull request #10521: [Bug][docs] Complement add docs.
Posted by GitBox <gi...@apache.org>.
Tianqi-Dotes commented on code in PR #10521:
URL: https://github.com/apache/dolphinscheduler/pull/10521#discussion_r903233860
##########
docs/docs/en/guide/project/workflow-definition.md:
##########
@@ -74,14 +74,22 @@ The following are the operation functions of the workflow definition list:
* Recipient: select notification policy||timeout alarm||when fault tolerance occurs, process result information or alarm email will be sent to the recipient list
* Cc: select notification policy||timeout alarm||when fault tolerance occurs, the process result information or warning email will be copied to the CC list
* Startup parameter: Set or overwrite global parameter values when starting a new process instance
- * Complement: two modes including serial complement and parallel complement. Serial complement: within the specified time range, the complements are executed from the start date to the end date and N process instances are generated in turn; parallel complement: within the specified time range, multiple days are complemented at the same time to generate N process instances.
+ * Complement: two modes including serial complement and parallel complement. Serial complement: within the specified time range, the complements are executed from the start date to the end date and N process instances are generated in turn; parallel complement: within the specified time range, multiple days are complemented at the same time to generate N process instances. Manual input, serial complement: manually enter the date in comma separated date format as `yyyy-MM-dd HH:mm:ss`, and generate n process instances in turn; Parallel Replenishment: manually enter a date in the comma separated date format of `yyyy-MM-dd HH:mm:ss`. Complement data simultaneously for multiple days and generate N process instances at the same time.
Review Comment:
* Complement: includes serial complement and parallel complement and supports manual date input and date selection. Serial complement defines, within the specified time range, executes the complements from the start date to the end date by sequential and N process instances are generated in sequence. Parallel complement defines executing the complement concurrently in the multiple days to generate N process instances within the specified time range. Manual date input defines: manually input the date following the date format `yyyy-MM-dd HH:mm:ss` and separate dates by a comma. Date selection defines: to select dates via UI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on pull request #10521: [Bug][docs] Complement add docs.
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on PR #10521:
URL: https://github.com/apache/dolphinscheduler/pull/10521#issuecomment-1163903788
related PR #10376
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on a diff in pull request #10521: [Bug][docs] Complement add docs.
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on code in PR #10521:
URL: https://github.com/apache/dolphinscheduler/pull/10521#discussion_r902137824
##########
docs/docs/en/guide/project/workflow-definition.md:
##########
@@ -81,6 +81,14 @@ The following are the operation functions of the workflow definition list:
> Serial mode: the complement execute sequentially from 9th May to 10th May, and the process instance page generates 10 process instances;
+ > Parallel mode: The tasks from 9th May to 10th May execute simultaneously, and the process instance page generates 10 process instances;
+
+ * You can manually enter the makeup time (independent of the timing configuration) execute the workflow definition of manually entering the date. For example, need to fill in the data from 1st May to 10th May, as shown in the figure below:
+
+ 
+
+ > Serial mode: the complement execute sequentially from 9th May to 10th May, and the process instance page generates 10 process instances;
Review Comment:
why is ten process instance instead of two? maybe we have to add some preconditions or change `9th Ma`y to `1th May`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] hstdream commented on a diff in pull request #10521: [Bug][docs] Complement add docs.
Posted by GitBox <gi...@apache.org>.
hstdream commented on code in PR #10521:
URL: https://github.com/apache/dolphinscheduler/pull/10521#discussion_r902142402
##########
docs/docs/en/guide/project/workflow-definition.md:
##########
@@ -81,6 +81,14 @@ The following are the operation functions of the workflow definition list:
> Serial mode: the complement execute sequentially from 9th May to 10th May, and the process instance page generates 10 process instances;
+ > Parallel mode: The tasks from 9th May to 10th May execute simultaneously, and the process instance page generates 10 process instances;
+
+ * You can manually enter the makeup time (independent of the timing configuration) execute the workflow definition of manually entering the date. For example, need to fill in the data from 1st May to 10th May, as shown in the figure below:
+
+ 
+
+ > Serial mode: the complement execute sequentially from 9th May to 10th May, and the process instance page generates 10 process instances;
Review Comment:
ok,modified
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] hstdream commented on a diff in pull request #10521: [Bug][docs] Complement add docs.
Posted by GitBox <gi...@apache.org>.
hstdream commented on code in PR #10521:
URL: https://github.com/apache/dolphinscheduler/pull/10521#discussion_r902727276
##########
docs/docs/en/guide/project/workflow-definition.md:
##########
@@ -79,9 +79,17 @@ The following are the operation functions of the workflow definition list:
Review Comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org