[GitHub] [spark] senthh commented on a change in pull request #33894: [SPARK-36643][SQL] Add more information in ERROR log while SparkConf is modified when spark.sql.legacy.setCommandRejectsSparkCoreConfs is set

[GitBox <gi...@apache.org>]

senthh commented on a change in pull request #33894:
URL: https://github.com/apache/spark/pull/33894#discussion_r700888243



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala
##########
@@ -2333,7 +2333,12 @@ object QueryCompilationErrors {
   }
 
   def cannotModifyValueOfSparkConfigError(key: String): Throwable = {
-    new AnalysisException(s"Cannot modify the value of a Spark config: $key")
+    new AnalysisException(
+      s"""
+      |Cannot modify the value of a Spark config: $key,
+      |please set spark.sql.legacy.setCommandRejectsSparkCoreConfs as 'false' in
+      |order to make change value of Spark config: $key .

Review comment:
       @HyukjinKwon @dongjoon-hyun  Thanks for reviewing this PR. Yes I got. But until we remove sql legacy configurations. This additional info in ERROR message will be helpful for the users to fix the issue quickly( otherwise they need to find the doc and then resolve this issue while modifying  the value of SparkConf.)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org