You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "xiangfu0 (via GitHub)" <gi...@apache.org> on 2023/08/15 07:58:47 UTC
[GitHub] [pinot] xiangfu0 opened a new pull request, #11351: Adding vector search example into pinot
xiangfu0 opened a new pull request, #11351:
URL: https://github.com/apache/pinot/pull/11351
Adding a new vector search related data set: fine food reviews with 1000 rows, the embeddings are generated using OpenAI APIs, following this doc: (https://github.com/openai/openai-cookbook/blob/main/examples/Obtain_dataset.ipynb)
The embedding has 1536 floats.
The test query is directly using a vector with summary of tomato soup.
Below is a sample query and response.
<img width="1367" alt="image" src="https://github.com/apache/pinot/assets/1202120/7b28ac58-802a-46ab-985e-a2e496a11626">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] xiangfu0 merged pull request #11351: Adding vector search example into QuickStart
Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 merged PR #11351:
URL: https://github.com/apache/pinot/pull/11351
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter commented on pull request #11351: Adding vector search example into QuickStart
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #11351:
URL: https://github.com/apache/pinot/pull/11351#issuecomment-1678599713
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11351?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#11351](https://app.codecov.io/gh/apache/pinot/pull/11351?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (d685190) into [master](https://app.codecov.io/gh/apache/pinot/commit/f25f3ed1f242513b90207d082fb80dbfdc9b06f6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (f25f3ed) will **decrease** coverage by `53.82%`.
> Report is 4 commits behind head on master.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #11351 +/- ##
=============================================
- Coverage 68.46% 14.65% -53.82%
+ Complexity 6535 494 -6041
=============================================
Files 2233 2159 -74
Lines 119952 116826 -3126
Branches 18191 17747 -444
=============================================
- Hits 82128 17116 -65012
- Misses 31984 98296 +66312
+ Partials 5840 1414 -4426
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1 | `?` | |
| integration2 | `?` | |
| java-11 | `14.65% <ø> (-53.77%)` | :arrow_down: |
| java-17 | `?` | |
| java-20 | `?` | |
| temurin | `14.65% <ø> (-53.82%)` | :arrow_down: |
| unittests1 | `?` | |
| unittests2 | `14.65% <ø> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1710 files with indirect coverage changes](https://app.codecov.io/gh/apache/pinot/pull/11351/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #11351: Adding vector search example into QuickStart
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on code in PR #11351:
URL: https://github.com/apache/pinot/pull/11351#discussion_r1295050355
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/ArrayLiteralTransformFunction.java:
##########
@@ -218,7 +218,33 @@ public int[][] transformToIntValuesMV(ValueBlock valueBlock) {
int[][] intArrayResult = _intArrayResult;
if (intArrayResult == null || intArrayResult.length < numDocs) {
intArrayResult = new int[numDocs][];
- Arrays.fill(intArrayResult, _intArrayLiteral);
+ if (_intArrayLiteral != null) {
Review Comment:
We want to set `_intArrayLiteral` only once, same for other places
```suggestion
if (_intArrayLiteral == null) {
switch (_dataType) {
case LONG:
...
}
}
Arrays.fill(intArrayResult, _intArrayLiteral);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org