You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Alex Rodoni (Code Review)" <ge...@cloudera.org> on 2019/12/05 21:27:45 UTC
[Impala-ASF-CR] [DOCS] Update impala proxy.xml with the latest info
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14857
Change subject: [DOCS] Update impala_proxy.xml with the latest info
......................................................................
[DOCS] Update impala_proxy.xml with the latest info
Change-Id: Ia9d80e21abb385704eea863d221e333441af9a39
---
M docs/topics/impala_jdbc.xml
M docs/topics/impala_proxy.xml
2 files changed, 240 insertions(+), 344 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/57/14857/1
--
To view, visit http://gerrit.cloudera.org:8080/14857
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia9d80e21abb385704eea863d221e333441af9a39
Gerrit-Change-Number: 14857
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
[Impala-ASF-CR] [DOCS] Update impala proxy.xml with the latest info
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/14857 )
Change subject: [DOCS] Update impala_proxy.xml with the latest info
......................................................................
Patch Set 2:
Can someone give +2?
--
To view, visit http://gerrit.cloudera.org:8080/14857
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9d80e21abb385704eea863d221e333441af9a39
Gerrit-Change-Number: 14857
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Balazs Jeszenszky <je...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vincent Tran <vt...@cloudera.com>
Gerrit-Comment-Date: Tue, 10 Dec 2019 19:21:11 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Update impala proxy.xml with the latest info
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14857 )
Change subject: [DOCS] Update impala_proxy.xml with the latest info
......................................................................
Patch Set 2:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/551/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/14857
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9d80e21abb385704eea863d221e333441af9a39
Gerrit-Change-Number: 14857
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Balazs Jeszenszky <je...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vincent Tran <vt...@cloudera.com>
Gerrit-Comment-Date: Fri, 06 Dec 2019 22:04:02 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Update impala proxy.xml with the latest info
Posted by "Vincent Tran (Code Review)" <ge...@cloudera.org>.
Vincent Tran has posted comments on this change. ( http://gerrit.cloudera.org:8080/14857 )
Change subject: [DOCS] Update impala_proxy.xml with the latest info
......................................................................
Patch Set 1:
(5 comments)
Looks sane overall. I added a few comments.
http://gerrit.cloudera.org:8080/#/c/14857/1/docs/topics/impala_jdbc.xml
File docs/topics/impala_jdbc.xml:
http://gerrit.cloudera.org:8080/#/c/14857/1/docs/topics/impala_jdbc.xml@99
PS1, Line 99: Hive 0.13 JDBC driver
Does it need to be this specific version?
http://gerrit.cloudera.org:8080/#/c/14857/1/docs/topics/impala_jdbc.xml@120
PS1, Line 120: Java JAR f
I think "JAR/jar files" is concise enough.
http://gerrit.cloudera.org:8080/#/c/14857/1/docs/topics/impala_jdbc.xml@126
PS1, Line 126: The latest JDBC driver, corresponding to Hive 0.13,
Is this still true?
http://gerrit.cloudera.org:8080/#/c/14857/1/docs/topics/impala_proxy.xml
File docs/topics/impala_proxy.xml:
http://gerrit.cloudera.org:8080/#/c/14857/1/docs/topics/impala_proxy.xml@108
PS1, Line 108: Pick a host other than where <cmdname>impalad</cmdname> is
: running.
I don't think this is necessarily a requirement.
http://gerrit.cloudera.org:8080/#/c/14857/1/docs/topics/impala_proxy.xml@281
PS1, Line 281: start-up option
"start-up option" can be understandably mistaken for Impala Daemon process startup options.
How about just "impala-shell client flag/option"?
--
To view, visit http://gerrit.cloudera.org:8080/14857
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9d80e21abb385704eea863d221e333441af9a39
Gerrit-Change-Number: 14857
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Balazs Jeszenszky <je...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vincent Tran <vt...@cloudera.com>
Gerrit-Comment-Date: Fri, 06 Dec 2019 19:44:02 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] [DOCS] Update impala proxy.xml with the latest info
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14857 )
Change subject: [DOCS] Update impala_proxy.xml with the latest info
......................................................................
[DOCS] Update impala_proxy.xml with the latest info
Change-Id: Ia9d80e21abb385704eea863d221e333441af9a39
Reviewed-on: http://gerrit.cloudera.org:8080/14857
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Balazs Jeszenszky <je...@gmail.com>
Reviewed-by: Vincent Tran <vt...@cloudera.com>
Reviewed-by: Alex Rodoni <ar...@cloudera.com>
---
M docs/topics/impala_jdbc.xml
M docs/topics/impala_proxy.xml
2 files changed, 240 insertions(+), 348 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Balazs Jeszenszky: Looks good to me, but someone else must approve
Vincent Tran: Looks good to me, but someone else must approve
Alex Rodoni: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/14857
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia9d80e21abb385704eea863d221e333441af9a39
Gerrit-Change-Number: 14857
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Balazs Jeszenszky <je...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vincent Tran <vt...@cloudera.com>
[Impala-ASF-CR] [DOCS] Update impala proxy.xml with the latest info
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Vincent Tran, Balazs Jeszenszky, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14857
to look at the new patch set (#2).
Change subject: [DOCS] Update impala_proxy.xml with the latest info
......................................................................
[DOCS] Update impala_proxy.xml with the latest info
Change-Id: Ia9d80e21abb385704eea863d221e333441af9a39
---
M docs/topics/impala_jdbc.xml
M docs/topics/impala_proxy.xml
2 files changed, 240 insertions(+), 348 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/57/14857/2
--
To view, visit http://gerrit.cloudera.org:8080/14857
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia9d80e21abb385704eea863d221e333441af9a39
Gerrit-Change-Number: 14857
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Balazs Jeszenszky <je...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vincent Tran <vt...@cloudera.com>
[Impala-ASF-CR] [DOCS] Update impala proxy.xml with the latest info
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14857 )
Change subject: [DOCS] Update impala_proxy.xml with the latest info
......................................................................
Patch Set 2: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/551/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/14857
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9d80e21abb385704eea863d221e333441af9a39
Gerrit-Change-Number: 14857
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Balazs Jeszenszky <je...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vincent Tran <vt...@cloudera.com>
Gerrit-Comment-Date: Fri, 06 Dec 2019 22:24:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Update impala proxy.xml with the latest info
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14857 )
Change subject: [DOCS] Update impala_proxy.xml with the latest info
......................................................................
Patch Set 1:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/545/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/14857
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9d80e21abb385704eea863d221e333441af9a39
Gerrit-Change-Number: 14857
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 05 Dec 2019 21:27:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Update impala proxy.xml with the latest info
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/14857 )
Change subject: [DOCS] Update impala_proxy.xml with the latest info
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14857
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9d80e21abb385704eea863d221e333441af9a39
Gerrit-Change-Number: 14857
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Balazs Jeszenszky <je...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vincent Tran <vt...@cloudera.com>
Gerrit-Comment-Date: Tue, 10 Dec 2019 22:17:17 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Update impala proxy.xml with the latest info
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/14857 )
Change subject: [DOCS] Update impala_proxy.xml with the latest info
......................................................................
Patch Set 1:
Let me know if you want me to create a google doc for easier readability
--
To view, visit http://gerrit.cloudera.org:8080/14857
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9d80e21abb385704eea863d221e333441af9a39
Gerrit-Change-Number: 14857
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Balazs Jeszenszky <je...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vincent Tran <vt...@cloudera.com>
Gerrit-Comment-Date: Fri, 06 Dec 2019 19:05:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Update impala proxy.xml with the latest info
Posted by "Vincent Tran (Code Review)" <ge...@cloudera.org>.
Vincent Tran has posted comments on this change. ( http://gerrit.cloudera.org:8080/14857 )
Change subject: [DOCS] Update impala_proxy.xml with the latest info
......................................................................
Patch Set 2: Code-Review+1
LGTM. But I can't +2.
--
To view, visit http://gerrit.cloudera.org:8080/14857
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9d80e21abb385704eea863d221e333441af9a39
Gerrit-Change-Number: 14857
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Balazs Jeszenszky <je...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vincent Tran <vt...@cloudera.com>
Gerrit-Comment-Date: Tue, 10 Dec 2019 19:29:07 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Update impala proxy.xml with the latest info
Posted by "Balazs Jeszenszky (Code Review)" <ge...@cloudera.org>.
Balazs Jeszenszky has posted comments on this change. ( http://gerrit.cloudera.org:8080/14857 )
Change subject: [DOCS] Update impala_proxy.xml with the latest info
......................................................................
Patch Set 2: Code-Review+1
LGTM, thanks!
--
To view, visit http://gerrit.cloudera.org:8080/14857
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9d80e21abb385704eea863d221e333441af9a39
Gerrit-Change-Number: 14857
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Balazs Jeszenszky <je...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vincent Tran <vt...@cloudera.com>
Gerrit-Comment-Date: Tue, 10 Dec 2019 13:48:01 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Update impala proxy.xml with the latest info
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/14857 )
Change subject: [DOCS] Update impala_proxy.xml with the latest info
......................................................................
Patch Set 1:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/14857/1/docs/topics/impala_jdbc.xml
File docs/topics/impala_jdbc.xml:
http://gerrit.cloudera.org:8080/#/c/14857/1/docs/topics/impala_jdbc.xml@99
PS1, Line 99: Hive 0.13 JDBC driver
> Does it need to be this specific version?
Done
http://gerrit.cloudera.org:8080/#/c/14857/1/docs/topics/impala_jdbc.xml@120
PS1, Line 120: Java JAR f
> I think "JAR/jar files" is concise enough.
Done
http://gerrit.cloudera.org:8080/#/c/14857/1/docs/topics/impala_jdbc.xml@126
PS1, Line 126: The latest JDBC driver, corresponding to Hive 0.13,
> Is this still true?
yes
http://gerrit.cloudera.org:8080/#/c/14857/1/docs/topics/impala_proxy.xml
File docs/topics/impala_proxy.xml:
http://gerrit.cloudera.org:8080/#/c/14857/1/docs/topics/impala_proxy.xml@108
PS1, Line 108: Pick a host other than where <cmdname>impalad</cmdname> is
: running.
> I don't think this is necessarily a requirement.
Done
http://gerrit.cloudera.org:8080/#/c/14857/1/docs/topics/impala_proxy.xml@281
PS1, Line 281: start-up option
> "start-up option" can be understandably mistaken for Impala Daemon process
Done
--
To view, visit http://gerrit.cloudera.org:8080/14857
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9d80e21abb385704eea863d221e333441af9a39
Gerrit-Change-Number: 14857
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Balazs Jeszenszky <je...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vincent Tran <vt...@cloudera.com>
Gerrit-Comment-Date: Fri, 06 Dec 2019 22:04:14 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] [DOCS] Update impala proxy.xml with the latest info
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14857 )
Change subject: [DOCS] Update impala_proxy.xml with the latest info
......................................................................
Patch Set 1: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/545/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/14857
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9d80e21abb385704eea863d221e333441af9a39
Gerrit-Change-Number: 14857
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Balazs Jeszenszky <je...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vincent Tran <vt...@cloudera.com>
Gerrit-Comment-Date: Thu, 05 Dec 2019 21:52:26 +0000
Gerrit-HasComments: No