You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2020/02/28 07:14:31 UTC
[GitHub] [openwhisk] markusthoemmes opened a new pull request #4844: Update
Kafka version to 2.4.0, make kafka related dependencies consistent.
markusthoemmes opened a new pull request #4844: Update Kafka version to 2.4.0, make kafka related dependencies consistent.
URL: https://github.com/apache/openwhisk/pull/4844
<!--- Provide a concise summary of your changes in the Title -->
## Description
The rabbit hole started with embeddedkafka only being available on Scala 2.13 at version 2.4.0.
1. Our Kafka clients and the used Kafka version doesn't match. That's not necessarily an issue but I think we should use matching versions unless we've seen issues there.
2. Updated akka-kafka to the latest and greatest.
## Related issue and scope
Ref #4741
## My changes affect the following components
<!--- Select below all system components are affected by your change. -->
<!--- Enter an `x` in all applicable boxes. -->
- [X] Message Bus (e.g., Kafka)
## Types of changes
<!--- What types of changes does your code introduce? Use `x` in all the boxes that apply: -->
- [X] Enhancement or new feature (adds new functionality).
## Checklist:
<!--- Please review the points below which help you make sure you've covered all aspects of the change you're making. -->
- [X] I signed an [Apache CLA](https://github.com/apache/openwhisk/blob/master/CONTRIBUTING.md).
- [X] I reviewed the [style guides](https://github.com/apache/openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :).
- [X] I added tests to cover my changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] markusthoemmes commented on issue #4844: Update Kafka
version to 2.4.0, make kafka related dependencies consistent.
Posted by GitBox <gi...@apache.org>.
markusthoemmes commented on issue #4844: Update Kafka version to 2.4.0, make kafka related dependencies consistent.
URL: https://github.com/apache/openwhisk/pull/4844#issuecomment-592429614
Okay, seems like one of the version updates changed behavior around maximum message size. I'll investigate that and potentially reduce the diff accordingly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] markusthoemmes merged pull request #4844: Update Kafka
version to 2.4.0, make kafka related dependencies consistent.
Posted by GitBox <gi...@apache.org>.
markusthoemmes merged pull request #4844: Update Kafka version to 2.4.0, make kafka related dependencies consistent.
URL: https://github.com/apache/openwhisk/pull/4844
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] markusthoemmes commented on issue #4844: Update Kafka
version to 2.4.0, make kafka related dependencies consistent.
Posted by GitBox <gi...@apache.org>.
markusthoemmes commented on issue #4844: Update Kafka version to 2.4.0, make kafka related dependencies consistent.
URL: https://github.com/apache/openwhisk/pull/4844#issuecomment-593489910
Thanks @dgrove-oss, that worked a charm.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] dgrove-oss edited a comment on issue #4844: Update
Kafka version to 2.4.0, make kafka related dependencies consistent.
Posted by GitBox <gi...@apache.org>.
dgrove-oss edited a comment on issue #4844: Update Kafka version to 2.4.0, make kafka related dependencies consistent.
URL: https://github.com/apache/openwhisk/pull/4844#issuecomment-592539417
I'd suggest leaving the kafka server at 2.X-2.3.1. The 2.4.0 client should work just fine with a 2.3.1 server.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] dgrove-oss commented on issue #4844: Update Kafka
version to 2.4.0, make kafka related dependencies consistent.
Posted by GitBox <gi...@apache.org>.
dgrove-oss commented on issue #4844: Update Kafka version to 2.4.0, make kafka related dependencies consistent.
URL: https://github.com/apache/openwhisk/pull/4844#issuecomment-592539417
I'd suggest leaving the kafka server at 2.12-2.3.1. The 2.4.0 client should work just fine with a 2.3.1 server.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services