You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/18 18:03:42 UTC
[GitHub] [spark] srowen commented on a change in pull request #27951:
[SPARK-30667][CORE] Change BarrierTaskContext allGather method return type
srowen commented on a change in pull request #27951: [SPARK-30667][CORE] Change BarrierTaskContext allGather method return type
URL: https://github.com/apache/spark/pull/27951#discussion_r394541766
##########
File path: core/src/main/scala/org/apache/spark/api/python/PythonRunner.scala
##########
@@ -420,7 +420,7 @@ private[spark] abstract class BasePythonRunner[IN, OUT](
context.asInstanceOf[BarrierTaskContext].barrier()
result = BarrierTaskContextMessageProtocol.BARRIER_RESULT_SUCCESS
case BarrierTaskContextMessageProtocol.ALL_GATHER_FUNCTION =>
- val messages: ArrayBuffer[String] = context.asInstanceOf[BarrierTaskContext].allGather(
+ val messages: Array[String] = context.asInstanceOf[BarrierTaskContext].allGather(
Review comment:
You probably don't even need these types here and below, but it won't matter
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org