You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/11/11 06:23:35 UTC
[GitHub] [shardingsphere] FlyingZC opened a new pull request, #22073: Fix serial flag judgment error within the transaction(#12052)
FlyingZC opened a new pull request, #22073:
URL: https://github.com/apache/shardingsphere/pull/22073
Fix serial flag judgment error within the transaction(#12052)
Fixes #12052.
Changes proposed in this pull request:
- Fix serial flag judgment error within the transaction
---
Before committing this PR, I'm sure that I have checked the following options:
- [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [x] I have self-reviewed the commit code.
- [x] I have (or in comment I request) added corresponding labels for the pull request.
- [x] I have passed maven check locally : `mvn clean install -B -T2C -DskipTests -Dmaven.javadoc.skip=true -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu merged pull request #22073: Fix serial flag judgment error within the transaction(#12052)
Posted by GitBox <gi...@apache.org>.
strongduanmu merged PR #22073:
URL: https://github.com/apache/shardingsphere/pull/22073
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] FlyingZC commented on pull request #22073: Fix serial flag judgment error within the transaction(#12052)
Posted by GitBox <gi...@apache.org>.
FlyingZC commented on PR #22073:
URL: https://github.com/apache/shardingsphere/pull/22073#issuecomment-1311466987
<img width="1029" alt="image" src="https://user-images.githubusercontent.com/19788130/201313190-be47f972-df36-4949-8af1-94acbe9e6476.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #22073: Fix serial flag judgment error within the transaction(#12052)
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #22073:
URL: https://github.com/apache/shardingsphere/pull/22073#issuecomment-1311482895
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/22073?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#22073](https://codecov.io/gh/apache/shardingsphere/pull/22073?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (01608f9) into [master](https://codecov.io/gh/apache/shardingsphere/commit/1fb8766851700ec17f2d4b2967a63bc42985288c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1fb8766) will **increase** coverage by `0.07%`.
> The diff coverage is `78.57%`.
```diff
@@ Coverage Diff @@
## master #22073 +/- ##
============================================
+ Coverage 61.01% 61.08% +0.07%
Complexity 2549 2549
============================================
Files 4109 4109
Lines 57300 57283 -17
Branches 9689 9682 -7
============================================
+ Hits 34961 34992 +31
+ Misses 19389 19339 -50
- Partials 2950 2952 +2
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/22073?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...a/executor/sql/execute/engine/raw/RawExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/22073/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvZXhlY3V0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL2V4ZWN1dG9yL3NxbC9leGVjdXRlL2VuZ2luZS9yYXcvUmF3RXhlY3V0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ackend/handler/distsql/rul/sql/PreviewHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/22073/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcnVsL3NxbC9QcmV2aWV3SGFuZGxlci5qYXZh) | `3.38% <0.00%> (-0.06%)` | :arrow_down: |
| [...r/sql/execute/engine/driver/jdbc/JDBCExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/22073/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvZXhlY3V0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL2V4ZWN1dG9yL3NxbC9leGVjdXRlL2VuZ2luZS9kcml2ZXIvamRiYy9KREJDRXhlY3V0b3IuamF2YQ==) | `40.00% <100.00%> (ø)` | |
| [...shardingsphere/driver/executor/DriverExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/22073/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-amRiYy9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kcml2ZXIvZXhlY3V0b3IvRHJpdmVyRXhlY3V0b3IuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ore/statement/ShardingSpherePreparedStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/22073/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-amRiYy9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kcml2ZXIvamRiYy9jb3JlL3N0YXRlbWVudC9TaGFyZGluZ1NwaGVyZVByZXBhcmVkU3RhdGVtZW50LmphdmE=) | `65.31% <100.00%> (ø)` | |
| [.../proxy/backend/communication/ProxySQLExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/22073/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb21tdW5pY2F0aW9uL1Byb3h5U1FMRXhlY3V0b3IuamF2YQ==) | `34.32% <100.00%> (ø)` | |
| [...nication/jdbc/JDBCDatabaseCommunicationEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/22073/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb21tdW5pY2F0aW9uL2pkYmMvSkRCQ0RhdGFiYXNlQ29tbXVuaWNhdGlvbkVuZ2luZS5qYXZh) | `84.37% <100.00%> (ø)` | |
| [.../query/text/query/MySQLMultiStatementsHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/22073/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvZnJvbnRlbmQvbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Byb3h5L2Zyb250ZW5kL215c3FsL2NvbW1hbmQvcXVlcnkvdGV4dC9xdWVyeS9NeVNRTE11bHRpU3RhdGVtZW50c0hhbmRsZXIuamF2YQ==) | `95.89% <100.00%> (ø)` | |
| [.../extended/PostgreSQLBatchedStatementsExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/22073/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvZnJvbnRlbmQvcG9zdGdyZXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvZnJvbnRlbmQvcG9zdGdyZXNxbC9jb21tYW5kL3F1ZXJ5L2V4dGVuZGVkL1Bvc3RncmVTUUxCYXRjaGVkU3RhdGVtZW50c0V4ZWN1dG9yLmphdmE=) | `95.29% <100.00%> (ø)` | |
| [...e/execute/ShardingSphereDataScheduleCollector.java](https://codecov.io/gh/apache/shardingsphere/pull/22073/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGF0YS9waXBlbGluZS9jb3JlL2V4ZWN1dGUvU2hhcmRpbmdTcGhlcmVEYXRhU2NoZWR1bGVDb2xsZWN0b3IuamF2YQ==) | `81.57% <0.00%> (+81.57%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org