[jira] [Commented] (KAFKA-6300) SelectorTest may fail with ConcurrentModificationException

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-6300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16275796#comment-16275796 ] 

ASF GitHub Bot commented on KAFKA-6300:
---------------------------------------

GitHub user tedyu opened a pull request:

    https://github.com/apache/kafka/pull/4288

    KAFKA-6300 SelectorTest may fail with ConcurrentModificationException

    Synchronization is added w.r.t. sockets ArrayList to avoid ConcurrentModificationException
    
    ### Committer Checklist (excluded from commit message)
    - [ ] Verify design and implementation 
    - [ ] Verify test coverage and CI build status
    - [ ] Verify documentation (including upgrade notes)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tedyu/kafka trunk

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/4288.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4288
    
----
commit 8943cc9a39f297dacf091e8e02c09b44f6b9a6fe
Author: tedyu <yu...@gmail.com>
Date:   2017-12-03T00:13:37Z

    KAFKA-6300 SelectorTest may fail with ConcurrentModificationException

----


> SelectorTest may fail with ConcurrentModificationException
> ----------------------------------------------------------
>
>                 Key: KAFKA-6300
>                 URL: https://issues.apache.org/jira/browse/KAFKA-6300
>             Project: Kafka
>          Issue Type: Test
>            Reporter: Ted Yu
>            Priority: Minor
>
> From https://builds.apache.org/job/kafka-trunk-jdk8/2255/testReport/junit/org.apache.kafka.common.network/SelectorTest/testImmediatelyConnectedCleaned/ :
> {code}
> java.util.ConcurrentModificationException
> 	at java.util.ArrayList$Itr.checkForComodification(ArrayList.java:909)
> 	at java.util.ArrayList$Itr.next(ArrayList.java:859)
> 	at org.apache.kafka.common.network.EchoServer.closeConnections(EchoServer.java:115)
> 	at org.apache.kafka.common.network.EchoServer.close(EchoServer.java:121)
> 	at org.apache.kafka.common.network.SelectorTest.tearDown(SelectorTest.java:95)
> {code}
> It seems sockets ArrayList was modified during closing.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)