You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "Alessandro Benedetti (Jira)" <ji...@apache.org> on 2020/09/28 19:49:00 UTC
[jira] [Commented] (SOLR-14408) Refactor MoreLikeThisHandler
Implementation
[ https://issues.apache.org/jira/browse/SOLR-14408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17203486#comment-17203486 ]
Alessandro Benedetti commented on SOLR-14408:
---------------------------------------------
Hi [~Seidan], sorry for the abysmal delay in responding, I just got the chance to review your pull request.
It seems ok to me, only question is related the interesting term class.
Are we sure there isn't anything similar already in the Apache Lucene/Solr codebase ?
I took a quick look and I wasn't able to find it.
Let me know and we can progress with the merge,
Cheers
> Refactor MoreLikeThisHandler Implementation
> -------------------------------------------
>
> Key: SOLR-14408
> URL: https://issues.apache.org/jira/browse/SOLR-14408
> Project: Solr
> Issue Type: Improvement
> Components: MoreLikeThis
> Reporter: Nazerke Seidan
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The main goal of this refactoring is for readability and accessibility of MoreLikeThisHandler class. Current MoreLikeThisHandler class consists of two static subclasses and accessing them later in MoreLikeThisComponent. I propose to have them as separate public classes.
> cc: [~abenedetti], as you have had the recent commit for MLT, what do you think about this? Anyway, the code is ready for review.
>
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org