[GitHub] wido commented on a change in pull request #2415: CLOUDSTACK-10244: KVM online storage migration fails and corrupts disk

[GitBox <gi...@apache.org>]

wido commented on a change in pull request #2415: CLOUDSTACK-10244: KVM online storage migration fails and corrupts disk
URL: https://github.com/apache/cloudstack/pull/2415#discussion_r162760506
 
 

 ##########
 File path: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtMigrateCommandWrapper.java
 ##########
 @@ -132,8 +132,9 @@ Use VIR_DOMAIN_XML_SECURE (value = 1) prior to v1.0.0.
             vmsnapshots = libvirtComputingResource.cleanVMSnapshotMetadata(dm);
 
             Map<String, MigrateCommand.MigrateDiskInfo> mapMigrateStorage = command.getMigrateStorage();
+            boolean migrateStorage = MapUtils.isNotEmpty(mapMigrateStorage);
 
 Review comment:
   Would it not be safer to make this boolean a final one? That way you are 100% sure it's not changed anywhere.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services