[GitHub] gigasquid commented on a change in pull request #12690: [MXNET-1000] get Ndarray real value and form it from a NDArray

[GitBox <gi...@apache.org>]

gigasquid commented on a change in pull request #12690: [MXNET-1000] get Ndarray real value and form it from a NDArray
URL: https://github.com/apache/incubator-mxnet/pull/12690#discussion_r223125583
 
 

 ##########
 File path: scala-package/core/src/main/scala/org/apache/mxnet/NDArray.scala
 ##########
 @@ -197,6 +197,15 @@ object NDArray extends NDArrayBase {
       "_onehot_encode", Seq(indices, out), Map("out" -> out))(0)
   }
 
+  /**
+    * Get the String representation of NDArray
+    * @param nd input NDArray
+    * @return String
+    */
+  def toString(nd : NDArray) : String = {
+    nd.visualize
 
 Review comment:
   I want to test this out through the Clojure api. We do a lot of work in the REPL and with a default visualize in the .toString method I want to make sure the usability is not surprising, (especially with large arrays).
   
   I'll take a look and let you know

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services