[GitHub] [incubator-superset] villebro commented on a change in pull request #9975: [WIP] feat: finalize Word Cloud move to new chart data endpoint

[GitBox <gi...@apache.org>]

villebro commented on a change in pull request #9975:
URL: https://github.com/apache/incubator-superset/pull/9975#discussion_r435114981



##########
File path: tests/core_tests.py
##########
@@ -161,24 +161,6 @@ def test_get_superset_tables_not_found(self):
         rv = self.client.get(uri)
         self.assertEqual(rv.status_code, 404)
 
-    def test_old_slice_json_endpoint(self):

Review comment:
       These tests are no longer applicable, as the backend is not able to infer 1) which endpoint to call 2) what the final request payload will look like (this is handled by `buildQuery.{j,t}s` in the plugin). Going forward all these tests will reside in the viz plugin, with the backend tests ensuring that valid chart data requests get valid responses.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org