You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by aa...@apache.org on 2022/07/27 03:08:59 UTC
[rocketmq-clients] branch master updated: Remove ClientException#getResponseCode (#74)
This is an automated email from the ASF dual-hosted git repository.
aaronai pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/rocketmq-clients.git
The following commit(s) were added to refs/heads/master by this push:
new cbdc08c Remove ClientException#getResponseCode (#74)
cbdc08c is described below
commit cbdc08c6093ae127735833adc31c0782052c900e
Author: Aaron Ai <ya...@gmail.com>
AuthorDate: Wed Jul 27 11:08:54 2022 +0800
Remove ClientException#getResponseCode (#74)
---
.../org/apache/rocketmq/client/apis/ClientException.java | 14 --------------
.../client/java/impl/consumer/ReceiveMessageResult.java | 4 +---
java/pom.xml | 14 --------------
3 files changed, 1 insertion(+), 31 deletions(-)
diff --git a/java/client-apis/src/main/java/org/apache/rocketmq/client/apis/ClientException.java b/java/client-apis/src/main/java/org/apache/rocketmq/client/apis/ClientException.java
index 4f8780b..42d7b01 100644
--- a/java/client-apis/src/main/java/org/apache/rocketmq/client/apis/ClientException.java
+++ b/java/client-apis/src/main/java/org/apache/rocketmq/client/apis/ClientException.java
@@ -17,10 +17,6 @@
package org.apache.rocketmq.client.apis;
-import java.util.HashMap;
-import java.util.Map;
-import java.util.Optional;
-
/**
* Base exception for all exceptions raised in client, each exception should derive from the current class.
* It should throw exception which is derived from {@link ClientException} rather than {@link ClientException} itself.
@@ -33,29 +29,19 @@ public class ClientException extends Exception {
protected static final String REQUEST_ID_KEY = "request-id";
protected static final String RESPONSE_CODE_KEY = "response-code";
- private final Map<String, String> context;
-
public ClientException(String message, Throwable cause) {
super(message, cause);
- this.context = new HashMap<>();
}
public ClientException(String message) {
super(message);
- this.context = new HashMap<>();
}
public ClientException(Throwable t) {
super(t);
- this.context = new HashMap<>();
}
public ClientException(int responseCode, String requestId, String message) {
this("[" + REQUEST_ID_KEY + "=" + requestId + ", " + RESPONSE_CODE_KEY + "=" + responseCode + "] " + message);
}
-
- public Optional<Integer> getResponseCode() {
- final String responseCode = context.get(RESPONSE_CODE_KEY);
- return null == responseCode ? Optional.empty() : Optional.of(Integer.parseInt(responseCode));
- }
}
diff --git a/java/client/src/main/java/org/apache/rocketmq/client/java/impl/consumer/ReceiveMessageResult.java b/java/client/src/main/java/org/apache/rocketmq/client/java/impl/consumer/ReceiveMessageResult.java
index a4d5993..9f4fa2e 100644
--- a/java/client/src/main/java/org/apache/rocketmq/client/java/impl/consumer/ReceiveMessageResult.java
+++ b/java/client/src/main/java/org/apache/rocketmq/client/java/impl/consumer/ReceiveMessageResult.java
@@ -91,9 +91,7 @@ public class ReceiveMessageResult {
* @return true if the result is ok, false otherwise.
*/
public boolean ok() {
- return null == exception || (exception.getResponseCode().isPresent() && (Code.OK.getNumber() ==
- exception.getResponseCode().get()) || Code.MESSAGE_NOT_FOUND.getNumber() ==
- exception.getResponseCode().get());
+ return null == exception;
}
public List<MessageView> checkAndGetMessages() throws ClientException {
diff --git a/java/pom.xml b/java/pom.xml
index e0b0664..e6c612f 100644
--- a/java/pom.xml
+++ b/java/pom.xml
@@ -54,20 +54,6 @@
<maven-antrun-plugin.version>1.8</maven-antrun-plugin.version>
</properties>
- <repositories>
- <repository>
- <id>nexus</id>
- <url>https://repository.apache.org/content/groups/public/</url>
- <releases>
- <enabled>true</enabled>
- <updatePolicy>always</updatePolicy>
- </releases>
- <snapshots>
- <enabled>true</enabled>
- <updatePolicy>always</updatePolicy>
- </snapshots>
- </repository>
- </repositories>
<dependencyManagement>
<dependencies>