You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Joe Swatosh <jo...@gmail.com> on 2007/08/26 16:56:00 UTC

Re: svn commit: r26322 - in trunk/subversion/bindings/swig/ruby/test: . test-unit-ext

Hi kou,

On 8/25/07, kou@tigris.org <ko...@tigris.org> wrote:
> Author: kou
> Date: Sat Aug 25 21:59:59 2007
> New Revision: 26322
>
> Log:
> Extend Test::Unit.
>
> * subversion/bindings/swig/ruby/test (svn:ignore): Add .test-result.
> * subversion/bindings/swig/ruby/test/run-test.rb: Require Test::Unit extensions.
> * subversion/bindings/swig/ruby/test/test-unit-ext.rb:
>  - New file.
>  - Entry point of Test::Unit extensions.
> * subversion/bindings/swig/ruby/test/test-unit-ext/priority.rb:
>  - New file.
>  - Introduce priority to each test.
> * subversion/bindings/swig/ruby/test/test-unit-ext/backtrace-filter.rb:
>  - New file.
>  - Suppress test-unit-ext related lines from backtrace.
> * subversion/bindings/swig/ruby/test/test-unit-ext/always-show-result.rb:
>  - New file.
>  - Show test result even if we interrupt tests.
> * subversion/bindings/swig/ruby/test/test-unit-ext/long-display-for-emacs.rb:
>  - New file.
>  - Make backtrace format more Emacs friendly.
>
>

Uh oh, I can no longer run the tests....


D:\SVN\src-trunk\subversion\bindings\swig\ruby>ruby test\run-test.rb
Loaded suite .
Started
............................................................C:/Ruby/lib/ruby/1.8/fileutils.rb:243:in
`mkdir': Invalid argument - D:/SVN/src-
trunk/subversion/bindings/swig/ruby/test/.test-result/SvnCoreTest/test_binary_mime_type?
(Errno::EINVAL)
        from C:/Ruby/lib/ruby/1.8/fileutils.rb:243:in `fu_mkdir'
        from C:/Ruby/lib/ruby/1.8/fileutils.rb:217:in `mkdir_p'
        from C:/Ruby/lib/ruby/1.8/fileutils.rb:215:in `reverse_each'
        from C:/Ruby/lib/ruby/1.8/fileutils.rb:215:in `mkdir_p'
        from C:/Ruby/lib/ruby/1.8/fileutils.rb:201:in `each'
        from C:/Ruby/lib/ruby/1.8/fileutils.rb:201:in `mkdir_p'
        from D:/SVN/src-trunk/subversion/bindings/swig/ruby/test/test-unit-ext/priority.rb:114:in
`result_dir'
        from D:/SVN/src-trunk/subversion/bindings/swig/ruby/test/test-unit-ext/priority.rb:119:in
`passed_file'
         ... 13 levels...
        from C:/Ruby/lib/ruby/1.8/test/unit/ui/testrunnerutilities.rb:29:in
`run'
        from C:/Ruby/lib/ruby/1.8/test/unit/autorunner.rb:216:in `run'
        from C:/Ruby/lib/ruby/1.8/test/unit/autorunner.rb:12:in `run'
        from test/run-test.rb:30


--
Joe

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: r26322 - in trunk/subversion/bindings/swig/ruby/test: . test-unit-ext

Posted by Joe Swatosh <jo...@gmail.com>.
Hi

On 8/26/07, Kouhei Sutou <ko...@cozmixng.org> wrote:
> Hi,
>
> > > Your patch changes the ".test-result" in the filename to
> > > "_test-result". Windows is okay with periods in filenames so I don't
> > > think this will help.
> > >
> >
> > The patch made no difference, but I think David is right.  Removing
> > the ? from the name of the test let it run.
>
> OK.
> What about the attached patch? If this works, could you commit this?
>
>

r26331

Thanks!
--
Joe

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: r26322 - in trunk/subversion/bindings/swig/ruby/test: . test-unit-ext

Posted by Kouhei Sutou <ko...@cozmixng.org>.
Hi,

> > Your patch changes the ".test-result" in the filename to
> > "_test-result". Windows is okay with periods in filenames so I don't
> > think this will help.
> >
>
> The patch made no difference, but I think David is right.  Removing
> the ? from the name of the test let it run.

OK.
What about the attached patch? If this works, could you commit this?


Thanks,
--
kou

Re: svn commit: r26322 - in trunk/subversion/bindings/swig/ruby/test: . test-unit-ext

Posted by Joe Swatosh <jo...@gmail.com>.
Hi

On 8/26/07, David James <ja...@cs.toronto.edu> wrote:
> On 8/26/07, Kouhei Sutou <ko...@cozmixng.org> wrote:
> > Hi,
> >
> > > > Author: kou
> > > > Date: Sat Aug 25 21:59:59 2007
> > > > New Revision: 26322
> > > >
> > > > Log:
> > > > Extend Test::Unit.
> > >
> > > Uh oh, I can no longer run the tests....
> > >
> > >
> > ............................................................C:/Ruby/lib/ruby/1.8/fileutils.rb:243:in
> > > `mkdir': Invalid argument - D:/SVN/src-
> > > trunk/subversion/bindings/swig/ruby/test/.test-result/SvnCoreTest/test_binary_mime_type?
> > > (Errno::EINVAL)
>
> I think the problem here is that Windows doesn't allow question marks
> in filenames, and "test_binary_mime_type?" contains a question mark.
>
> > Can the attached patch fix the problem?
>
> Your patch changes the ".test-result" in the filename to
> "_test-result". Windows is okay with periods in filenames so I don't
> think this will help.
>

The patch made no difference, but I think David is right.  Removing
the ? from the name of the test let it run.

--
Joe

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: r26322 - in trunk/subversion/bindings/swig/ruby/test: . test-unit-ext

Posted by David James <ja...@cs.toronto.edu>.
On 8/26/07, Kouhei Sutou <ko...@cozmixng.org> wrote:
> Hi,
>
> > > Author: kou
> > > Date: Sat Aug 25 21:59:59 2007
> > > New Revision: 26322
> > >
> > > Log:
> > > Extend Test::Unit.
> >
> > Uh oh, I can no longer run the tests....
> >
> >
> ............................................................C:/Ruby/lib/ruby/1.8/fileutils.rb:243:in
> > `mkdir': Invalid argument - D:/SVN/src-
> > trunk/subversion/bindings/swig/ruby/test/.test-result/SvnCoreTest/test_binary_mime_type?
> > (Errno::EINVAL)

I think the problem here is that Windows doesn't allow question marks
in filenames, and "test_binary_mime_type?" contains a question mark.

> Can the attached patch fix the problem?

Your patch changes the ".test-result" in the filename to
"_test-result". Windows is okay with periods in filenames so I don't
think this will help.

Cheers,

David

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: r26322 - in trunk/subversion/bindings/swig/ruby/test: . test-unit-ext

Posted by Kouhei Sutou <ko...@cozmixng.org>.
Hi,

> > Author: kou
> > Date: Sat Aug 25 21:59:59 2007
> > New Revision: 26322
> >
> > Log:
> > Extend Test::Unit.
>
> Uh oh, I can no longer run the tests....
>
>
............................................................C:/Ruby/lib/ruby/1.8/fileutils.rb:243:in
> `mkdir': Invalid argument - D:/SVN/src-
> trunk/subversion/bindings/swig/ruby/test/.test-result/SvnCoreTest/test_binary_mime_type?
> (Errno::EINVAL)

Can the attached patch fix the problem?


Thanks,
--
kou