You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by SrikanteswaraRao Talluri <sr...@citrix.com> on 2013/05/28 11:15:53 UTC
Review Request: add zone wide primary storage tests
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11462/
-----------------------------------------------------------
Review request for cloudstack, Prasanna Santhanam and Sateesh Chodapuneedi.
Description
-------
Added few basic zone wide primary storage tests.
This addresses bug CLOUDSTACK-2710.
Diffs
-----
test/integration/smoke/test_primary_storage.py 598654d
tools/marvin/marvin/integration/lib/base.py ec1c34e
Diff: https://reviews.apache.org/r/11462/diff/
Testing
-------
done.
teardown() fails as there is a bug while moving a storagepool into maintenance.
Thanks,
SrikanteswaraRao Talluri
Re: Review Request: add zone wide primary storage tests
Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
> On May 31, 2013, 4:43 a.m., Prasanna Santhanam wrote:
> > test/integration/smoke/test_zwps.py, line 127
> > <https://reviews.apache.org/r/11462/diff/2/?file=297285#file297285line127>
> >
> > This test is not required. If I deploy a zone with zone-wide storage then the regular deployVM test will be sufficient.
Above suggestion is enough for deploy VM when there is only zone-wide storage, the case added here is a case where there are multiple primaries and if you want to choose where your VM to be on ZWPS.
For testing VM life cycle tests on different scoped(CLUSTER, ZONE, HOST) primary storages, if we have a zone deployed with just that specific scoped storage, I agree , just running VM life cycle would suffice.
- SrikanteswaraRao
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11462/#review21227
-----------------------------------------------------------
On May 28, 2013, 3:24 p.m., SrikanteswaraRao Talluri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11462/
> -----------------------------------------------------------
>
> (Updated May 28, 2013, 3:24 p.m.)
>
>
> Review request for cloudstack, Prasanna Santhanam and Sateesh Chodapuneedi.
>
>
> Description
> -------
>
> Added few basic zone wide primary storage tests.
>
>
> This addresses bug CLOUDSTACK-2710.
>
>
> Diffs
> -----
>
> test/integration/smoke/test_primary_storage.py 598654d
> test/integration/smoke/test_zwps.py PRE-CREATION
> tools/marvin/marvin/integration/lib/base.py ec1c34e
>
> Diff: https://reviews.apache.org/r/11462/diff/
>
>
> Testing
> -------
>
> done.
> teardown() fails as there is a bug while moving a storagepool into maintenance.
>
>
> Thanks,
>
> SrikanteswaraRao Talluri
>
>
Re: Review Request: add zone wide primary storage tests
Posted by Prasanna Santhanam <ts...@apache.org>.
> On May 31, 2013, 4:43 a.m., Prasanna Santhanam wrote:
> > test/integration/smoke/test_zwps.py, line 127
> > <https://reviews.apache.org/r/11462/diff/2/?file=297285#file297285line127>
> >
> > This test is not required. If I deploy a zone with zone-wide storage then the regular deployVM test will be sufficient.
>
> SrikanteswaraRao Talluri wrote:
> Above suggestion is enough for deploy VM when there is only zone-wide storage, the case added here is a case where there are multiple primaries and if you want to choose where your VM to be on ZWPS.
>
> For testing VM life cycle tests on different scoped(CLUSTER, ZONE, HOST) primary storages, if we have a zone deployed with just that specific scoped storage, I agree , just running VM life cycle would suffice.
Can I run this test on any configuration of advanced zone and NFS storage? Will this need to have a zone-wide primary storage added to work?
- Prasanna
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11462/#review21227
-----------------------------------------------------------
On May 28, 2013, 3:24 p.m., SrikanteswaraRao Talluri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11462/
> -----------------------------------------------------------
>
> (Updated May 28, 2013, 3:24 p.m.)
>
>
> Review request for cloudstack, Prasanna Santhanam and Sateesh Chodapuneedi.
>
>
> Description
> -------
>
> Added few basic zone wide primary storage tests.
>
>
> This addresses bug CLOUDSTACK-2710.
>
>
> Diffs
> -----
>
> test/integration/smoke/test_primary_storage.py 598654d
> test/integration/smoke/test_zwps.py PRE-CREATION
> tools/marvin/marvin/integration/lib/base.py ec1c34e
>
> Diff: https://reviews.apache.org/r/11462/diff/
>
>
> Testing
> -------
>
> done.
> teardown() fails as there is a bug while moving a storagepool into maintenance.
>
>
> Thanks,
>
> SrikanteswaraRao Talluri
>
>
Re: Review Request: add zone wide primary storage tests
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11462/#review21227
-----------------------------------------------------------
Rest of the patch looks fine save for the test_zwps module
test/integration/smoke/test_zwps.py
<https://reviews.apache.org/r/11462/#comment44081>
This test is not required. If I deploy a zone with zone-wide storage then the regular deployVM test will be sufficient.
- Prasanna Santhanam
On May 28, 2013, 3:24 p.m., SrikanteswaraRao Talluri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11462/
> -----------------------------------------------------------
>
> (Updated May 28, 2013, 3:24 p.m.)
>
>
> Review request for cloudstack, Prasanna Santhanam and Sateesh Chodapuneedi.
>
>
> Description
> -------
>
> Added few basic zone wide primary storage tests.
>
>
> This addresses bug CLOUDSTACK-2710.
>
>
> Diffs
> -----
>
> test/integration/smoke/test_primary_storage.py 598654d
> test/integration/smoke/test_zwps.py PRE-CREATION
> tools/marvin/marvin/integration/lib/base.py ec1c34e
>
> Diff: https://reviews.apache.org/r/11462/diff/
>
>
> Testing
> -------
>
> done.
> teardown() fails as there is a bug while moving a storagepool into maintenance.
>
>
> Thanks,
>
> SrikanteswaraRao Talluri
>
>
Re: Review Request: add zone wide primary storage tests
Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11462/
-----------------------------------------------------------
(Updated May 28, 2013, 3:24 p.m.)
Review request for cloudstack, Prasanna Santhanam and Sateesh Chodapuneedi.
Changes
-------
updated the diff with some more tests
Description
-------
Added few basic zone wide primary storage tests.
This addresses bug CLOUDSTACK-2710.
Diffs (updated)
-----
test/integration/smoke/test_primary_storage.py 598654d
test/integration/smoke/test_zwps.py PRE-CREATION
tools/marvin/marvin/integration/lib/base.py ec1c34e
Diff: https://reviews.apache.org/r/11462/diff/
Testing
-------
done.
teardown() fails as there is a bug while moving a storagepool into maintenance.
Thanks,
SrikanteswaraRao Talluri