You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by NareshKosgi <gi...@git.apache.org> on 2014/11/18 20:59:22 UTC
[GitHub] storm pull request: Storm-456 cannot navigate to topology page whe...
GitHub user NareshKosgi opened a pull request:
https://github.com/apache/storm/pull/318
Storm-456 cannot navigate to topology page when name contains spaces
@Parth-Brahmbhatt
I had pull request open for this but I deleted it accidentally.
You were rite the decode only fixed the space issue but caused issues with percent sign. After looking thru the code I found where the url is being encoded and changed it to use the ring encoder. This fixed the issue for both percent and space.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/NareshKosgi/incubator-storm storm-456
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/318.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #318
----
commit e72a94c1de7dd4fa7744c9dd914439bcd59a634b
Author: Naresh Kosgi <na...@gmail.com>
Date: 2014-10-18T02:57:52Z
routes look for the plus sign
commit ccbfad1fec3f99531a8160dae51419abc3e5bb87
Author: Naresh Kosgi <na...@gmail.com>
Date: 2014-10-27T16:12:18Z
using word count to test
commit 757653d523a52a3c0dccec1dba55c951fce815c5
Author: Naresh Kosgi <na...@gmail.com>
Date: 2014-10-27T23:36:52Z
Merge branch 'master' into storm-456
commit 5afb60a3fdabc849efe6e746d5672e1d6cb4f7a2
Author: Naresh Kosgi <na...@gmail.com>
Date: 2014-11-11T21:23:52Z
added url decode method in the route
commit 31b1032a144d6ff020600c63093e6360629d830c
Author: Naresh Kosgi <na...@gmail.com>
Date: 2014-11-11T21:27:45Z
Merge branch 'storm-456' of https://github.com/NareshKosgi/incubator-storm into storm-456
Conflicts:
storm-core/src/clj/backtype/storm/ui/core.clj
commit ac4542a5a3dff54af65ab67394170072843b2f88
Author: Naresh Kosgi <na...@gmail.com>
Date: 2014-11-11T21:34:07Z
changed word count Topo back to local cluster
commit 2a38a033e12d4f79ac022709280a5fc86902dc29
Author: Naresh Kosgi <na...@gmail.com>
Date: 2014-11-11T21:35:32Z
changed Wordcount back to normal
commit 4ea7f01d2796b25f3fd8ca0f8d93407771b64adf
Author: Naresh Kosgi <na...@gmail.com>
Date: 2014-11-11T21:37:59Z
reverting word count topo
commit 86c33e4e6c071ae88fb660be3599e217778dafd4
Author: Naresh Kosgi <na...@gmail.com>
Date: 2014-11-18T19:27:12Z
using the ring encoder
commit 3ee031f65136d3a7cb29edf89568ce4d20647f3b
Author: Naresh Kosgi <na...@gmail.com>
Date: 2014-11-18T19:33:45Z
Merge branch 'storm-456' of https://github.com/NareshKosgi/incubator-storm into storm-456
Conflicts:
storm-core/src/clj/backtype/storm/ui/core.clj
commit 608f3e6b44bdbfe2da9c1eb9005c3c1b91027718
Author: Naresh Kosgi <na...@gmail.com>
Date: 2014-11-18T19:34:18Z
deleted the generated pom
commit a5dbea06a543d04e3b4978a30e3a38fd17fb9731
Author: Naresh Kosgi <na...@gmail.com>
Date: 2014-11-18T19:45:09Z
Merge branch 'master' into storm-456
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: Storm-456 cannot navigate to topology page whe...
Posted by Parth-Brahmbhatt <gi...@git.apache.org>.
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/storm/pull/318#issuecomment-75109743
@NareshKosgi Thanks for testing the feature, yes you can just close it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: Storm-456 cannot navigate to topology page whe...
Posted by NareshKosgi <gi...@git.apache.org>.
Github user NareshKosgi commented on the pull request:
https://github.com/apache/storm/pull/318#issuecomment-75109471
@revans2 @Parth-Brahmbhatt I was able to build and run by using mvn install. I checked with topo name with space and '%' sign. They are working. Do I just close the pull request and jira ticket in that case?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: Storm-456 cannot navigate to topology page whe...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/318#issuecomment-67976452
The issue appears to be that when we url decode the topology name the '+' is staying as a '+' if I replace it with a space ' ' in the URL it seems to work for me on both firefox and chrome. I think we want to replace the space with '%20', not a '+'.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: Storm-456 cannot navigate to topology page whe...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/318#issuecomment-74683011
We put in some changes so the storm build now uses a plugin that is also built as part of the build. This makes it so you cannot run ```mvn compile``` on its own any more, you need to run at least ```mvn package``` because needs a jar on the classpath. If you plan on building in just storm-core you need to have installed the plugin into your local repo first. We are working on a way to fix this, but don't have a perfect solution yet https://issues.apache.org/jira/browse/STORM-639.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: Storm-456 cannot navigate to topology page whe...
Posted by d2r <gi...@git.apache.org>.
Github user d2r commented on the pull request:
https://github.com/apache/storm/pull/318#issuecomment-73545196
@Parth-Brahmbhatt, @NareshKosgi , Does #360 sufficiently resolve STORM-456? If so, we should close this pull request and resolve STORM-456.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: Storm-456 cannot navigate to topology page whe...
Posted by Parth-Brahmbhatt <gi...@git.apache.org>.
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/storm/pull/318#issuecomment-67995761
actually there were multiple places with url-encode function that needed to be replaced I have opened a PR so the issue no longer appears https://github.com/apache/storm/pull/360. I have tested with topology name "Word+Count hi#^&(*&)_+<?>" and I was able to take all the actions without any errors.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: Storm-456 cannot navigate to topology page whe...
Posted by NareshKosgi <gi...@git.apache.org>.
Github user NareshKosgi commented on the pull request:
https://github.com/apache/storm/pull/318#issuecomment-74614469
@Parth-Brahmbhatt I tried to build the lastest storm but i'm having the following issue:
[ERROR] Error resolving version for plugin 'org.apache.storm:storm-maven-plugins' from the repositories [local (/Users/nareshkosgi/.m2/repository), central (http://repo.maven.apache.org/maven2)]: Plugin not found in any plugin repository
I spent sometime trying to see if its something local to mine but haven't had success. am I missing something new that was added to storm that I need in order to build the latest master? I installed node which was the only new thing I saw.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: Storm-456 cannot navigate to topology page whe...
Posted by Parth-Brahmbhatt <gi...@git.apache.org>.
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/storm/pull/318#issuecomment-63547305
When i tried to test locally with a white space topology I am getting "Error while communicating with Nimbus." after I try to deactivate using ui. The action succeeds and the response redirects also works but the error is confusing.
Remote Address:[::1]:8080
Request URL:http://localhost:8080/api/v1/topology/Word+Count-1-1416345486
Request Method:GET
Status Code:500 Server Error
Request Headersview source
Accept:*/*
Accept-Encoding:gzip,deflate,sdch
Accept-Language:en-US,en;q=0.8
Cache-Control:no-cache
Connection:keep-alive
Cookie:sys=true; _mkto_trk=id:549-QAL-086&token:_mch-localhost-1412898713595-55188; csrftoken=64142f8e6fc9f9bedc70b15aef657ef4; ring-session=3c6563eb-dfa3-405f-bada-9eb5d75662e5
DNT:1
Host:localhost:8080
Pragma:no-cache
Referer:http://localhost:8080/topology.html?id=Word%20Count-1-1416345486
User-Agent:Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/38.0.2125.111 Safari/537.36
x-csrf-token:lO1ViTwmfYM+MR+MUqZXCotu9S6iqXzesrJ2bttfksMbfecthuT0qLH4yWKFRQ5fVB/hqG4N/7hOLGE1
X-Requested-With:XMLHttpRequest
Response Headersview source
Content-Length:3684
Content-Type:application/json;charset=utf-8
Date:Tue, 18 Nov 2014 21:22:23 GMT
Server:Jetty(7.6.13.v20130916)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: Storm-456 cannot navigate to topology page whe...
Posted by NareshKosgi <gi...@git.apache.org>.
Github user NareshKosgi closed the pull request at:
https://github.com/apache/storm/pull/318
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: Storm-456 cannot navigate to topology page whe...
Posted by Parth-Brahmbhatt <gi...@git.apache.org>.
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/storm/pull/318#issuecomment-73568595
Yes, I think its ok to close the jira. @NareshKosgi can you test and comment. The changes are merged into master so should be easy to test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---