You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/01/30 18:00:54 UTC

[GitHub] [pulsar] lhotari commented on a change in pull request #14065: [Test] Remove junit

lhotari commented on a change in pull request #14065:
URL: https://github.com/apache/pulsar/pull/14065#discussion_r795223019



##########
File path: pulsar-broker-common/src/test/java/org/apache/pulsar/broker/authorization/MultiRolesTokenAuthorizationProviderTest.java
##########
@@ -22,7 +22,7 @@
 import io.jsonwebtoken.SignatureAlgorithm;
 import org.apache.pulsar.broker.authentication.AuthenticationDataSource;
 import org.apache.pulsar.broker.authentication.utils.AuthTokenUtils;
-import org.junit.Assert;

Review comment:
       Please note that the argument order is different in TestNG Assert. In TestNG Assert, it's actual, expected, but in Junit Assert it's expected, actual. You need to swap the parameter when switching from Junit to TestNG.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org