[GitHub] [incubator-uniffle] advancedxy commented on a diff in pull request #629: [#627] fix(operator): support specifying custom ports

["advancedxy (via GitHub)" <gi...@apache.org>]

advancedxy commented on code in PR #629:
URL: https://github.com/apache/incubator-uniffle/pull/629#discussion_r1109755464


##########
deploy/kubernetes/operator/pkg/controller/sync/coordinator/coordinator.go:
##########
@@ -281,7 +281,7 @@ func GenerateAddresses(rss *unifflev1alpha1.RemoteShuffleService) string {
 	for i := 0; i < int(*rss.Spec.Coordinator.Count); i++ {
 		name := GenerateNameByIndex(rss, i)
 		serviceName := appendHeadless(name)
-		current := fmt.Sprintf("%v:%v", serviceName, controllerconstants.ContainerShuffleServerRPCPort)
+		current := fmt.Sprintf("%v:%v", serviceName, *rss.Spec.Coordinator.RPCPort)

Review Comment:
   Could you also update the UT in the test file. Should add lines to verify the port is correct.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org