You are viewing a plain text version of this content. The canonical link for it is here.
Posted to woden-dev@ws.apache.org by "John Kaputin (JIRA)" <ji...@apache.org> on 2007/02/07 03:25:05 UTC
[jira] Created: (WODEN-140) DescriptionElement.getNamespaces()
should have a type-safe return type
DescriptionElement.getNamespaces() should have a type-safe return type
----------------------------------------------------------------------
Key: WODEN-140
URL: https://issues.apache.org/jira/browse/WODEN-140
Project: Woden
Issue Type: Improvement
Components: Parser
Reporter: John Kaputin
Fix For: M8
The DescriptionElement.getNamespaces() method currently returns a Map containing pairs of prefix String and namespace URI. In keeping with woden design goals and the rest of the API, this method should use a type-safe return type. Map, List, etc represent their content as java.lang.Object which requires casting.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org
[jira] Commented: (WODEN-140) DescriptionElement.getNamespaces()
should have a type-safe return type
Posted by "Dan Harvey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WODEN-140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12521758 ]
Dan Harvey commented on WODEN-140:
----------------------------------
I have created a new type class NamespaceMap which impliments Map with type-safe methods for a String prefix and URI namespace.
This required very few changes to the rest of the code but some parts could be simplified so I've included these in this patch too.
> DescriptionElement.getNamespaces() should have a type-safe return type
> ----------------------------------------------------------------------
>
> Key: WODEN-140
> URL: https://issues.apache.org/jira/browse/WODEN-140
> Project: Woden
> Issue Type: Improvement
> Components: Parser
> Reporter: John Kaputin
> Assignee: Dan Harvey
> Fix For: M8
>
> Attachments: Woden-140.patch.txt
>
>
> The DescriptionElement.getNamespaces() method currently returns a Map containing pairs of prefix String and namespace URI. In keeping with woden design goals and the rest of the API, this method should use a type-safe return type. Map, List, etc represent their content as java.lang.Object which requires casting.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org
[jira] Updated: (WODEN-140) DescriptionElement.getNamespaces()
should have a type-safe return type
Posted by "John Kaputin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WODEN-140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Kaputin updated WODEN-140:
-------------------------------
Attachment: woden140_option2.patch
woden140_option1.patch
Dan,
per our discussion could you look into implementing support for namespace declarations across the WSDL Element model, rather than just fixing the support that's currently only in DescriptionElement.
I have attached two patch files containing different options for the API:
1) woden140_option1.patch had namespace methods defined on WSDLElement and it returns an array of NamespaceDeclarations
2) woden140_option2.patch uses a collection/iterator approach
To maintain consistency with the existing API I think I prefer option 1, but please review both, do some prototyping if you like and I'll discuss them with you before we decide.
> DescriptionElement.getNamespaces() should have a type-safe return type
> ----------------------------------------------------------------------
>
> Key: WODEN-140
> URL: https://issues.apache.org/jira/browse/WODEN-140
> Project: Woden
> Issue Type: Improvement
> Components: Parser
> Reporter: John Kaputin
> Assignee: Dan Harvey
> Fix For: M8
>
> Attachments: Woden-140.patch.txt, woden140_option1.patch, woden140_option2.patch
>
>
> The DescriptionElement.getNamespaces() method currently returns a Map containing pairs of prefix String and namespace URI. In keeping with woden design goals and the rest of the API, this method should use a type-safe return type. Map, List, etc represent their content as java.lang.Object which requires casting.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org
[jira] Commented: (WODEN-140) DescriptionElement.getNamespaces()
should have a type-safe return type
Posted by "John Kaputin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WODEN-140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12519943 ]
John Kaputin commented on WODEN-140:
------------------------------------
Need something like a class called NamespaceMap with methods to:
put a key/value pair consisting of a prefix and NS uri
get a NS uri for a specified prefix arg
get a prefix for a specified NS uri
The getNamespaces() method would return a NamespaceMap instead of java.util.Map and calling code must be changed to use this API instead of Map.
The set/getNamespace methods on DescriptionElement possibly become redundant with the introduction of NamespaceMap, but maybe still useful as convenience methods. However, there's more work to do on supporting namespace declarations across the WSDL model, which I'll raise as a new JIRA.
> DescriptionElement.getNamespaces() should have a type-safe return type
> ----------------------------------------------------------------------
>
> Key: WODEN-140
> URL: https://issues.apache.org/jira/browse/WODEN-140
> Project: Woden
> Issue Type: Improvement
> Components: Parser
> Reporter: John Kaputin
> Assignee: John Kaputin
> Fix For: M8
>
>
> The DescriptionElement.getNamespaces() method currently returns a Map containing pairs of prefix String and namespace URI. In keeping with woden design goals and the rest of the API, this method should use a type-safe return type. Map, List, etc represent their content as java.lang.Object which requires casting.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org
[jira] Updated: (WODEN-140) DescriptionElement.getNamespaces()
should have a type-safe return type
Posted by "Jeremy Hughes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WODEN-140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeremy Hughes updated WODEN-140:
--------------------------------
Fix Version/s: (was: M8)
(was: M7)
> DescriptionElement.getNamespaces() should have a type-safe return type
> ----------------------------------------------------------------------
>
> Key: WODEN-140
> URL: https://issues.apache.org/jira/browse/WODEN-140
> Project: Woden
> Issue Type: Improvement
> Components: Parser
> Reporter: John Kaputin
>
> The DescriptionElement.getNamespaces() method currently returns a Map containing pairs of prefix String and namespace URI. In keeping with woden design goals and the rest of the API, this method should use a type-safe return type. Map, List, etc represent their content as java.lang.Object which requires casting.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org
[jira] Updated: (WODEN-140) DescriptionElement.getNamespaces()
should have a type-safe return type
Posted by "John Kaputin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WODEN-140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Kaputin updated WODEN-140:
-------------------------------
Attachment: woden140_final.patch
Uploaded woden140_final.patch containing the committed code changes for this JIRA. Includes Dan Harvey's option 1 patches with a couple of further changes.
> DescriptionElement.getNamespaces() should have a type-safe return type
> ----------------------------------------------------------------------
>
> Key: WODEN-140
> URL: https://issues.apache.org/jira/browse/WODEN-140
> Project: Woden
> Issue Type: Improvement
> Components: Parser
> Reporter: John Kaputin
> Assignee: Dan Harvey
> Fix For: M8
>
> Attachments: woden-140 - namespace scope.patch, Woden-140.patch.txt, woden140_final.patch, woden140_option1.patch, woden140_option2.patch
>
>
> The DescriptionElement.getNamespaces() method currently returns a Map containing pairs of prefix String and namespace URI. In keeping with woden design goals and the rest of the API, this method should use a type-safe return type. Map, List, etc represent their content as java.lang.Object which requires casting.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org
[jira] Updated: (WODEN-140) DescriptionElement.getNamespaces()
should have a type-safe return type
Posted by "Dan Harvey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WODEN-140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dan Harvey updated WODEN-140:
-----------------------------
Attachment: woden-140 - namespace scope.patch
> DescriptionElement.getNamespaces() should have a type-safe return type
> ----------------------------------------------------------------------
>
> Key: WODEN-140
> URL: https://issues.apache.org/jira/browse/WODEN-140
> Project: Woden
> Issue Type: Improvement
> Components: Parser
> Reporter: John Kaputin
> Assignee: Dan Harvey
> Fix For: M8
>
> Attachments: woden-140 - namespace scope.patch, Woden-140.patch.txt, woden140_option1.patch, woden140_option2.patch
>
>
> The DescriptionElement.getNamespaces() method currently returns a Map containing pairs of prefix String and namespace URI. In keeping with woden design goals and the rest of the API, this method should use a type-safe return type. Map, List, etc represent their content as java.lang.Object which requires casting.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org
[jira] Updated: (WODEN-140) DescriptionElement.getNamespaces()
should have a type-safe return type
Posted by "John Kaputin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WODEN-140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Kaputin updated WODEN-140:
-------------------------------
Fix Version/s: M8
> DescriptionElement.getNamespaces() should have a type-safe return type
> ----------------------------------------------------------------------
>
> Key: WODEN-140
> URL: https://issues.apache.org/jira/browse/WODEN-140
> Project: Woden
> Issue Type: Improvement
> Components: Parser
> Reporter: John Kaputin
> Fix For: M8
>
>
> The DescriptionElement.getNamespaces() method currently returns a Map containing pairs of prefix String and namespace URI. In keeping with woden design goals and the rest of the API, this method should use a type-safe return type. Map, List, etc represent their content as java.lang.Object which requires casting.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org
[jira] Resolved: (WODEN-140) DescriptionElement.getNamespaces()
should have a type-safe return type
Posted by "John Kaputin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WODEN-140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Kaputin resolved WODEN-140.
--------------------------------
Resolution: Fixed
r599019
Fixed.
> DescriptionElement.getNamespaces() should have a type-safe return type
> ----------------------------------------------------------------------
>
> Key: WODEN-140
> URL: https://issues.apache.org/jira/browse/WODEN-140
> Project: Woden
> Issue Type: Improvement
> Components: Parser
> Reporter: John Kaputin
> Assignee: Dan Harvey
> Fix For: M8
>
> Attachments: woden-140 - namespace scope.patch, Woden-140.patch.txt, woden140_final.patch, woden140_option1.patch, woden140_option2.patch
>
>
> The DescriptionElement.getNamespaces() method currently returns a Map containing pairs of prefix String and namespace URI. In keeping with woden design goals and the rest of the API, this method should use a type-safe return type. Map, List, etc represent their content as java.lang.Object which requires casting.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org
[jira] Assigned: (WODEN-140) DescriptionElement.getNamespaces()
should have a type-safe return type
Posted by "Dan Harvey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WODEN-140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dan Harvey reassigned WODEN-140:
--------------------------------
Assignee: Dan Harvey (was: John Kaputin)
> DescriptionElement.getNamespaces() should have a type-safe return type
> ----------------------------------------------------------------------
>
> Key: WODEN-140
> URL: https://issues.apache.org/jira/browse/WODEN-140
> Project: Woden
> Issue Type: Improvement
> Components: Parser
> Reporter: John Kaputin
> Assignee: Dan Harvey
> Fix For: M8
>
>
> The DescriptionElement.getNamespaces() method currently returns a Map containing pairs of prefix String and namespace URI. In keeping with woden design goals and the rest of the API, this method should use a type-safe return type. Map, List, etc represent their content as java.lang.Object which requires casting.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org
[jira] Assigned: (WODEN-140) DescriptionElement.getNamespaces()
should have a type-safe return type
Posted by "John Kaputin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WODEN-140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Kaputin reassigned WODEN-140:
----------------------------------
Assignee: John Kaputin
> DescriptionElement.getNamespaces() should have a type-safe return type
> ----------------------------------------------------------------------
>
> Key: WODEN-140
> URL: https://issues.apache.org/jira/browse/WODEN-140
> Project: Woden
> Issue Type: Improvement
> Components: Parser
> Reporter: John Kaputin
> Assignee: John Kaputin
> Fix For: M8
>
>
> The DescriptionElement.getNamespaces() method currently returns a Map containing pairs of prefix String and namespace URI. In keeping with woden design goals and the rest of the API, this method should use a type-safe return type. Map, List, etc represent their content as java.lang.Object which requires casting.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org
[jira] Commented: (WODEN-140) DescriptionElement.getNamespaces()
should have a type-safe return type
Posted by "Dan Harvey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WODEN-140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12527541 ]
Dan Harvey commented on WODEN-140:
----------------------------------
After looking into these two different options 1) makes more sense for Woden at the moment in time to keep a consistent style of return types with the API. This is the option I have implemented and added in the final patch "woden-140 - namespace scope.patch" to the 140 branch. Option 2) would probably be tidier with newer versions of java but would require larger changes to Woden to have a consistent API. As there are very little code differences for the implementation of 1) and 2) it can very easily be changed over when a future revision of the Woden API happens.
This solves the issue specified in this Jira and adds scope support for namespaces on any wsdl element.
> DescriptionElement.getNamespaces() should have a type-safe return type
> ----------------------------------------------------------------------
>
> Key: WODEN-140
> URL: https://issues.apache.org/jira/browse/WODEN-140
> Project: Woden
> Issue Type: Improvement
> Components: Parser
> Reporter: John Kaputin
> Assignee: Dan Harvey
> Fix For: M8
>
> Attachments: woden-140 - namespace scope.patch, Woden-140.patch.txt, woden140_option1.patch, woden140_option2.patch
>
>
> The DescriptionElement.getNamespaces() method currently returns a Map containing pairs of prefix String and namespace URI. In keeping with woden design goals and the rest of the API, this method should use a type-safe return type. Map, List, etc represent their content as java.lang.Object which requires casting.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org
[jira] Updated: (WODEN-140) DescriptionElement.getNamespaces()
should have a type-safe return type
Posted by "Jeremy Hughes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WODEN-140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeremy Hughes updated WODEN-140:
--------------------------------
Fix Version/s: M7
> DescriptionElement.getNamespaces() should have a type-safe return type
> ----------------------------------------------------------------------
>
> Key: WODEN-140
> URL: https://issues.apache.org/jira/browse/WODEN-140
> Project: Woden
> Issue Type: Improvement
> Components: Parser
> Reporter: John Kaputin
>
> The DescriptionElement.getNamespaces() method currently returns a Map containing pairs of prefix String and namespace URI. In keeping with woden design goals and the rest of the API, this method should use a type-safe return type. Map, List, etc represent their content as java.lang.Object which requires casting.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org
[jira] Updated: (WODEN-140) DescriptionElement.getNamespaces()
should have a type-safe return type
Posted by "Dan Harvey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WODEN-140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dan Harvey updated WODEN-140:
-----------------------------
Attachment: Woden-140.patch.txt
> DescriptionElement.getNamespaces() should have a type-safe return type
> ----------------------------------------------------------------------
>
> Key: WODEN-140
> URL: https://issues.apache.org/jira/browse/WODEN-140
> Project: Woden
> Issue Type: Improvement
> Components: Parser
> Reporter: John Kaputin
> Assignee: Dan Harvey
> Fix For: M8
>
> Attachments: Woden-140.patch.txt
>
>
> The DescriptionElement.getNamespaces() method currently returns a Map containing pairs of prefix String and namespace URI. In keeping with woden design goals and the rest of the API, this method should use a type-safe return type. Map, List, etc represent their content as java.lang.Object which requires casting.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org