You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "thswlsqls (via GitHub)" <gi...@apache.org> on 2026/06/20 01:13:54 UTC
[PR] Delta: Fix invalid @Returns Javadoc tag in SnapshotDeltaLakeTable [iceberg]
thswlsqls opened a new pull request, #16887:
URL: https://github.com/apache/iceberg/pull/16887
<!-- No issue: minor docs fix, issue not required -->
## Summary
- The `as`, `icebergCatalog`, and `deltaLakeConfiguration` builder methods appended `@Returns this for method chaining` to their `@param` line.
- `@Returns` is not a valid Javadoc tag, so the return value was never documented.
- Replaced it with a `@return this for method chaining` line, matching the sibling methods `tableProperties`, `tableProperty`, and `tableLocation` in the same interface (lines 38, 48, 57), which already use `@return` on its own line.
- File: `delta-lake/src/main/java/org/apache/iceberg/delta/SnapshotDeltaLakeTable.java`.
## Testing done
- Docs/comment-only change, no behavior change — no test added. `./gradlew :iceberg-delta-lake:spotlessCheck` passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Delta: Fix invalid @Returns Javadoc tag in SnapshotDeltaLakeTable [iceberg]
Posted by "thswlsqls (via GitHub)" <gi...@apache.org>.
thswlsqls commented on PR #16887:
URL: https://github.com/apache/iceberg/pull/16887#issuecomment-5124255535
Not stale — approved by @ebyhr, CI is green, and it still merges cleanly. Could a committer merge this, or let me know if you'd prefer a rebase first?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Delta: Fix invalid @Returns Javadoc tag in SnapshotDeltaLakeTable [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #16887:
URL: https://github.com/apache/iceberg/pull/16887#issuecomment-5555794233
This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Delta: Fix invalid @Returns Javadoc tag in SnapshotDeltaLakeTable [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #16887: Delta: Fix invalid @Returns Javadoc tag in SnapshotDeltaLakeTable
URL: https://github.com/apache/iceberg/pull/16887
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Delta: Fix invalid @Returns Javadoc tag in SnapshotDeltaLakeTable [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #16887:
URL: https://github.com/apache/iceberg/pull/16887#issuecomment-5465750599
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Delta: Fix invalid @Returns Javadoc tag in SnapshotDeltaLakeTable [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #16887:
URL: https://github.com/apache/iceberg/pull/16887#issuecomment-5064885991
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org