You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Rajani Karuturi <ra...@gmail.com> on 2013/12/12 10:10:17 UTC

Review Request 16212: encrypted ldap params

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16212/
-----------------------------------------------------------

Review request for cloudstack, Abhinandan Prateek and Ian Duffy.


Bugs: CLOUDSTACK-5435
    https://issues.apache.org/jira/browse/CLOUDSTACK-5435


Repository: cloudstack-git


Description
-------

added encryption for ldap config params


Diffs
-----

  plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LDAPConfigCmd.java 3faf8b7 
  plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/response/LdapConfigurationResponse.java a4e4782 
  plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapConfigurationVO.java 488e7f4 
  plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java 578ebce 
  setup/db/db/schema-421to430.sql 1ec4e94 

Diff: https://reviews.apache.org/r/16212/diff/


Testing
-------

manually tested


Thanks,

Rajani Karuturi


Re: Review Request 16212: encrypted ldap params

Posted by Abhinandan Prateek <ap...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16212/#review30253
-----------------------------------------------------------

Ship it!


Ship It!

- Abhinandan Prateek


On Dec. 12, 2013, 9:10 a.m., Rajani Karuturi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16212/
> -----------------------------------------------------------
> 
> (Updated Dec. 12, 2013, 9:10 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Ian Duffy.
> 
> 
> Bugs: CLOUDSTACK-5435
>     https://issues.apache.org/jira/browse/CLOUDSTACK-5435
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> added encryption for ldap config params
> 
> 
> Diffs
> -----
> 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LDAPConfigCmd.java 3faf8b7 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/response/LdapConfigurationResponse.java a4e4782 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapConfigurationVO.java 488e7f4 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java 578ebce 
>   setup/db/db/schema-421to430.sql 1ec4e94 
> 
> Diff: https://reviews.apache.org/r/16212/diff/
> 
> 
> Testing
> -------
> 
> manually tested
> 
> 
> Thanks,
> 
> Rajani Karuturi
> 
>


Re: Review Request 16212: encrypted ldap params

Posted by Kishan Kavala <Ki...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16212/#review30337
-----------------------------------------------------------

Ship it!


Coonited to 4.3
commit 24392c15f561fa07fd5f707bbfa6910d880c3a3b

- Kishan Kavala


On Dec. 12, 2013, 3:53 p.m., Rajani Karuturi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16212/
> -----------------------------------------------------------
> 
> (Updated Dec. 12, 2013, 3:53 p.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Ian Duffy.
> 
> 
> Bugs: CLOUDSTACK-5435
>     https://issues.apache.org/jira/browse/CLOUDSTACK-5435
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> added encryption for ldap config params
> 
> 
> Diffs
> -----
> 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LDAPConfigCmd.java 3faf8b7 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/response/LdapConfigurationResponse.java 39d5bae 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapConfigurationVO.java 98e42f8 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java 578ebce 
>   setup/db/db/schema-421to430.sql ffde64e 
> 
> Diff: https://reviews.apache.org/r/16212/diff/
> 
> 
> Testing
> -------
> 
> manually tested
> 
> 
> Thanks,
> 
> Rajani Karuturi
> 
>


Re: Review Request 16212: encrypted ldap params

Posted by Rajani Karuturi <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16212/
-----------------------------------------------------------

(Updated Dec. 13, 2013, 7:33 a.m.)


Review request for cloudstack, Abhinandan Prateek and Ian Duffy.


Bugs: CLOUDSTACK-5435
    https://issues.apache.org/jira/browse/CLOUDSTACK-5435


Repository: cloudstack-git


Description
-------

added encryption for ldap config params


Diffs (updated)
-----

  plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LDAPConfigCmd.java 5e424de 
  plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/response/LdapConfigurationResponse.java a4e4782 
  plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapConfigurationVO.java 488e7f4 
  plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java 6d71f4f 
  setup/db/db/schema-421to430.sql 532a33a 

Diff: https://reviews.apache.org/r/16212/diff/


Testing
-------

manually tested


Thanks,

Rajani Karuturi


Re: Review Request 16212: encrypted ldap params

Posted by Rajani Karuturi <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16212/
-----------------------------------------------------------

(Updated Dec. 12, 2013, 10:23 a.m.)


Review request for cloudstack, Abhinandan Prateek and Ian Duffy.


Bugs: CLOUDSTACK-5435
    https://issues.apache.org/jira/browse/CLOUDSTACK-5435


Repository: cloudstack-git


Description
-------

added encryption for ldap config params


Diffs (updated)
-----

  plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LDAPConfigCmd.java 3faf8b7 
  plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/response/LdapConfigurationResponse.java 39d5bae 
  plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapConfigurationVO.java 98e42f8 
  plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java 578ebce 
  setup/db/db/schema-421to430.sql ffde64e 

Diff: https://reviews.apache.org/r/16212/diff/


Testing
-------

manually tested


Thanks,

Rajani Karuturi