You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2017/04/22 02:48:23 UTC
Review Request 58644: Improved POSIX disk isolator to report usage for
persistent volumes.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58644/
-----------------------------------------------------------
Review request for mesos, Gilbert Song and Artem Harutyunyan.
Bugs: MESOS-4263
https://issues.apache.org/jira/browse/MESOS-4263
Repository: mesos
Description
-------
Improved POSIX disk isolator to report usage for persistent volumes.
Diffs
-----
include/mesos/mesos.proto eaa2d2ac697cfc4f5aa56db0fb37363339608f43
include/mesos/v1/mesos.proto 1a32a7bdc991c77b35a988bf8a34cee936c97608
src/slave/containerizer/mesos/isolators/posix/disk.cpp 127f490cc0622293b4ace34510f8459b340e1742
Diff: https://reviews.apache.org/r/58644/diff/1/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 58644: Improved POSIX disk isolator to report
usage for persistent volumes.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58644/#review172891
-----------------------------------------------------------
src/slave/containerizer/mesos/isolators/posix/disk.cpp
Lines 396-408 (original), 395-407 (patched)
<https://reviews.apache.org/r/58644/#comment245913>
I should remove this. Not needed anymore.
- Jie Yu
On April 22, 2017, 2:48 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58644/
> -----------------------------------------------------------
>
> (Updated April 22, 2017, 2:48 a.m.)
>
>
> Review request for mesos, Gilbert Song and Artem Harutyunyan.
>
>
> Bugs: MESOS-4263
> https://issues.apache.org/jira/browse/MESOS-4263
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Improved POSIX disk isolator to report usage for persistent volumes.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto eaa2d2ac697cfc4f5aa56db0fb37363339608f43
> include/mesos/v1/mesos.proto 1a32a7bdc991c77b35a988bf8a34cee936c97608
> src/slave/containerizer/mesos/isolators/posix/disk.cpp 127f490cc0622293b4ace34510f8459b340e1742
>
>
> Diff: https://reviews.apache.org/r/58644/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 58644: Improved POSIX disk isolator to report
usage for persistent volumes.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58644/#review172983
-----------------------------------------------------------
Fix it, then Ship it!
src/slave/containerizer/mesos/isolators/posix/disk.cpp
Line 405 (original), 404 (patched)
<https://reviews.apache.org/r/58644/#comment246029>
As you already noticed, this logic is already included in the following code.
src/slave/containerizer/mesos/isolators/posix/disk.cpp
Lines 437-444 (patched)
<https://reviews.apache.org/r/58644/#comment246030>
Could we merge these two `if` into one?
- Gilbert Song
On April 21, 2017, 7:48 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58644/
> -----------------------------------------------------------
>
> (Updated April 21, 2017, 7:48 p.m.)
>
>
> Review request for mesos, Gilbert Song and Artem Harutyunyan.
>
>
> Bugs: MESOS-4263
> https://issues.apache.org/jira/browse/MESOS-4263
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Improved POSIX disk isolator to report usage for persistent volumes.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto eaa2d2ac697cfc4f5aa56db0fb37363339608f43
> include/mesos/v1/mesos.proto 1a32a7bdc991c77b35a988bf8a34cee936c97608
> src/slave/containerizer/mesos/isolators/posix/disk.cpp 127f490cc0622293b4ace34510f8459b340e1742
>
>
> Diff: https://reviews.apache.org/r/58644/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>