You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/04/30 07:12:05 UTC

[GitHub] [pulsar-client-go] mileschao opened a new pull request #237: [Issue #200] feature: add internal connectionReader readAtLeast error information

mileschao opened a new pull request #237:
URL: https://github.com/apache/pulsar-client-go/pull/237


   
   Master Issue: #200 
   
   ### Motivation
   
   add internal connectionReader readAtLeast error information
   these error information may help to solve #200 
   
   ### Modifications
   
   function ```readAtLeast``` return error type 
   
   ### Verifying this change
   
   This change is already covered by existing tests, such as *(please describe tests)*.
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (yes / ***no***)
     - The public API: (yes / ***no***)
     - The schema: (yes / ***no*** / don't know)
     - The default values of configurations: (yes / ***no***)
     - The wire protocol: (yes / ***no***)
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (yes / ***no***)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar-client-go] wolfstudy merged pull request #237: [Issue #200] feature: add internal connectionReader readAtLeast error information

Posted by GitBox <gi...@apache.org>.
wolfstudy merged pull request #237:
URL: https://github.com/apache/pulsar-client-go/pull/237


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar-client-go] mileschao commented on pull request #237: [Issue #200] feature: add internal connectionReader readAtLeast error information

Posted by GitBox <gi...@apache.org>.
mileschao commented on pull request #237:
URL: https://github.com/apache/pulsar-client-go/pull/237#issuecomment-621662203


   @sijie @wolfstudy 
   I've add some error information for #200 
   It help to solve problem. :-)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org