You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/06/03 09:01:40 UTC
[GitHub] [spark] HyukjinKwon opened a new pull request, #36759: [SPARK-39373][PYTHON][3.2] Recover branch-3.2 build broken by SPARK-39273 and SPARK-39252
HyukjinKwon opened a new pull request, #36759:
URL: https://github.com/apache/spark/pull/36759
### What changes were proposed in this pull request?
Backporting SPARK-39273 and SPARK-39252 brought some mistakes together into branch-3.2. This PR fixes it. One is to avoid exact match (by a different pandas version). Another one is unused import.
### Why are the changes needed?
To recover the build
### Does this PR introduce _any_ user-facing change?
No, test-only.
### How was this patch tested?
CI in this PR should test it out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #36759: [SPARK-39373][PYTHON][3.2] Recover branch-3.2 build broken by SPARK-39273 and SPARK-39252
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on code in PR #36759:
URL: https://github.com/apache/spark/pull/36759#discussion_r888821336
##########
python/pyspark/pandas/tests/test_series.py:
##########
@@ -2201,7 +2201,7 @@ def test_mad(self):
pser.index = pmidx
psser = ps.from_pandas(pser)
- self.assert_eq(pser.mad(), psser.mad())
+ self.assert_eq(pser.mad(), psser.mad(), check_exact=False)
Review Comment:
```suggestion
self.assert_eq(pser.mad(), psser.mad(), almost=True)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #36759: [SPARK-39373][PYTHON][3.2] Recover branch-3.2 build broken by SPARK-39273 and SPARK-39252
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #36759: [SPARK-39373][PYTHON][3.2] Recover branch-3.2 build broken by SPARK-39273 and SPARK-39252
URL: https://github.com/apache/spark/pull/36759
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #36759: [SPARK-39373][PYTHON][3.2] Recover branch-3.2 build broken by SPARK-39273 and SPARK-39252
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #36759:
URL: https://github.com/apache/spark/pull/36759#issuecomment-1145932875
Merged to branch-3.2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org