You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Alex Blewitt (JIRA)" <ji...@apache.org> on 2007/01/11 00:13:28 UTC
[jira] Created: (HARMONY-2966) [website] Add caveats about binary
files in svn diffs
[website] Add caveats about binary files in svn diffs
-----------------------------------------------------
Key: HARMONY-2966
URL: https://issues.apache.org/jira/browse/HARMONY-2966
Project: Harmony
Issue Type: Improvement
Components: Website/Documentation
Reporter: Alex Blewitt
Priority: Minor
Attachments: get-involved.xml.patch
Adding caveat for binary files, along with a 'grep' command that can be used to determine such in an existing patch
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (HARMONY-2966) [website] Add caveats about binary
files in svn diffs
Posted by "Nadya Morozova (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-2966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nadya Morozova reassigned HARMONY-2966:
---------------------------------------
Assignee: Nadya Morozova
> [website] Add caveats about binary files in svn diffs
> -----------------------------------------------------
>
> Key: HARMONY-2966
> URL: https://issues.apache.org/jira/browse/HARMONY-2966
> Project: Harmony
> Issue Type: Improvement
> Components: Website/Documentation
> Reporter: Alex Blewitt
> Assigned To: Nadya Morozova
> Priority: Minor
> Attachments: get-involved.xml.patch
>
>
> Adding caveat for binary files, along with a 'grep' command that can be used to determine such in an existing patch
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-2966) [website] Add caveats about binary
files in svn diffs
Posted by "Alex Blewitt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-2966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Blewitt updated HARMONY-2966:
----------------------------------
Attachment: get-involved.xml.patch
> [website] Add caveats about binary files in svn diffs
> -----------------------------------------------------
>
> Key: HARMONY-2966
> URL: https://issues.apache.org/jira/browse/HARMONY-2966
> Project: Harmony
> Issue Type: Improvement
> Components: Website/Documentation
> Reporter: Alex Blewitt
> Priority: Minor
> Attachments: get-involved.xml.patch
>
>
> Adding caveat for binary files, along with a 'grep' command that can be used to determine such in an existing patch
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-2966) [website] Add caveats about binary
files in svn diffs
Posted by "Nadya Morozova (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-2966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12465804 ]
Nadya Morozova commented on HARMONY-2966:
-----------------------------------------
I added another patch and the resulting HTML for simplicity.
the current version of the page includes Alex's new text and reogranizes the page a bit. The Patch part is now split into generic tips on submitting issues and specific tips on diffing and patching. I also used the example of patching command from the Patch Format section of Project Guidelines. I guess we can remove that section all in all now.
I hope these changes are ok with you. I'll upload to svn when you verify it's really ok.
thanks, nadya
> [website] Add caveats about binary files in svn diffs
> -----------------------------------------------------
>
> Key: HARMONY-2966
> URL: https://issues.apache.org/jira/browse/HARMONY-2966
> Project: Harmony
> Issue Type: Improvement
> Components: Website/Documentation
> Reporter: Alex Blewitt
> Assigned To: Nadya Morozova
> Priority: Minor
> Attachments: get-involved.html, get-involved.xml.patch, get-involved.xml2.patch
>
>
> Adding caveat for binary files, along with a 'grep' command that can be used to determine such in an existing patch
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-2966) [website] Add caveats about binary
files in svn diffs
Posted by "Nadya Morozova (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-2966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12464854 ]
Nadya Morozova commented on HARMONY-2966:
-----------------------------------------
Thanks for this suggestion!
I'll look into this patch. A first glance shows you're adding really useful stuff. However, the simple merge has not worked (some differences in the text) - I'll try resolve the conflict soon.
cosmetic suggestions:
- use <code></code> tags instead of single quotes ' ' to mark commands, filenames, etc. we've followed this conventions in a number of pages on the website, so being consistent could help.
- use <source>, not <pre> for preformatted text in xml files. Both actually work, but <source> was especially introduced for xml-based website, so again for consistency reasons, we might as well stick to one version as much as possible.
what do you say?
Cheers, Nadya
> [website] Add caveats about binary files in svn diffs
> -----------------------------------------------------
>
> Key: HARMONY-2966
> URL: https://issues.apache.org/jira/browse/HARMONY-2966
> Project: Harmony
> Issue Type: Improvement
> Components: Website/Documentation
> Reporter: Alex Blewitt
> Assigned To: Nadya Morozova
> Priority: Minor
> Attachments: get-involved.xml.patch
>
>
> Adding caveat for binary files, along with a 'grep' command that can be used to determine such in an existing patch
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (HARMONY-2966) [website] Add caveats about binary
files in svn diffs
Posted by "Nadya Morozova (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-2966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nadya Morozova closed HARMONY-2966.
-----------------------------------
suggested fix appeared on the website, all works well.
> [website] Add caveats about binary files in svn diffs
> -----------------------------------------------------
>
> Key: HARMONY-2966
> URL: https://issues.apache.org/jira/browse/HARMONY-2966
> Project: Harmony
> Issue Type: Improvement
> Components: Website/Documentation
> Reporter: Alex Blewitt
> Assigned To: Nadya Morozova
> Priority: Minor
> Attachments: get-involved.html, get-involved.xml.patch, get-involved.xml2.patch
>
>
> Adding caveat for binary files, along with a 'grep' command that can be used to determine such in an existing patch
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-2966) [website] Add caveats about binary
files in svn diffs
Posted by "Nadya Morozova (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-2966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nadya Morozova updated HARMONY-2966:
------------------------------------
Attachment: get-involved.html
get-involved.xml2.patch
> [website] Add caveats about binary files in svn diffs
> -----------------------------------------------------
>
> Key: HARMONY-2966
> URL: https://issues.apache.org/jira/browse/HARMONY-2966
> Project: Harmony
> Issue Type: Improvement
> Components: Website/Documentation
> Reporter: Alex Blewitt
> Assigned To: Nadya Morozova
> Priority: Minor
> Attachments: get-involved.html, get-involved.xml.patch, get-involved.xml2.patch
>
>
> Adding caveat for binary files, along with a 'grep' command that can be used to determine such in an existing patch
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-2966) [website] Add caveats about binary
files in svn diffs
Posted by "Nadya Morozova (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-2966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12465435 ]
Nadya Morozova commented on HARMONY-2966:
-----------------------------------------
Alex wrote to me (somehow, it's not here)
> Feel free to make any changes like code and source if you think that's right. Can you make the changes? I am unable to get onto SVN from here for the next couple of weeks.
Yes, Alex, I can try and provide a patch closer to the end of the week. If you could review before I commit, that would be great.
thanks for doing this,
Nadya
> [website] Add caveats about binary files in svn diffs
> -----------------------------------------------------
>
> Key: HARMONY-2966
> URL: https://issues.apache.org/jira/browse/HARMONY-2966
> Project: Harmony
> Issue Type: Improvement
> Components: Website/Documentation
> Reporter: Alex Blewitt
> Assigned To: Nadya Morozova
> Priority: Minor
> Attachments: get-involved.xml.patch
>
>
> Adding caveat for binary files, along with a 'grep' command that can be used to determine such in an existing patch
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-2966) [website] Add caveats about binary
files in svn diffs
Posted by "Alex Blewitt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-2966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12465828 ]
Alex Blewitt commented on HARMONY-2966:
---------------------------------------
Looks good to me :-)
> [website] Add caveats about binary files in svn diffs
> -----------------------------------------------------
>
> Key: HARMONY-2966
> URL: https://issues.apache.org/jira/browse/HARMONY-2966
> Project: Harmony
> Issue Type: Improvement
> Components: Website/Documentation
> Reporter: Alex Blewitt
> Assigned To: Nadya Morozova
> Priority: Minor
> Attachments: get-involved.html, get-involved.xml.patch, get-involved.xml2.patch
>
>
> Adding caveat for binary files, along with a 'grep' command that can be used to determine such in an existing patch
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (HARMONY-2966) [website] Add caveats about binary
files in svn diffs
Posted by "Nadya Morozova (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-2966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nadya Morozova resolved HARMONY-2966.
-------------------------------------
Resolution: Fixed
Committed new version of the Get Involved page at revision: 497721.
> [website] Add caveats about binary files in svn diffs
> -----------------------------------------------------
>
> Key: HARMONY-2966
> URL: https://issues.apache.org/jira/browse/HARMONY-2966
> Project: Harmony
> Issue Type: Improvement
> Components: Website/Documentation
> Reporter: Alex Blewitt
> Assigned To: Nadya Morozova
> Priority: Minor
> Attachments: get-involved.html, get-involved.xml.patch, get-involved.xml2.patch
>
>
> Adding caveat for binary files, along with a 'grep' command that can be used to determine such in an existing patch
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira