You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@isis.apache.org by ah...@apache.org on 2022/03/03 20:57:48 UTC

[isis] branch master updated: ISIS-2877: blob/clob: adds tooltips to edit/download icons

This is an automated email from the ASF dual-hosted git repository.

ahuber pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/isis.git


The following commit(s) were added to refs/heads/master by this push:
     new 0dbbb59  ISIS-2877: blob/clob: adds tooltips to edit/download icons
0dbbb59 is described below

commit 0dbbb59b5d7e7cbae91cca067769de62df25740e
Author: Andi Huber <ah...@apache.org>
AuthorDate: Thu Mar 3 21:57:38 2022 +0100

    ISIS-2877: blob/clob: adds tooltips to edit/download icons
---
 .../isis/viewer/wicket/ui/components/scalars/ScalarPanelAbstract.java   | 1 +
 .../ui/components/scalars/blobclob/IsisBlobOrClobPanelAbstract.java     | 2 ++
 2 files changed, 3 insertions(+)

diff --git a/viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/scalars/ScalarPanelAbstract.java b/viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/scalars/ScalarPanelAbstract.java
index e4d8c43..bceb653 100644
--- a/viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/scalars/ScalarPanelAbstract.java
+++ b/viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/scalars/ScalarPanelAbstract.java
@@ -690,6 +690,7 @@ implements ScalarModelSubscriber, HasScalarModel {
                         !getInlinePromptConfig().isSupported())) {
             val editProperty = Wkt.containerAdd(componentIfRegular, ID_EDIT_PROPERTY);
             Wkt.behaviorAddOnClick(editProperty, this::onPropertyEditClick);
+            Tooltips.addTooltip(editProperty, "edit");
         } else {
             Components.permanentlyHide(componentIfRegular, ID_EDIT_PROPERTY);
         }
diff --git a/viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/scalars/blobclob/IsisBlobOrClobPanelAbstract.java b/viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/scalars/blobclob/IsisBlobOrClobPanelAbstract.java
index d287aee..4943c46 100644
--- a/viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/scalars/blobclob/IsisBlobOrClobPanelAbstract.java
+++ b/viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/scalars/blobclob/IsisBlobOrClobPanelAbstract.java
@@ -44,6 +44,7 @@ import org.apache.isis.viewer.wicket.ui.components.scalars.ScalarPanelWithFormFi
 import org.apache.isis.viewer.wicket.ui.components.scalars.image.WicketImageUtil;
 import org.apache.isis.viewer.wicket.ui.components.widgets.bootstrap.FormGroup;
 import org.apache.isis.viewer.wicket.ui.util.Components;
+import org.apache.isis.viewer.wicket.ui.util.Tooltips;
 import org.apache.isis.viewer.wicket.ui.util.Wkt;
 
 import lombok.val;
@@ -357,6 +358,7 @@ extends ScalarPanelWithFormFieldAbstract<T> {
         val resourceLink = createResourceLink(downloadId);
         if(resourceLink != null) {
             parent.addOrReplace(resourceLink);
+            Tooltips.addTooltip(resourceLink, "download");
         } else {
             Components.permanentlyHide(parent, downloadId);
         }